From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_MED,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6EAFC4321A for ; Mon, 10 Jun 2019 23:12:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82D8120859 for ; Mon, 10 Jun 2019 23:12:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UkMEzD+0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390520AbfFJXMn (ORCPT ); Mon, 10 Jun 2019 19:12:43 -0400 Received: from mail-pg1-f201.google.com ([209.85.215.201]:37282 "EHLO mail-pg1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390515AbfFJXMm (ORCPT ); Mon, 10 Jun 2019 19:12:42 -0400 Received: by mail-pg1-f201.google.com with SMTP id e16so7839278pga.4 for ; Mon, 10 Jun 2019 16:12:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=m4TLZqPEMkq/tS1ogLQKWFfOaA0aQt4zNnp6rjUI2w4=; b=UkMEzD+09sYBsteTJ5/alXDUOxw6Tq6bBhA4ABzjkFspCkfxeNT6Q/ogiW+QlS75/f RP8KOXBb1b8V3cGS28WKIVMk96e9Tw/n7uRKQ3fugHdAr1yH5uAgK9IsJeBYJ2nethye uIMlEj0mXHbYBnrIquiXFy5vGOCubhs7pDPX8C72GaMAaULIBaTAfp6W/ACf03ZRu9HK PFUfr8Ncln++Fms8sEvUe46lDLEZ12psNgEIKFQrCn11U8CGX40vj6gfSAX6cTwLpKF+ cGbpOdkYG53V4/Hz9mOp1OARhfROgx3ziTkmWHiailuNp1F5OSdRwzhN5QyZ+Xy7nJDe 7dPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=m4TLZqPEMkq/tS1ogLQKWFfOaA0aQt4zNnp6rjUI2w4=; b=qqn2xhaSZ4gnEQY8wVXwRNouQhBde/dFRiSqcvmptehDUi2HAjz4o2/7sGv+iFUmoI yNDebuEFuBe++l72qItPZC8m4+iyi0KfgYd646mtinYXQ2KtE3EgszPwQo9K4qF3Nz2q jBqhpm+ep40zN7U3LQ1eihZ3HSSg5+mIpuQiVj1Gs1YpqGxzMQPzr/ygolUhOYwj8BPK EFvs1xqqmCSUCPf8BKOc9SLmOtqc6ayFtFbKw+1Ug4EujsohNxscXYcgalxFzJK5YzJP dl17ohiqcyjGkKVBOiIKhpxS3nKPZRrrjqUJIAkFWZWbhn1aCfADglpXbeyJ05AvjTsI jzow== X-Gm-Message-State: APjAAAVZfh5bWqhnYwhQ5VekJGnYWYxbEODjwioY/e0OXEk6hdg/BKaw sxtNT7Cjxl7OyVDx9WhDXP3hNU69Svo3tu8= X-Google-Smtp-Source: APXvYqzj61nHsPV2Nnz8RkGG1t3bqBBH1v4vRGcQxQnVXAszVjWtTkb2v4p79LlH8bRM5ywLvfTa3IAI7Cpo+fg= X-Received: by 2002:a63:364f:: with SMTP id d76mr10242426pga.147.1560208361843; Mon, 10 Jun 2019 16:12:41 -0700 (PDT) Date: Mon, 10 Jun 2019 16:12:39 -0700 In-Reply-To: <20190608054711.GZ22737@tuxbook-pro> Message-Id: <20190610231239.103913-1-saravanak@google.com> Mime-Version: 1.0 References: <20190608054711.GZ22737@tuxbook-pro> X-Mailer: git-send-email 2.22.0.rc2.383.gf4fbbf30c2-goog Subject: [Example code] crypto: qcom-rng: Add interconnect devfreq support From: Saravana Kannan To: Georgi Djakov , Rob Herring , Mark Rutland , Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , 0001-crypto-qcom-rng-Add-interconnect-dev.patch@google.com Cc: Saravana Kannan , Rajendra Nayak , Jordan Crouse , vincent.guittot@linaro.org, bjorn.andersson@linaro.org, amit.kucheria@linaro.org, seansw@qti.qualcomm.com, daidavid1@codeaurora.org, evgreen@chromium.org, sibis@codeaurora.org, kernel-team@android.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org This is just an example code and I'm not actually trying to get this merged. Bjorn, This is what the code would look like. It compiles, but I can't test it. I'm not sending this as part of the patch series as I'm not sure what the interconnects property should be set to in DT for qcom-rng device nor is QCOM RNG an ideal candidate for bandwidth scaling using devfreq. It can probably just set the bandwidth to some fixed low value like 1 KB/s. But this is pretty much all the code one would need if they wanted to enable interconnect scaling for their interconnect path using devfreq. -Saravana Signed-off-by: Saravana Kannan --- drivers/crypto/qcom-rng.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/crypto/qcom-rng.c b/drivers/crypto/qcom-rng.c index e54249ccc009..7a92238061ca 100644 --- a/drivers/crypto/qcom-rng.c +++ b/drivers/crypto/qcom-rng.c @@ -9,6 +9,7 @@ #include #include #include +#include #include /* Device specific register offsets */ @@ -37,6 +38,7 @@ struct qcom_rng_ctx { }; static struct qcom_rng *qcom_rng_dev; +static struct icc_devfreq *icc_df; static int qcom_rng_read(struct qcom_rng *rng, u8 *data, unsigned int max) { @@ -186,6 +188,13 @@ static int qcom_rng_probe(struct platform_device *pdev) qcom_rng_dev = NULL; } + ret = dev_pm_opp_of_add_table_indexed(&pdev->dev, 0); + if (ret) + return ret; + icc_df = icc_create_devfreq(&pdev->dev, "prng-slv"); + if (IS_ERR(icc_df)) + return PTR_ERR(icc_df); + return ret; } -- 2.22.0.rc2.383.gf4fbbf30c2-goog