From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>,
linux-kernel@vger.kernel.org, x86@kernel.org, bp@suse.de,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Kan Liang <kan.liang@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
platform-driver-x86@vger.kernel.org,
Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Len Brown <lenb@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [Patch v2] x86/cpu: Add Ice Lake NNPI to Intel family
Date: Wed, 12 Jun 2019 19:29:18 +0300 [thread overview]
Message-ID: <20190612162918.GP9224@smile.fi.intel.com> (raw)
In-Reply-To: <73eb1ba5-dc29-53ee-487d-d22700b874a1@intel.com>
On Wed, Jun 12, 2019 at 07:51:26AM -0700, Dave Hansen wrote:
> On 6/12/19 2:52 AM, Andy Shevchenko wrote:
> >> #define INTEL_FAM6_ICELAKE_MOBILE 0x7E
> >> +#define INTEL_FAM6_ICELAKE_NNPI 0x9D
> > What "I" stands for?
> >
> > For me sounds like it's redundant here or something like NNP_DLI would be
> > better (because somewhere we have _NP as for Network Processor).
>
> Let's not bikeshed this too much. These things aren't used that widely
> and mostly they're just used for figuring out the processor generation.
> It's exceedingly rare to have something like:
>
>
> if (model == INTEL_FAM6_ICELAKE_MOBILE)
> foo();
> else if (model == INTEL_FAM6_ICELAKE_NNPI)
> bar();
>
> where what you suggest would matter.
>
> Preserving the ability to google "ice lake nnpi" is pretty important, so
> preserving the Intel name makes a lot of sense here when possible.
What I'm talking is a consistency among suffixes. If there is a real
abbreviation (NNPI) which anybody can google, I'm totally for it to be used.
> Do we *HAVE* an Ice Lake network processor?
Not Ice Lake, something else.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-06-12 16:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 1:24 [Patch v2] x86/cpu: Add Ice Lake NNPI to Intel family Rajneesh Bhardwaj
2019-06-12 9:52 ` Andy Shevchenko
2019-06-12 14:51 ` Dave Hansen
2019-06-12 16:29 ` Andy Shevchenko [this message]
2019-06-12 16:33 ` Dave Hansen
2019-06-12 17:08 ` Andy Shevchenko
2019-06-12 17:12 ` Bhardwaj, Rajneesh
2019-06-12 12:37 ` [tip:x86/cpu] " tip-bot for Rajneesh Bhardwaj
2019-06-14 9:28 ` tip-bot for Rajneesh Bhardwaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612162918.GP9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kan.liang@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=rajneesh.bhardwaj@linux.intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).