From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB28EC31E45 for ; Thu, 13 Jun 2019 18:37:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 926762147A for ; Thu, 13 Jun 2019 18:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560451052; bh=U0plP2qgDJJQV2UXAiZ0BVK1gPAuJp5gn+oFC0ZI3vg=; h=Date:From:To:Cc:Subject:List-ID:From; b=Kdgt8Ak2XSQF8v7fg5HIEl/R3oFOJSpbAGLTfoI8d2Ux53d8+NznvBdKwH53dviRP RN1qTK+RkDOJJB5RDZRmbHJRRDTkmDr85tvgY8HksFA5LwsUR1Nx78Zrn5iSHn/Hjn DCJ7WrdAN34oBu52iAJQnIVovGrLQZJIIoVic530= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727058AbfFMShc (ORCPT ); Thu, 13 Jun 2019 14:37:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:33996 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725851AbfFMShc (ORCPT ); Thu, 13 Jun 2019 14:37:32 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E27C62133D; Thu, 13 Jun 2019 18:37:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560451051; bh=U0plP2qgDJJQV2UXAiZ0BVK1gPAuJp5gn+oFC0ZI3vg=; h=Date:From:To:Cc:Subject:From; b=kqt0bR4W6uDEdxXE4pQpoWrQJF44KN+rlPjxhQHpbQX91+CpReL3RNR2qybq9LGlk Nm9avHCTJFV2jK3XNMyav5AryNyskCLHnpvUd4ouuqBcmRTp4buz5yuPnsIIyDtnec Q20RbDSQUdD/oWKU/3fEx4qMRN6GuaYz9IWMv0Yo= Date: Thu, 13 Jun 2019 20:37:29 +0200 From: Greg Kroah-Hartman To: Zhang Rui , Eduardo Valentin , Daniel Lezcano , Florian Fainelli , Ray Jui , Scott Branden Cc: bcm-kernel-feedback-list@broadcom.com, linux-pm@vger.kernel.org Subject: [PATCH] thermal: bcm2835: no need to check return value of debugfs_create functions Message-ID: <20190613183729.GA32085@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Zhang Rui Cc: Eduardo Valentin Cc: Daniel Lezcano Cc: Florian Fainelli Cc: Ray Jui Cc: Scott Branden Cc: bcm-kernel-feedback-list@broadcom.com Cc: linux-pm@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/thermal/broadcom/bcm2835_thermal.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/thermal/broadcom/bcm2835_thermal.c b/drivers/thermal/broadcom/bcm2835_thermal.c index ba39647a690c..3199977f1e73 100644 --- a/drivers/thermal/broadcom/bcm2835_thermal.c +++ b/drivers/thermal/broadcom/bcm2835_thermal.c @@ -123,8 +123,6 @@ static void bcm2835_thermal_debugfs(struct platform_device *pdev) struct debugfs_regset32 *regset; data->debugfsdir = debugfs_create_dir("bcm2835_thermal", NULL); - if (!data->debugfsdir) - return; regset = devm_kzalloc(&pdev->dev, sizeof(*regset), GFP_KERNEL); if (!regset) -- 2.22.0