From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6615AC31E45 for ; Thu, 13 Jun 2019 21:12:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3971A21473 for ; Thu, 13 Jun 2019 21:12:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Hij3glu7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730234AbfFMVMr (ORCPT ); Thu, 13 Jun 2019 17:12:47 -0400 Received: from mail-oi1-f201.google.com ([209.85.167.201]:35329 "EHLO mail-oi1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725747AbfFMVMr (ORCPT ); Thu, 13 Jun 2019 17:12:47 -0400 Received: by mail-oi1-f201.google.com with SMTP id i132so80858oif.2 for ; Thu, 13 Jun 2019 14:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=F73bmQBhyaZz/5F17E2exd9oLZdsZmUd/nxm20yXKlg=; b=Hij3glu7oVn6Nsh5fxHUC/N4NPmbOfTsM/VYNb2Mvft11iu54EgM7k60O66qA27nVh ISUgkj8FrqcrAF2PUFq2tFhX/5Im0sDyDJltDfHuh1oETDJrPJp4wHPQKmUpt2ZqARB7 PHjkdJ1wYYh1iymPNM/P/tai3tBrTM04A77wfGwUfOLEs0wmbm4gz+hKFEuvSiPWrtaw m9sVU/lIU0IDaLmnlcHmmbowws2YSoZHBk08hs2GRZSxkoDBqAt/wjDPV6dwRIjwj0UN rvHmRtjI1HWDfikevKttQqWLwmxKGsVa1OCqsOen0tnvhsylB7T8xYvwYzycgqBKoOP0 3jwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=F73bmQBhyaZz/5F17E2exd9oLZdsZmUd/nxm20yXKlg=; b=pc6QFYwwxZV7NraK6nUUlV7WpOe4SEH531qyLR3CXGjExG2WrC/KgVB1366ZC/KXEU tt1qfGFocqSBsTwzRMDbNdI/pHhJ4bGybH09wBwdwNTaf6ILQTENO994qoBQsK7V0fYr Q8zs3+LzipUaNb5zzvf889IeGT2KehckQOqllIwATkPMHRk+hAHPdrfdsRW4TysP+RHh g7A7877XWALsDHy2CzPNFwQ81wHjA2ALzFShQkx5PY6wg5w/ng/p8YBBT4NX6WjkFHN1 WHNfpLoUd2YuP9p87c4iiNU3TqqGBfb0bgHTimvM9Dtnl8sLfIRDmKkKrnFRqzjvPha/ 9n8A== X-Gm-Message-State: APjAAAVAd/Il3O2AYgoTs3n30JmW5NEWtOLeY6a+0goKMd2ZK1GHnoEL bBM1ublAyxRGoEJWFCcYxzWa0yRpmQ== X-Google-Smtp-Source: APXvYqxfw1+oe9SB9sZWxTOs5duv5rsHABMQo1lxHtq8x0EYHKRS9MoXIIXHqukewEL4qOtgROYiw+b2AA== X-Received: by 2002:a9d:222c:: with SMTP id o41mr43289722ota.19.1560460366502; Thu, 13 Jun 2019 14:12:46 -0700 (PDT) Date: Thu, 13 Jun 2019 14:12:28 -0700 Message-Id: <20190613211228.34092-1-nhuck@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.22.0.rc2.383.gf4fbbf30c2-goog Subject: [PATCH] thermal: rcar_gen3_thermal: Fix Wshift-negative-value From: Nathan Huckleberry To: rui.zhang@intel.com, edubezval@gmail.com, daniel.lezcano@linaro.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Huckleberry , clang-built-linux@googlegroups.com Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Clang produces the following warning vers/thermal/rcar_gen3_thermal.c:147:33: warning: shifting a negative signed value is undefined [-Wshift-negative-value] / (ptat[0] - ptat[2])) + FIXPT_INT(TJ_3); ^~~~~~~~~~~~~~~ drivers/thermal/rcar_gen3_thermal.c:126:29 note: expanded from macro 'FIXPT_INT' #define FIXPT_INT(_x) ((_x) << FIXPT_SHIFT) ~~~~ ^ drivers/thermal/rcar_gen3_thermal.c:150:18: warning: shifting a negative signed value is undefined [-Wshift-negative-value] tsc->tj_t - FIXPT_INT(TJ_3)); ~~~~~~~~~~~~^~~~~~~~~~~~~~~~ Upon further investigating it looks like there is no real reason for TJ_3 to be -41. Usages subtract -41, code would be cleaner to just add. Fixes: 4eb39f79ef44 ("thermal: rcar_gen3_thermal: Update value of Tj_1") Cc: clang-built-linux@googlegroups.com Link: https://github.com/ClangBuiltLinux/linux/issues/531 Signed-off-by: Nathan Huckleberry --- drivers/thermal/rcar_gen3_thermal.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c index a56463308694..f4b4558c08e9 100644 --- a/drivers/thermal/rcar_gen3_thermal.c +++ b/drivers/thermal/rcar_gen3_thermal.c @@ -131,7 +131,7 @@ static inline void rcar_gen3_thermal_write(struct rcar_gen3_thermal_tsc *tsc, #define RCAR3_THERMAL_GRAN 500 /* mili Celsius */ /* no idea where these constants come from */ -#define TJ_3 -41 +#define TJ_3 41 static void rcar_gen3_thermal_calc_coefs(struct rcar_gen3_thermal_tsc *tsc, int *ptat, const int *thcode, @@ -144,11 +144,11 @@ static void rcar_gen3_thermal_calc_coefs(struct rcar_gen3_thermal_tsc *tsc, * the dividend (4095 * 4095 << 14 > INT_MAX) so keep it unscaled */ tsc->tj_t = (FIXPT_INT((ptat[1] - ptat[2]) * 157) - / (ptat[0] - ptat[2])) + FIXPT_INT(TJ_3); + / (ptat[0] - ptat[2])) - FIXPT_INT(TJ_3); tsc->coef.a1 = FIXPT_DIV(FIXPT_INT(thcode[1] - thcode[2]), - tsc->tj_t - FIXPT_INT(TJ_3)); - tsc->coef.b1 = FIXPT_INT(thcode[2]) - tsc->coef.a1 * TJ_3; + tsc->tj_t + FIXPT_INT(TJ_3)); + tsc->coef.b1 = FIXPT_INT(thcode[2]) + tsc->coef.a1 * TJ_3; tsc->coef.a2 = FIXPT_DIV(FIXPT_INT(thcode[1] - thcode[0]), tsc->tj_t - FIXPT_INT(ths_tj_1)); -- 2.22.0.rc2.383.gf4fbbf30c2-goog