From: Mark Brown <broonie@kernel.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: tony@atomide.com, lgirdwood@gmail.com,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, sboyd@kernel.org, nm@ti.com,
vireshk@kernel.org, letux-kernel@openphoenux.org
Subject: Re: [PATCH] regulator: twl: mark vdd1/2 as continuous on twl4030
Date: Mon, 17 Jun 2019 18:02:55 +0100 [thread overview]
Message-ID: <20190617170255.GF5316@sirena.org.uk> (raw)
In-Reply-To: <20190617182743.7f40f2ee@aktux>
[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]
On Mon, Jun 17, 2019 at 06:27:43PM +0200, Andreas Kemnade wrote:
> Citing tps65950 trm page 55:
> The device contains three switch-mode power supplies (SMPS):
> • VDD1: 1.2-A, buck DC/DC converter (VOUT = 0.6 V to 1.45 V, in steps of 12.5 mV)
> • VDD2: 600-mA buck DC/DC converter (VOUT = 0.6 V to 1.45 V, in steps of 12.5 mV, and 1.5 V as a
> single programmable value)
> you are right, they are not really continuous. So should I add these
> 68 steps they have as a voltage list?
There's helpers for linear mappings, you should be able to use those
(see helpers.c).
> I think they are nearly continuous, so we should IMHO rather take that
> not that strict. I guess there are no really continuous regulators, all
> have steps as voltage is specified in a limited resolution. So what is
> the exact meaning of that flag here?
This was added for devices with extremely high resolution interfaces
like some microcontroller interfaces that take voltage values directly
(mirroring the regulator API) or PWM regulators - it's for cases where
enumerating all the voltages is unreasonable. The TWL4030 regulators
look fairly standard in comparison.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-06-17 17:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-15 16:33 [PATCH] regulator: twl: mark vdd1/2 as continuous on twl4030 Andreas Kemnade
2019-06-17 10:31 ` Mark Brown
2019-06-17 11:03 ` Andreas Kemnade
2019-06-17 11:40 ` Mark Brown
2019-06-17 16:27 ` Andreas Kemnade
2019-06-17 17:02 ` Mark Brown [this message]
2019-06-17 17:21 ` Andreas Kemnade
2019-06-17 16:32 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617170255.GF5316@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andreas@kemnade.info \
--cc=letux-kernel@openphoenux.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).