From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 623C9C4646C for ; Mon, 24 Jun 2019 06:06:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3919E20674 for ; Mon, 24 Jun 2019 06:06:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ezovdk0f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726307AbfFXGGK (ORCPT ); Mon, 24 Jun 2019 02:06:10 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:44658 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726312AbfFXGGH (ORCPT ); Mon, 24 Jun 2019 02:06:07 -0400 Received: by mail-pl1-f193.google.com with SMTP id t7so6246383plr.11 for ; Sun, 23 Jun 2019 23:06:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rczLXy/YdSTRCqTeKDK2d2KcKBJ58Sk09VwtTR7c1D0=; b=ezovdk0fIqsbaH3BRH7IYNVk7pFaH+wp0P2j0nRBwNRuPMyUFoMbdVd+2jMTEDGVgo IZmW3IP4AXneC1YBX1129nHybakYDLNci6SALVR1OSMpqGN2hwHNlxo7C6EMmumZUC8P A50eUtMpOWgSRW6Kl0cjA31otm4ZsTHmV9fmDwu0B6gG8im13AwoVCybx5x4B08QQT4w 79fTu8xIps8bOQdDhp1oBfMCnZ+siksJOS/Vh1zp6ndB1fyTJs6jJ8pJgMCrOhlY12p+ DewbSP8RVVniYsQbxpu7TmpktfyQ1xPdQqJXtvBvoGaUMNbOLevIN5d9skSvnuqlKKxp lR6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rczLXy/YdSTRCqTeKDK2d2KcKBJ58Sk09VwtTR7c1D0=; b=ikOavoNNmDp9z0yuLEn1rKiNWQNRidfl8VZk5OpfzbvOcyrlshoaA7euGNQDCFJkKW s8nof73yxl+eZtf2AxyrawHE4LWB6byuCyI+YsO1xscW53wUjTRdZmWi893Tg9BNphph QXHxbb44IefQ8rXDjSY0BKtEk1Ntsd6rW6JJBO9ODoNFhVsjh6HBpNpWk3CyiDP8dDJ9 OEX1V1WdMHHkk4TUpyhGPhLU3dxXt/5AFhVaZqEXMEWykK26nsFHUsmCXhLhWuqlCVUk gb/xjqu9ufU/K8QkZ0JYISGiQji4a0P9RFCzTaNEk+fqKd+GeHXJGKj+x5PzV2zBdoZa EuFw== X-Gm-Message-State: APjAAAU1UKX3uVUOMqOhgoy7s62J7PV0+IUPDTUeTvibw8biw62Qld3Y /wQ4+GmAKdVjc4ZrXM7qqliGyw== X-Google-Smtp-Source: APXvYqyE4KypheWDTMolsvMJk+gKBAPl1QkcrSeuna1NO+V0ysfH9LpuW1Ya22r7aLQvQAUZoZJ/BQ== X-Received: by 2002:a17:902:42a5:: with SMTP id h34mr110669295pld.16.1561356366447; Sun, 23 Jun 2019 23:06:06 -0700 (PDT) Received: from localhost ([122.172.211.128]) by smtp.gmail.com with ESMTPSA id w4sm10278398pfw.97.2019.06.23.23.06.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 23 Jun 2019 23:06:05 -0700 (PDT) Date: Mon, 24 Jun 2019 11:36:04 +0530 From: Viresh Kumar To: Daniel Lezcano Cc: edubezval@gmail.com, linux-kernel@vger.kernel.org, Zhang Rui , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , "open list:THERMAL" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Subject: Re: [PATCH 5/6] thermal/drivers/imx: Remove cooling device usage Message-ID: <20190624060604.v3docq36c4rmscja@vireshk-i7> References: <20190621132302.30414-1-daniel.lezcano@linaro.org> <20190621132302.30414-5-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190621132302.30414-5-daniel.lezcano@linaro.org> User-Agent: NeoMutt/20180716-391-311a52 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 21-06-19, 15:23, Daniel Lezcano wrote: > The cpufreq_cooling_unregister() function uses now the policy to > unregister itself. The only purpose of the cooling device pointer is > to unregister the cpu cooling device. > > As there is no more need of this pointer, remove it. > > Signed-off-by: Daniel Lezcano > --- > drivers/thermal/imx_thermal.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c > index 6746f1b73eb7..021c0948b740 100644 > --- a/drivers/thermal/imx_thermal.c > +++ b/drivers/thermal/imx_thermal.c > @@ -203,7 +203,6 @@ static struct thermal_soc_data thermal_imx7d_data = { > struct imx_thermal_data { > struct cpufreq_policy *policy; > struct thermal_zone_device *tz; > - struct thermal_cooling_device *cdev; > enum thermal_device_mode mode; > struct regmap *tempmon; > u32 c1, c2; /* See formula in imx_init_calib() */ > @@ -656,6 +655,7 @@ MODULE_DEVICE_TABLE(of, of_imx_thermal_match); > static int imx_thermal_register_legacy_cooling(struct imx_thermal_data *data) > { > struct device_node *np; > + struct thermal_cooling_device *cdev; > int ret; > > data->policy = cpufreq_cpu_get(0); > @@ -667,9 +667,9 @@ static int imx_thermal_register_legacy_cooling(struct imx_thermal_data *data) > np = of_get_cpu_node(data->policy->cpu, NULL); > > if (!np || !of_find_property(np, "#cooling-cells", NULL)) { > - data->cdev = cpufreq_cooling_register(data->policy); > - if (IS_ERR(data->cdev)) { > - ret = PTR_ERR(data->cdev); > + cdev = cpufreq_cooling_register(data->policy); > + if (IS_ERR(cdev)) { > + ret = PTR_ERR(cdev); > cpufreq_cpu_put(data->policy); > return ret; > } This too.. Acked-by: Viresh Kumar -- viresh