From: Rob Herring <robh@kernel.org>
To: "Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>
Cc: sre@kernel.org, lee.jones@linaro.org, mark.rutland@arm.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: mfd: max8998: Add charger subnode binding
Date: Tue, 9 Jul 2019 15:58:10 -0600 [thread overview]
Message-ID: <20190709215810.GB26049@bogus> (raw)
In-Reply-To: <20190621115602.17559-3-pawel.mikolaj.chmiel@gmail.com>
On Fri, Jun 21, 2019 at 01:56:02PM +0200, Paweł Chmiel wrote:
> This patch adds devicetree bindings documentation for
> battery charging controller as the subnode of MAX8998 PMIC.
>
> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> ---
> Changes from v3:
> - Property prefix should be maxim, not max8998
> - Describe what End of Charge in percent means
>
> Changes from v2:
> - Make charge-restart-level-microvolt optional.
> - Make charge-timeout-hours optional.
>
> Changes from v1:
> - Removed unneeded Fixes tag
> - Correct description of all charger values
> - Added missing property unit
> ---
> .../devicetree/bindings/mfd/max8998.txt | 26 +++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/max8998.txt b/Documentation/devicetree/bindings/mfd/max8998.txt
> index 5f2f07c09c90..368f787d6079 100644
> --- a/Documentation/devicetree/bindings/mfd/max8998.txt
> +++ b/Documentation/devicetree/bindings/mfd/max8998.txt
> @@ -48,6 +48,25 @@ Additional properties required if max8998,pmic-buck2-dvs-gpio is defined:
> - max8998,pmic-buck2-dvs-voltage: An array of 2 voltage values in microvolts
> for buck2 regulator that can be selected using dvs gpio.
>
> +Charger: Configuration for battery charging controller should be added
> +inside a child node named 'charger'.
> + Required properties:
> + - maxim,end-of-charge-percentage: End of Charge in percent.
> + When the charge current in constant-voltage phase drops below
> + end-of-charge-percentage of it's start value, charging is terminated.
> + If value equals 0, leave it unchanged. Otherwise it should be value
> + from 10 to 45 by 5 step.
> +
> + Optional properties:
> + - maxim,charge-restart-threshold: Charge restart threshold in millivolts.
> + If property is not present, this will be disabled.
> + Valid values are: 0, 100, 150, 200. If the value equals 0, leave it
> + unchanged.
Needs a unit suffix as defined in property-units.txt.
> +
> + - maxim,charge-timeout: Charge timeout in hours. If property is not
> + present, this will be disabled. Valid values are: 0, 5, 6, 7.
> + If the value equals 0, leave it unchanged.
Needs a unit suffix as defined in property-units.txt.
> +
> Regulators: All the regulators of MAX8998 to be instantiated shall be
> listed in a child node named 'regulators'. Each regulator is represented
> by a child node of the 'regulators' node.
> @@ -97,6 +116,13 @@ Example:
> max8998,pmic-buck2-dvs-gpio = <&gpx0 0 3 0 0>; /* SET3 */
> max8998,pmic-buck2-dvs-voltage = <1350000>, <1300000>;
>
> + /* Charger configuration */
> + charger {
> + maxim,end-of-charge-percentage = <20>;
> + maxim,charge-restart-threshold = <100>;
> + maxim,charge-timeout = <7>;
> + };
> +
> /* Regulators to instantiate */
> regulators {
> ldo2_reg: LDO2 {
> --
> 2.17.1
>
prev parent reply other threads:[~2019-07-09 21:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 11:56 [PATCH v4 0/2] power: supply: max8998-charger: Device Tree support Paweł Chmiel
2019-06-21 11:56 ` [PATCH v4 1/2] power: supply: max8998-charger: Parse device tree for required data Paweł Chmiel
2019-06-21 11:56 ` [PATCH v4 2/2] dt-bindings: mfd: max8998: Add charger subnode binding Paweł Chmiel
2019-06-26 13:06 ` Lee Jones
2019-07-09 21:58 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709215810.GB26049@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.mikolaj.chmiel@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).