From: Quentin Perret <quentin.perret@arm.com>
To: edubezval@gmail.com, rui.zhang@intel.com, javi.merino@kernel.org,
viresh.kumar@linaro.org, amit.kachhap@gmail.com,
rjw@rjwysocki.net, catalin.marinas@arm.com, will@kernel.org,
daniel.lezcano@linaro.org, lkp@intel.com
Cc: dietmar.eggemann@arm.com, ionela.voinescu@arm.com,
mka@chromium.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 3/3] thermal: cpu_cooling: Migrate to using the EM framework
Date: Wed, 7 Aug 2019 16:42:20 +0100 [thread overview]
Message-ID: <20190807154217.a4rxvj4uerptq52r@queper01-lin> (raw)
In-Reply-To: <20190801124643.17112-4-quentin.perret@arm.com>
Hi all,
On Thursday 01 Aug 2019 at 13:46:43 (+0100), Quentin Perret wrote:
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 9966364a6deb..340853a3ca48 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -144,6 +144,7 @@ config THERMAL_GOV_USER_SPACE
>
> config THERMAL_GOV_POWER_ALLOCATOR
> bool "Power allocator thermal governor"
> + depends on ENERGY_MODEL
> help
> Enable this to manage platform thermals by dynamically
> allocating and limiting power to devices.
FYI, the kbuild bot just reported a randconfig build issue with this.
THERMAL_DEFAULT_GOV_POWER_ALLOCATOR 'select' THERMAL_GOV_POWER_ALLOCATOR
unconditionally. And I just learned 'select' will force the option ON
and totally ignore its dependencies. That is, we can end up with IPA
force-compiled in, and no PM_EM, which is broken.
So I guess the simplest fix is to do 'select ENERGY_MODEL' in this
patch, instead of depending on it.
I'll send a v7 with this fixed shortly.
Thanks,
Quentin
next prev parent reply other threads:[~2019-08-07 15:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 12:46 [PATCH v6 0/3] Make IPA use PM_EM Quentin Perret
2019-08-01 12:46 ` [PATCH v6 1/3] arm64: defconfig: Enable CONFIG_ENERGY_MODEL Quentin Perret
2019-08-01 12:46 ` [PATCH v6 2/3] thermal: cpu_cooling: Make the power-related code depend on IPA Quentin Perret
2019-08-01 12:46 ` [PATCH v6 3/3] thermal: cpu_cooling: Migrate to using the EM framework Quentin Perret
2019-08-07 15:42 ` Quentin Perret [this message]
2019-08-01 13:00 ` [PATCH v6 0/3] Make IPA use PM_EM Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807154217.a4rxvj4uerptq52r@queper01-lin \
--to=quentin.perret@arm.com \
--cc=amit.kachhap@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=edubezval@gmail.com \
--cc=ionela.voinescu@arm.com \
--cc=javi.merino@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mka@chromium.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).