* [PATCH v4 3/8] PM/sleep: Replace strncmp with str_has_prefix
@ 2019-08-09 7:10 Chuhong Yuan
2019-08-26 9:19 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2019-08-09 7:10 UTC (permalink / raw)
Cc: Rafael J . Wysocki, Len Brown, Pavel Machek, linux-pm,
linux-kernel, Chuhong Yuan
strncmp(str, const, len) is error-prone because len
is easy to have typo.
The example is the hard-coded len has counting error
or sizeof(const) forgets - 1.
So we prefer using newly introduced str_has_prefix()
to substitute such strncmp to make code better.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
kernel/power/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/power/main.c b/kernel/power/main.c
index bdbd605c4215..5e5f64bb3a43 100644
--- a/kernel/power/main.c
+++ b/kernel/power/main.c
@@ -495,7 +495,7 @@ static suspend_state_t decode_state(const char *buf, size_t n)
len = p ? p - buf : n;
/* Check hibernation first. */
- if (len == 4 && !strncmp(buf, "disk", len))
+ if (len == 4 && str_has_prefix(buf, "disk"))
return PM_SUSPEND_MAX;
#ifdef CONFIG_SUSPEND
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4 3/8] PM/sleep: Replace strncmp with str_has_prefix
2019-08-09 7:10 [PATCH v4 3/8] PM/sleep: Replace strncmp with str_has_prefix Chuhong Yuan
@ 2019-08-26 9:19 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2019-08-26 9:19 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: Len Brown, Pavel Machek, linux-pm, linux-kernel
On Friday, August 9, 2019 9:10:23 AM CEST Chuhong Yuan wrote:
> strncmp(str, const, len) is error-prone because len
> is easy to have typo.
> The example is the hard-coded len has counting error
> or sizeof(const) forgets - 1.
> So we prefer using newly introduced str_has_prefix()
> to substitute such strncmp to make code better.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> kernel/power/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/main.c b/kernel/power/main.c
> index bdbd605c4215..5e5f64bb3a43 100644
> --- a/kernel/power/main.c
> +++ b/kernel/power/main.c
> @@ -495,7 +495,7 @@ static suspend_state_t decode_state(const char *buf, size_t n)
> len = p ? p - buf : n;
>
> /* Check hibernation first. */
> - if (len == 4 && !strncmp(buf, "disk", len))
> + if (len == 4 && str_has_prefix(buf, "disk"))
> return PM_SUSPEND_MAX;
>
> #ifdef CONFIG_SUSPEND
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-26 9:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-09 7:10 [PATCH v4 3/8] PM/sleep: Replace strncmp with str_has_prefix Chuhong Yuan
2019-08-26 9:19 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).