From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F044C31E40 for ; Mon, 12 Aug 2019 23:50:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 087732075B for ; Mon, 12 Aug 2019 23:50:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565653836; bh=+Nz+NtCbaaqfrcm+wym7Q36wwuWOyQMe7nw20hWUlv4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=gt2WeInxr6oAOXmjYCQht7pM9KLRmawcCxxWfPsvBV9TRJYF8epZITVu2R07aqv7o 4ZJPlsLI6EfTCR8UTErht4PreevyxzQJ8pzZVqIX13FJKvSS/IsfOeu/A6+Pcn9rLx /VarVYEkK2BfUSrZb/rupFobPj3BbnsufeYc1wCI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726752AbfHLXuf (ORCPT ); Mon, 12 Aug 2019 19:50:35 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:45814 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726453AbfHLXuf (ORCPT ); Mon, 12 Aug 2019 19:50:35 -0400 Received: by mail-ot1-f65.google.com with SMTP id m24so12762253otp.12; Mon, 12 Aug 2019 16:50:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wu+Yll/a4SFv+CqAeDhttcKl/XjxKpsIr9S2nfoZc4M=; b=lHB30SRIzvFYGAsID4zuLtSUGM2t2/5xKA4ljm7KsygAkJmnE10YQ55Mh3YQfgXxK5 Nc+MO2e5QglZXqC1TsajZoZlVCkh2B6yF/8Zn/7YNmGPBAV/ci9vVC/Wd7tSmF6UqfAb 3Eb3Tv/ug88K5u1X+wfIfOtIMm80/sVonzb1eRnvTmeMaSFJ6vgiBh6S8q/kTFaBMc2X ur89c7MT78FJyDyyWPIo3qVgKTrSWjYkBn7Kw6uklPEpFhmvfn5mG7LXDSv9KKD3WchM /+52RLuvJ/G0AX9hWNbGGlV/5hprQUJnHvgdYieYi4HP230klo5xBD1JKJ9JofXZdB0L DX7g== X-Gm-Message-State: APjAAAXtExRToNvnVD+MlgECm2g31MjiZTAN4AMZMDfKKAgJPwnCOIVu 4rTj9CbjBb1CCCLDb412SA== X-Google-Smtp-Source: APXvYqx5Pv9z7njFaTAOthJEXcWpHg1NmhbYE+TwIbn7UqsGcIDNzFfJG9k3aLDX0IZoXAaHdvDBEg== X-Received: by 2002:a6b:6f06:: with SMTP id k6mr13023011ioc.232.1565653834113; Mon, 12 Aug 2019 16:50:34 -0700 (PDT) Received: from localhost ([64.188.179.254]) by smtp.gmail.com with ESMTPSA id t133sm153140480iof.21.2019.08.12.16.50.33 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 12 Aug 2019 16:50:33 -0700 (PDT) Date: Mon, 12 Aug 2019 17:50:32 -0600 From: Rob Herring To: Evgeny Kolesnikov Cc: Sebastian Reichel , Mark Rutland , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/5] power: reset: Add UART-based MCU poweroff DT bindings Message-ID: <20190812235032.GA8575@bogus> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Jul 22, 2019 at 09:53:01PM +0200, Evgeny Kolesnikov wrote: > This adds device tree bindings of the poweroff driver > for power managing micro controller units that are connected > to a board via the UART interface. > > Signed-off-by: Evgeny Kolesnikov > --- > .../bindings/power/reset/uart-poweroff.txt | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/reset/uart-poweroff.txt > > diff --git a/Documentation/devicetree/bindings/power/reset/uart-poweroff.txt b/Documentation/devicetree/bindings/power/reset/uart-poweroff.txt > new file mode 100644 > index 000000000000..86d036271b51 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/reset/uart-poweroff.txt > @@ -0,0 +1,38 @@ > +* UART-based PM MCU power off driver > + > +Some devices have a microcontroller controlling the main power > +supply. This microcontroller is connected to UART of the SoC. > +Sending a sequence of characters tells the MCU to turn > +the power off. IMO, you should have a node representing the specific microcontroller. Generic binding attempts like this generally don't work well because you need a never ending addition of properties to deal with h/w (and f/w in this case) differences. The properties you already have are evidence of this. Now, if you want a common driver, then that is a separate issue. You can have multiple, specific bindings map to a common driver (or not, it's up to the OS). Rob