From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CDEBC32750 for ; Tue, 13 Aug 2019 07:20:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3175320842 for ; Tue, 13 Aug 2019 07:20:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hEFcVJVz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726282AbfHMHUZ (ORCPT ); Tue, 13 Aug 2019 03:20:25 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:45935 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727299AbfHMHUX (ORCPT ); Tue, 13 Aug 2019 03:20:23 -0400 Received: by mail-wr1-f68.google.com with SMTP id q12so16488777wrj.12 for ; Tue, 13 Aug 2019 00:20:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=jh+u0/5C9sC+jh4TIlKIxaJHuXDdftZDgr4L90RCuIA=; b=hEFcVJVzbO+JRAcIntpp/zkyNlS7/GvdeEjrweS18w0t6brHWY49x4M06TnFdZSwxW GGaQNP7MUgT/naNeXacrDjPlReBWjvfVLRj+jwnfOSnzi0OUNk5l34AoZpS5DnvuLpDl 7cNl0BEt+sVJKtQ+LT++mw33Dm284lEGuMdRBBrFKcyC4hjm0k0kVy/4G26aCy6Fo+oY uRsQzWvgL5XujoH7taBtmR3FwWDy8klSb77UV1u2YiYIN/RaktD6HE0sLCjVhZ3gWcxT 6MHB9kBjCkdbPzg7uohM0ruCkgjKBGkq74L2O7ondbwMC4ypfOyxsU8N6t9D74MVit5m sEVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=jh+u0/5C9sC+jh4TIlKIxaJHuXDdftZDgr4L90RCuIA=; b=JZFGPjWJfIpnApvHCaSzv86+ktSLCpSOR3bbJtCQyEoDi9LebHEi7+FP8UmbvuxVaN EOXcy9YVhRmNGgTFPBOhpUZAp2X4QkUdFMGN0zhozxX6bnVThV1z8cJpSHb30hb61ooZ pd8BZkLHePwR7K47OL5PePPDzEmORk6v1JxgEha1xEhzHbS7WVw6/iHFx6ciqq7LY1YV cPSUra6QILgKA6ukYyO3nfr/y5etC8Fy7CFVb9asyN5c/z2aWrgWMtaL3as9UG9S02ee /bGm+rJjeLIi9yv9GSashtEKTCHbTbIGPS2b1uWXeXd8cdBgLCwvKLPP+aRFFmMAuJcg 7ElA== X-Gm-Message-State: APjAAAUIIQsKYfuf62NJfLQsfgkommDidAXgfnnApHS19xNnpe7ZXt0c /gjTbac0pAMtuir6rxpjjvB9Cw== X-Google-Smtp-Source: APXvYqwQjf7fTO6Udq8hrYKQOuwTwlMrSM8lymQq+3WwhEOVys4N9qu95PdOanYcKCvd51L3ufdJRQ== X-Received: by 2002:adf:fe12:: with SMTP id n18mr38762652wrr.105.1565680821103; Tue, 13 Aug 2019 00:20:21 -0700 (PDT) Received: from dell ([2.27.35.255]) by smtp.gmail.com with ESMTPSA id k1sm14475486wru.49.2019.08.13.00.20.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Aug 2019 00:20:20 -0700 (PDT) Date: Tue, 13 Aug 2019 08:20:18 +0100 From: Lee Jones To: Alexandre Belloni Cc: Frank Wunderlich , Alessandro Zummo , Allison Randal , "David S. Miller" , devicetree@vger.kernel.org, Eddie Huang , Greg Kroah-Hartman , Jonathan Cameron , Kate Stewart , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org, Mark Rutland , Matthias Brugger , Mauro Carvalho Chehab , Nicolas Ferre , Richard Fontana , Rob Herring , Sean Wang , Sebastian Reichel , Thomas Gleixner , "Tianping . Fang" , Josef Friedl Subject: Re: [PATCH v5 03/10] rtc: mt6397: move some common definitions into rtc.h Message-ID: <20190813072018.GZ26727@dell> References: <20190812121511.4169-1-frank-w@public-files.de> <20190812121511.4169-4-frank-w@public-files.de> <20190812151128.GV26727@dell> <20190812153856.GR3600@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190812153856.GR3600@piout.net> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, 12 Aug 2019, Alexandre Belloni wrote: > On 12/08/2019 16:11:29+0100, Lee Jones wrote: > > On Mon, 12 Aug 2019, Frank Wunderlich wrote: > > > > > From: Josef Friedl > > > > > > move code to separate header-file to reuse definitions later > > > in poweroff-driver (drivers/power/reset/mt6323-poweroff.c) > > > > > > Suggested-by: Frank Wunderlich > > > Signed-off-by: Josef Friedl > > > Signed-off-by: Frank Wunderlich > > > --- > > > changes since v4: none > > > changes since v3: none > > > changes since v2: add missing commit-message > > > --- > > > drivers/rtc/rtc-mt6397.c | 55 +------------------------- > > > include/linux/mfd/mt6397/rtc.h | 71 ++++++++++++++++++++++++++++++++++ > > > > include/linux/rtc/mt6397.h? > > > > It's just a bunch of registers and bit definitions so it may as well > stay close to include/linux/mfd/mt6397/registers.h Sure. It was a weak preference. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog