From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-pm@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH 3/3] clk: renesas: cpg-mssr: Set GENPD_FLAG_ALWAYS_ON for clock domain
Date: Fri, 16 Aug 2019 14:52:25 +0200 [thread overview]
Message-ID: <20190816125225.16061-4-geert+renesas@glider.be> (raw)
In-Reply-To: <20190816125225.16061-1-geert+renesas@glider.be>
The CPG/MSSR Clock Domain driver does not implement the
generic_pm_domain.power_{on,off}() callbacks, as the domain itself
cannot be powered down. Hence the domain should be marked as always-on
by setting the GENPD_FLAG_ALWAYS_ON flag.
Note that this only affects RZ/A2 SoCs. On R-Car Gen2 and Gen3 SoCs,
the R-Car SYSC driver handles Clock Domain creation, and offloads only
device attachment/detachment to the CPG/MSSR driver.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/clk/renesas/renesas-cpg-mssr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
index d4075b13067429cd..132cc96895e3a978 100644
--- a/drivers/clk/renesas/renesas-cpg-mssr.c
+++ b/drivers/clk/renesas/renesas-cpg-mssr.c
@@ -551,7 +551,8 @@ static int __init cpg_mssr_add_clk_domain(struct device *dev,
genpd = &pd->genpd;
genpd->name = np->name;
- genpd->flags = GENPD_FLAG_PM_CLK | GENPD_FLAG_ACTIVE_WAKEUP;
+ genpd->flags = GENPD_FLAG_PM_CLK | GENPD_FLAG_ALWAYS_ON |
+ GENPD_FLAG_ACTIVE_WAKEUP;
genpd->attach_dev = cpg_mssr_attach_dev;
genpd->detach_dev = cpg_mssr_detach_dev;
pm_genpd_init(genpd, &pm_domain_always_on_gov, false);
--
2.17.1
next prev parent reply other threads:[~2019-08-16 12:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 12:52 [PATCH 0/3] clk: renesas: Set GENPD_FLAG_ALWAYS_ON for clock domain Geert Uytterhoeven
2019-08-16 12:52 ` [PATCH 1/3] clk: renesas: mstp: " Geert Uytterhoeven
2019-08-16 15:38 ` Simon Horman
2019-08-16 18:01 ` Stephen Boyd
2019-08-16 19:59 ` Geert Uytterhoeven
2019-08-17 3:48 ` Stephen Boyd
2019-08-18 8:27 ` Geert Uytterhoeven
2019-08-22 14:06 ` Ulf Hansson
2019-08-23 8:59 ` Geert Uytterhoeven
2019-08-16 12:52 ` [PATCH 2/3] clk: renesas: r9a06g032: " Geert Uytterhoeven
2019-08-16 15:39 ` Simon Horman
2019-08-16 12:52 ` Geert Uytterhoeven [this message]
2019-08-16 15:39 ` [PATCH 3/3] clk: renesas: cpg-mssr: " Simon Horman
2019-08-22 14:08 ` [PATCH 0/3] clk: renesas: " Ulf Hansson
2019-08-23 9:08 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816125225.16061-4-geert+renesas@glider.be \
--to=geert+renesas@glider.be \
--cc=khilman@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).