From: Stephen Boyd <sboyd@kernel.org>
To: Mao Wenan <maowenan@huawei.com>,
agross@kernel.org, georgi.djakov@linaro.org,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Mao Wenan <maowenan@huawei.com>
Subject: Re: [PATCH linux-next] qcom: qcs404: remove COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404
Date: Sat, 17 Aug 2019 18:09:04 -0700 [thread overview]
Message-ID: <20190818010905.7AD602173B@mail.kernel.org> (raw)
In-Reply-To: <20190815074848.195806-1-maowenan@huawei.com>
Quoting Mao Wenan (2019-08-15 00:48:48)
> There is one compilation error when CONFIG_INTERCONNECT_QCOM_QCS404=y and
> CONFIG_INTERCONNECT_QCOM_SMD_RPM=y, as well as CONFIG_COMPILE_TEST=y,
> but CONFIG_QCOM_SMD_RPM is not set, logs as below:
>
> drivers/interconnect/qcom/smd-rpm.o: In function `qcom_icc_rpm_smd_send':
> smd-rpm.c:(.text+0xe4): undefined reference to `qcom_rpm_smd_write'
> Makefile:1071: recipe for target 'vmlinux' failed
> make: *** [vmlinux] Error 1
>
> This is because
> INTERCONNECT_QCOM_QCS404 depends on QCOM_SMD_RPM || COMPILE_TEST.
> Here CONFIG_COMPILE_TEST=y, so CONFIG_INTERCONNECT_QCOM_SMD_RPM
> is selected. If CONFIG_QCOM_SMD_RPM is not set, then
> qcom_rpm_smd_write() is not defined, and compilation error happen.
> Fix this by removing COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404.
Can you fix the actual problem with compile testing this driver vs. just
removing the possibility to compile test. Otherwise it gives up on
the spirit of the idea of COMPILE_TEST.
next prev parent reply other threads:[~2019-08-18 1:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 7:48 [PATCH linux-next] qcom: qcs404: remove COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404 Mao Wenan
2019-08-18 1:09 ` Stephen Boyd [this message]
2019-08-19 1:31 ` maowenan
2019-08-19 3:37 ` [PATCH v2 linux-next] qcom: qcs404: move COMPILE_TEST to INTERCONNECT_QCOM Mao Wenan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190818010905.7AD602173B@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=georgi.djakov@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=maowenan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).