From: Stephen Boyd <sboyd@kernel.org>
To: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"festevam@gmail.com" <festevam@gmail.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
Abel Vesa <abel.vesa@nxp.com>, Anson Huang <anson.huang@nxp.com>,
Leonard Crestez <leonard.crestez@nxp.com>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 5/6] clk: imx8mn: Add necessary frequency support for ARM PLL table
Date: Sat, 17 Aug 2019 18:11:33 -0700 [thread overview]
Message-ID: <20190818011133.CE6F52173B@mail.kernel.org> (raw)
In-Reply-To: <DB3PR0402MB3916D320EB51B2D9E28D55E1F5AE0@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Quoting Anson Huang (2019-08-17 15:22:01)
> Hi, Stephen
>
> > Quoting Anson.Huang@nxp.com (2019-08-15 03:59:42)
> > > diff --git a/drivers/clk/imx/clk-imx8mn.c
> > > b/drivers/clk/imx/clk-imx8mn.c index ecd1062..3f1239a 100644
> > > --- a/drivers/clk/imx/clk-imx8mn.c
> > > +++ b/drivers/clk/imx/clk-imx8mn.c
> > > @@ -82,6 +84,7 @@ static struct imx_pll14xx_clk imx8mn_dram_pll = {
> > > static struct imx_pll14xx_clk imx8mn_arm_pll = {
> > > .type = PLL_1416X,
> > > .rate_table = imx8mn_pll1416x_tbl,
> > > + .rate_count = ARRAY_SIZE(imx8mn_pll1416x_tbl),
> >
> > Why is rate_count added? That's not described in the commit text.
>
> rate_count is necessary for table search during set_rate, it was missed previously,
> I will add it into commit text in V2.
>
Right, isn't that a more critical fix to make by itself instead of
rolling into this change that adds a few more frequencies?
next prev parent reply other threads:[~2019-08-18 1:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 10:59 [PATCH 1/6] arm64: dts: imx8mn-ddr4-evk: Add i2c1 support Anson.Huang
2019-08-15 10:59 ` [PATCH 2/6] arm64: dts: imx8mn-ddr4-evk: Add rohm,bd71847 PMIC support Anson.Huang
2019-08-15 10:59 ` [PATCH 3/6] cpufreq: Use imx-cpufreq-dt for i.MX8MN's speed grading Anson.Huang
2019-08-15 10:59 ` [PATCH 4/6] cpufreq: imx-cpufreq-dt: Add i.MX8MN support Anson.Huang
2019-08-15 10:59 ` [PATCH 5/6] clk: imx8mn: Add necessary frequency support for ARM PLL table Anson.Huang
2019-08-17 3:52 ` Stephen Boyd
2019-08-17 22:22 ` Anson Huang
2019-08-18 1:11 ` Stephen Boyd [this message]
2019-08-18 6:19 ` Anson Huang
2019-08-15 10:59 ` [PATCH 6/6] arm64: dts: imx8mn: Add cpu-freq support Anson.Huang
2019-08-15 14:12 ` [PATCH 1/6] arm64: dts: imx8mn-ddr4-evk: Add i2c1 support Leonard Crestez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190818011133.CE6F52173B@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=abel.vesa@nxp.com \
--cc=anson.huang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).