linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	bjorn.andersson@linaro.org, edubezval@gmail.com,
	agross@kernel.org, sboyd@kernel.org, masneyb@onstation.org,
	marc.w.gonzalez@free.fr,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 03/15] drivers: thermal: tsens: Add __func__ identifier to debug statements
Date: Thu, 29 Aug 2019 15:04:59 +0100	[thread overview]
Message-ID: <20190829140459.szauzhennltrwvg4@holly.lan> (raw)
In-Reply-To: <93fa782bde9c66845993ff883532b3f1f02d99e4.1566907161.git.amit.kucheria@linaro.org>

On Tue, Aug 27, 2019 at 05:43:59PM +0530, Amit Kucheria wrote:
> Printing the function name when enabling debugging makes logs easier to
> read.
> 
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>

This should need to be manually added at each call site; it is already
built into the logging system (the f flag for dynamic debug)?


Daniel.

> ---
>  drivers/thermal/qcom/tsens-common.c | 8 ++++----
>  drivers/thermal/qcom/tsens.c        | 6 +++---
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
> index c037bdf92c663..7437bfe196e50 100644
> --- a/drivers/thermal/qcom/tsens-common.c
> +++ b/drivers/thermal/qcom/tsens-common.c
> @@ -42,8 +42,8 @@ void compute_intercept_slope(struct tsens_priv *priv, u32 *p1,
>  
>  	for (i = 0; i < priv->num_sensors; i++) {
>  		dev_dbg(priv->dev,
> -			"sensor%d - data_point1:%#x data_point2:%#x\n",
> -			i, p1[i], p2[i]);
> +			"%s: sensor%d - data_point1:%#x data_point2:%#x\n",
> +			__func__, i, p1[i], p2[i]);
>  
>  		priv->sensor[i].slope = SLOPE_DEFAULT;
>  		if (mode == TWO_PT_CALIB) {
> @@ -60,7 +60,7 @@ void compute_intercept_slope(struct tsens_priv *priv, u32 *p1,
>  		priv->sensor[i].offset = (p1[i] * SLOPE_FACTOR) -
>  				(CAL_DEGC_PT1 *
>  				priv->sensor[i].slope);
> -		dev_dbg(priv->dev, "offset:%d\n", priv->sensor[i].offset);
> +		dev_dbg(priv->dev, "%s: offset:%d\n", __func__, priv->sensor[i].offset);
>  	}
>  }
>  
> @@ -209,7 +209,7 @@ int __init init_common(struct tsens_priv *priv)
>  	if (ret)
>  		goto err_put_device;
>  	if (!enabled) {
> -		dev_err(dev, "tsens device is not enabled\n");
> +		dev_err(dev, "%s: device not enabled\n", __func__);
>  		ret = -ENODEV;
>  		goto err_put_device;
>  	}
> diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
> index 542a7f8c3d962..06c6bbd69a1a7 100644
> --- a/drivers/thermal/qcom/tsens.c
> +++ b/drivers/thermal/qcom/tsens.c
> @@ -127,7 +127,7 @@ static int tsens_probe(struct platform_device *pdev)
>  		of_property_read_u32(np, "#qcom,sensors", &num_sensors);
>  
>  	if (num_sensors <= 0) {
> -		dev_err(dev, "invalid number of sensors\n");
> +		dev_err(dev, "%s: invalid number of sensors\n", __func__);
>  		return -EINVAL;
>  	}
>  
> @@ -156,7 +156,7 @@ static int tsens_probe(struct platform_device *pdev)
>  
>  	ret = priv->ops->init(priv);
>  	if (ret < 0) {
> -		dev_err(dev, "tsens init failed\n");
> +		dev_err(dev, "%s: init failed\n", __func__);
>  		return ret;
>  	}
>  
> @@ -164,7 +164,7 @@ static int tsens_probe(struct platform_device *pdev)
>  		ret = priv->ops->calibrate(priv);
>  		if (ret < 0) {
>  			if (ret != -EPROBE_DEFER)
> -				dev_err(dev, "tsens calibration failed\n");
> +				dev_err(dev, "%s: calibration failed\n", __func__);
>  			return ret;
>  		}
>  	}
> -- 
> 2.17.1
> 

  reply	other threads:[~2019-08-29 14:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27 12:13 [PATCH v2 00/15] thermal: qcom: tsens: Add interrupt support Amit Kucheria
2019-08-27 12:13 ` [PATCH v2 01/15] drivers: thermal: tsens: Get rid of id field in tsens_sensor Amit Kucheria
2019-08-27 12:13 ` [PATCH v2 02/15] drivers: thermal: tsens: Simplify code flow in tsens_probe Amit Kucheria
2019-08-27 12:13 ` [PATCH v2 03/15] drivers: thermal: tsens: Add __func__ identifier to debug statements Amit Kucheria
2019-08-29 14:04   ` Daniel Thompson [this message]
2019-08-29 14:28     ` Amit Kucheria
2019-08-29 15:19       ` Daniel Thompson
2019-08-29 16:14         ` Amit Kucheria
2019-08-29 16:34           ` Daniel Thompson
2019-08-27 12:14 ` [PATCH v2 04/15] drivers: thermal: tsens: Add debugfs support Amit Kucheria
2019-08-28  0:31   ` Stephen Boyd
2019-08-27 12:14 ` [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver Amit Kucheria
2019-08-28  0:33   ` Stephen Boyd
2019-08-29  8:48     ` Amit Kucheria
2019-08-29 14:53       ` Stephen Boyd
2019-08-29 16:34         ` Amit Kucheria
2019-08-30 11:32           ` Amit Kucheria
2019-08-30 15:55             ` Stephen Boyd
2019-08-30 16:40               ` Amit Kucheria
2019-08-27 12:14 ` [PATCH v2 14/15] drivers: thermal: tsens: Create function to return sign-extended temperature Amit Kucheria
2019-08-28  0:38   ` Stephen Boyd
     [not found]     ` <CAP245DVGY6+vue_REqy=Tbvka2fcBx6XhSBePW4L3=pNagX=Dw@mail.gmail.com>
2019-08-28 15:44       ` Stephen Boyd
2019-08-27 12:14 ` [PATCH v2 15/15] drivers: thermal: tsens: Add interrupt support Amit Kucheria
2019-08-28 21:42   ` Stephen Boyd
2019-08-29 12:30     ` Amit Kucheria
2019-08-29 14:54       ` Stephen Boyd
2019-08-29  3:53   ` Thara Gopinath
2019-09-10 16:01     ` Amit Kucheria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190829140459.szauzhennltrwvg4@holly.lan \
    --to=daniel.thompson@linaro.org \
    --cc=agross@kernel.org \
    --cc=amit.kucheria@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=marc.w.gonzalez@free.fr \
    --cc=mark.rutland@arm.com \
    --cc=masneyb@onstation.org \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).