Linux-PM Archive on lore.kernel.org
 help / color / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Chen-Yu Tsai <wens@csie.org>, linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/2] power: supply: axp288_fuel_gauge: Sort the DMI blacklist alphabetically
Date: Sun, 1 Sep 2019 22:13:15 +0200
Message-ID: <20190901201315.nsusbkggjusa3sjt@earth.universe> (raw)
In-Reply-To: <20190825154152.80087-1-hdegoede@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1690 bytes --]

Hi,

On Sun, Aug 25, 2019 at 05:41:51PM +0200, Hans de Goede wrote:
> The blacklist is getting big enough that it is good to have some sort
> of fixed order for it, sort it alphabetically.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/axp288_fuel_gauge.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
> index 44169dabb705..6db2e86098e9 100644
> --- a/drivers/power/supply/axp288_fuel_gauge.c
> +++ b/drivers/power/supply/axp288_fuel_gauge.c
> @@ -674,6 +674,7 @@ static void fuel_gauge_init_irq(struct axp288_fg_info *info)
>  /*
>   * Some devices have no battery (HDMI sticks) and the axp288 battery's
>   * detection reports one despite it not being there.
> + * Please keep this listed sorted alphabetically.
>   */
>  static const struct dmi_system_id axp288_fuel_gauge_blacklist[] = {
>  	{
> @@ -696,6 +697,12 @@ static const struct dmi_system_id axp288_fuel_gauge_blacklist[] = {
>  			DMI_EXACT_MATCH(DMI_BIOS_VERSION, "1.000"),
>  		},
>  	},
> +	{
> +		/* ECS EF20EA */
> +		.matches = {
> +			DMI_MATCH(DMI_PRODUCT_NAME, "EF20EA"),
> +		},
> +	},
>  	{
>  		/* Intel Cherry Trail Compute Stick, Windows version */
>  		.matches = {
> @@ -719,12 +726,6 @@ static const struct dmi_system_id axp288_fuel_gauge_blacklist[] = {
>  			DMI_MATCH(DMI_BOARD_VERSION, "V1.1"),
>  		},
>  	},
> -	{
> -		/* ECS EF20EA */
> -		.matches = {
> -			DMI_MATCH(DMI_PRODUCT_NAME, "EF20EA"),
> -		},
> -	},
>  	{}
>  };
>  
> -- 
> 2.23.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-25 15:41 Hans de Goede
2019-08-25 15:41 ` [PATCH 2/2] power: supply: axp288_fuel_gauge: Add Minix Neo Z83-4 to the blacklist Hans de Goede
2019-09-01 20:13   ` Sebastian Reichel
2019-09-01 20:13 ` Sebastian Reichel [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190901201315.nsusbkggjusa3sjt@earth.universe \
    --to=sre@kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pm/0 linux-pm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pm linux-pm/ https://lore.kernel.org/linux-pm \
		linux-pm@vger.kernel.org linux-pm@archiver.kernel.org
	public-inbox-index linux-pm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pm


AGPL code for this site: git clone https://public-inbox.org/ public-inbox