From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lukasz Luba <l.luba@partner.samsung.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-clk@vger.kernel.org, mturquette@baylibre.com,
sboyd@kernel.org, b.zolnierkie@samsung.com, kgene@kernel.org,
mark.rutland@arm.com, robh+dt@kernel.org, cw00.choi@samsung.com,
kyungmin.park@samsung.com, m.szyprowski@samsung.com,
s.nawrocki@samsung.com, myungjoo.ham@samsung.com,
keescook@chromium.org, tony@atomide.com, jroedel@suse.de,
treding@nvidia.com, digetx@gmail.com, gregkh@linuxfoundation.org,
willy.mh.wolff.ml@gmail.com
Subject: Re: [PATCH v13 5/8] drivers: memory: add DMC driver for Exynos5422
Date: Wed, 4 Sep 2019 20:35:10 +0200 [thread overview]
Message-ID: <20190904183510.GC12918@kozik-lap> (raw)
In-Reply-To: <20190821104303.32079-6-l.luba@partner.samsung.com>
On Wed, Aug 21, 2019 at 12:43:00PM +0200, Lukasz Luba wrote:
> This patch adds driver for Exynos5422 Dynamic Memory Controller.
> The driver provides support for dynamic frequency and voltage scaling
> for DMC and DRAM. It supports changing timings of DRAM running with
> different frequency. There is also an algorithm to calculate timigns
> based on memory description provided in DT.
> The patch also contains needed MAINTAINERS file update.
>
> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
> ---
> MAINTAINERS | 8 +
> drivers/memory/samsung/Kconfig | 13 +
> drivers/memory/samsung/Makefile | 1 +
> drivers/memory/samsung/exynos5422-dmc.c | 1257 +++++++++++++++++++++++
> 4 files changed, 1279 insertions(+)
> create mode 100644 drivers/memory/samsung/exynos5422-dmc.c
Thanks, applied... or almost. Let's fix it incrementally.
You have two smatch warnings:
CHECK ../drivers/memory/samsung/exynos5422-dmc.c
drivers/memory/samsung/exynos5422-dmc.c:272 exynos5_init_freq_table() warn: passing devm_ allocated variable to kfree. 'dmc->opp'
CHECK ../drivers/memory/jedec_ddr_data.c
drivers/memory/samsung/exynos5422-dmc.c:565 exynos5_dmc_get_volt_freq() warn: passing zero to 'PTR_ERR'
The second looks like false positive, but first seems to be real.
You have also sparse warning to fix:
../drivers/memory/samsung/exynos5422-dmc.c:736:1: warning: symbol 'exynos5_dmc_align_init_freq' was not declared. Should it be static?
Best regards,
Krzysztof
next prev parent reply other threads:[~2019-09-04 18:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190821104316eucas1p2ecd715f3105921ec83e0acf1291201f8@eucas1p2.samsung.com>
2019-08-21 10:42 ` [PATCH v13 0/8] Exynos5 Dynamic Memory Controller driver Lukasz Luba
[not found] ` <CGME20190821104318eucas1p1065a4a9d8366095e4d758519f88e8aba@eucas1p1.samsung.com>
2019-08-21 10:42 ` [PATCH v13 1/8] dt-bindings: ddr: rename lpddr2 directory Lukasz Luba
[not found] ` <CGME20190821104319eucas1p10db51f7a181cae024465cc775292d2b1@eucas1p1.samsung.com>
2019-08-21 10:42 ` [PATCH v13 2/8] dt-bindings: ddr: add LPDDR3 memories Lukasz Luba
[not found] ` <CGME20190821104320eucas1p10c911c2ce59007bcf6c039f52b869656@eucas1p1.samsung.com>
2019-08-21 10:42 ` [PATCH v13 3/8] drivers: memory: extend of_memory by LPDDR3 support Lukasz Luba
2019-09-04 18:31 ` Krzysztof Kozlowski
2019-09-06 8:42 ` Lukasz Luba
[not found] ` <CGME20190821104321eucas1p284816ade1890e9660008c0428c6d56e0@eucas1p2.samsung.com>
2019-08-21 10:42 ` [PATCH v13 4/8] dt-bindings: memory-controllers: add Exynos5422 DMC device description Lukasz Luba
[not found] ` <CGME20190821104323eucas1p1ab979133de45373866e9db1a5f63fb76@eucas1p1.samsung.com>
2019-08-21 10:43 ` [PATCH v13 5/8] drivers: memory: add DMC driver for Exynos5422 Lukasz Luba
2019-09-04 18:35 ` Krzysztof Kozlowski [this message]
2019-09-06 8:44 ` Lukasz Luba
[not found] ` <CGME20190821104323eucas1p2e0956d08d3d6c3934760ea76c2de0d57@eucas1p2.samsung.com>
2019-08-21 10:43 ` [PATCH v13 6/8] ARM: dts: exynos: add syscon to clock compatible Lukasz Luba
[not found] ` <CGME20190821104324eucas1p16bdeb27250c8c9fa87591d6bd9743a17@eucas1p1.samsung.com>
2019-08-21 10:43 ` [PATCH v13 7/8] ARM: dts: exynos: add DMC device for exynos5422 Lukasz Luba
2019-09-04 18:25 ` Krzysztof Kozlowski
2019-09-06 8:41 ` Lukasz Luba
[not found] ` <CGME20190821104326eucas1p1f22b49095a17f0b303910c391ff1e906@eucas1p1.samsung.com>
2019-08-21 10:43 ` [PATCH v13 8/8] ARM: exynos_defconfig: enable DMC driver Lukasz Luba
2019-10-02 17:19 ` Krzysztof Kozlowski
2019-09-04 10:16 ` [PATCH v13 0/8] Exynos5 Dynamic Memory Controller driver Krzysztof Kozlowski
2019-09-04 14:59 ` Lukasz Luba
2019-09-04 18:40 ` Krzysztof Kozlowski
2019-09-06 8:47 ` Lukasz Luba
2019-10-01 19:29 ` Krzysztof Kozlowski
2019-10-02 6:01 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904183510.GC12918@kozik-lap \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jroedel@suse.de \
--cc=keescook@chromium.org \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=l.luba@partner.samsung.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
--cc=treding@nvidia.com \
--cc=willy.mh.wolff.ml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).