From: Tony Lindgren <tony@atomide.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Viresh Kumar" <viresh.kumar@linaro.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Adam Ford" <aford173@gmail.com>,
"André Roth" <neolynx@gmail.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux-OMAP <linux-omap@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-pm@vger.kernel.org,
"Discussions about the Letux Kernel"
<letux-kernel@openphoenux.org>,
kernel@pyra-handheld.com
Subject: Re: [RFC v2 3/3] ARM: dts: omap3: bulk convert compatible to be explicitly ti,omap3430 or ti,omap36xx
Date: Fri, 6 Sep 2019 10:24:03 -0700 [thread overview]
Message-ID: <20190906172403.GG52127@atomide.com> (raw)
In-Reply-To: <8C8644AC-FA12-4D26-B96A-76B78798612A@goldelico.com>
* H. Nikolaus Schaller <hns@goldelico.com> [190906 17:09]:
> for i in 3430 34xx 3630 36xx; do echo $i $(fgrep '"'ti,omap$i'"' arch/arm/boot/dts/*.dts* | wc -l); done
>
> 3430 12
> 34xx 28
> 3630 3
> 36xx 23
>
> which would indicate that 34xx and 36xx are more common.
Right, but the xx variants are against the device tree naming and
that's why we should get rid of them in the dts. The compatible
should be named after the first instance like "ti,omap3430" and
similar devices can just use that.
> BTW there is also some code that does special SoC detection based on
> soc_device_match(), mainly in omapdrm/dss.
>
> If we were to use this mechanism in the ti-cpufreq driver we could
> match it to ti,omap3 and could avoid all these changes.
>
> But make it less maintainable and code more complex.
Hmm right, yeah using soc_device_match() would remove this issue.
It might be worth doing as these SoC variants do not change
much and the code should not need updating. Up to you to
decide.
> I'll also take a look at omap.txt bindings since that likely needs
> an update as well to better describe what the official ones are
> and which are legacy.
OK. Just limit the compatible changes to the ones that
need to be modified for this series, the rest can be
done with a separate patches.
Regards,
Tony
next prev parent reply other threads:[~2019-09-06 17:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 8:53 [RFC v2 0/3] OMAP3: convert opp-v1 to opp-v2 and read speed binned / 720MHz grade bits H. Nikolaus Schaller
2019-09-04 8:53 ` [RFC v2 1/3] cpufreq: ti-cpufreq: add support for omap34xx and omap36xx H. Nikolaus Schaller
2019-09-05 14:32 ` Tony Lindgren
2019-09-06 3:01 ` Viresh Kumar
2019-09-06 20:46 ` H. Nikolaus Schaller
2019-09-07 6:34 ` H. Nikolaus Schaller
2019-09-07 7:19 ` [Letux-kernel] " Andreas Kemnade
2019-09-06 3:04 ` Viresh Kumar
2019-09-06 15:49 ` Tony Lindgren
2019-09-04 8:53 ` [RFC v2 2/3] ARM: dts: replace opp-v1 tables by opp-v2 " H. Nikolaus Schaller
2019-09-04 8:53 ` [RFC v2 3/3] ARM: dts: omap3: bulk convert compatible to be explicitly ti,omap3430 or ti,omap36xx H. Nikolaus Schaller
2019-09-05 14:27 ` Tony Lindgren
2019-09-06 7:53 ` H. Nikolaus Schaller
2019-09-06 15:47 ` Tony Lindgren
2019-09-06 17:08 ` H. Nikolaus Schaller
2019-09-06 17:15 ` H. Nikolaus Schaller
2019-09-06 17:24 ` Tony Lindgren [this message]
2019-09-06 17:50 ` H. Nikolaus Schaller
2019-09-06 17:55 ` H. Nikolaus Schaller
2019-09-05 5:03 ` [RFC v2 0/3] OMAP3: convert opp-v1 to opp-v2 and read speed binned / 720MHz grade bits Viresh Kumar
2019-09-05 14:33 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906172403.GG52127@atomide.com \
--to=tony@atomide.com \
--cc=aford173@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=neolynx@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).