From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rafael@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH 3/3] powercap/drivers/idle_inject: Specify the idle state to inject
Date: Wed, 18 Sep 2019 13:35:54 -0600 [thread overview]
Message-ID: <20190918193554.GC24433@xps15> (raw)
In-Reply-To: <20190909145015.26317-3-daniel.lezcano@linaro.org>
On Mon, Sep 09, 2019 at 04:50:15PM +0200, Daniel Lezcano wrote:
> Currently the idle injection framework only allows to inject the
> deepest idle state available on the system.
>
> Give the opportunity to specify which idle state we want to inject by
> adding a new function helper to set the state and use it when calling
> play_idle().
>
> There is no functional changes, the cpuidle state is the deepest one.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> drivers/powercap/idle_inject.c | 15 ++++++++++++++-
> include/linux/idle_inject.h | 3 +++
> 2 files changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/powercap/idle_inject.c b/drivers/powercap/idle_inject.c
> index 9b18667b9f26..a612c425d74c 100644
> --- a/drivers/powercap/idle_inject.c
> +++ b/drivers/powercap/idle_inject.c
> @@ -38,6 +38,7 @@
> #define pr_fmt(fmt) "ii_dev: " fmt
>
> #include <linux/cpu.h>
> +#include <linux/cpuidle.h>
> #include <linux/hrtimer.h>
> #include <linux/kthread.h>
> #include <linux/sched.h>
> @@ -65,6 +66,7 @@ struct idle_inject_thread {
> */
> struct idle_inject_device {
> struct hrtimer timer;
> + int state;
> unsigned int idle_duration_us;
> unsigned int run_duration_us;
> unsigned long int cpumask[0];
> @@ -139,7 +141,7 @@ static void idle_inject_fn(unsigned int cpu)
> iit->should_run = 0;
>
> play_idle(READ_ONCE(ii_dev->idle_duration_us),
> - cpuidle_find_deepest_state());
> + READ_ONCE(ii_dev->state));
> }
>
> /**
> @@ -170,6 +172,16 @@ void idle_inject_get_duration(struct idle_inject_device *ii_dev,
> *idle_duration_us = READ_ONCE(ii_dev->idle_duration_us);
> }
>
> +/**
> + * idle_inject_set_state - set the idle state to inject
> + * @state: an integer for the idle state to inject
> + */
> +void idle_inject_set_state(struct idle_inject_device *ii_dev, int state)
> +{
> + if (state >= CPUIDLE_STATE_NOUSE && state < CPUIDLE_STATE_MAX)
> + WRITE_ONCE(ii_dev->state, state);
> +}
> +
> /**
> * idle_inject_start - start idle injections
> * @ii_dev: idle injection control device structure
> @@ -298,6 +310,7 @@ struct idle_inject_device *idle_inject_register(struct cpumask *cpumask)
> cpumask_copy(to_cpumask(ii_dev->cpumask), cpumask);
> hrtimer_init(&ii_dev->timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
> ii_dev->timer.function = idle_inject_timer_fn;
> + ii_dev->state = cpuidle_find_deepest_state();
>
> for_each_cpu(cpu, to_cpumask(ii_dev->cpumask)) {
>
> diff --git a/include/linux/idle_inject.h b/include/linux/idle_inject.h
> index a445cd1a36c5..e2b26b9ccd34 100644
> --- a/include/linux/idle_inject.h
> +++ b/include/linux/idle_inject.h
> @@ -26,4 +26,7 @@ void idle_inject_set_duration(struct idle_inject_device *ii_dev,
> void idle_inject_get_duration(struct idle_inject_device *ii_dev,
> unsigned int *run_duration_us,
> unsigned int *idle_duration_us);
> +
> +void idle_inject_set_state(struct idle_inject_device *ii_dev, int state);
> +
The above function is not used in this patch and as such should be introduce as
part of future work. Otherwise I agree that this patch does not carry any
functional changes.
Without function idle_inject_set_state():
Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> #endif /* __IDLE_INJECT_H__ */
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-09-18 19:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 14:50 [PATCH 1/3] cpuidle: play_idle: Make play_idle more flexible Daniel Lezcano
2019-09-09 14:50 ` [PATCH 2/3] cpuidle: play_idle: Specify play_idle with an idle state Daniel Lezcano
2019-09-18 19:31 ` Mathieu Poirier
2019-09-09 14:50 ` [PATCH 3/3] powercap/drivers/idle_inject: Specify the idle state to inject Daniel Lezcano
2019-09-18 19:35 ` Mathieu Poirier [this message]
2019-09-24 13:02 ` Daniel Lezcano
2019-09-27 18:02 ` Mathieu Poirier
2019-09-18 19:30 ` [PATCH 1/3] cpuidle: play_idle: Make play_idle more flexible Mathieu Poirier
-- strict thread matches above, loose matches on Subject: below --
2019-08-05 17:02 Daniel Lezcano
2019-08-05 17:02 ` [PATCH 3/3] powercap/drivers/idle_inject: Specify the idle state to inject Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918193554.GC24433@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).