From: Matthias Kaehlcke <mka@chromium.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@redhat.com>,
Douglas Anderson <dianders@chromium.org>,
linux-pm@vger.kernel.org,
Amit Kucheria <amit.kucheria@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] PM / Domains: Add tracepoints
Date: Tue, 1 Oct 2019 09:35:42 -0700 [thread overview]
Message-ID: <20191001163542.GB87296@google.com> (raw)
In-Reply-To: <20190927044239.589e7c4c@oasis.local.home>
On Fri, Sep 27, 2019 at 04:42:39AM -0400, Steven Rostedt wrote:
> On Thu, 26 Sep 2019 15:04:38 -0700
> Matthias Kaehlcke <mka@chromium.org> wrote:
>
> > Define genpd_power_on/off and genpd_set_performance_state
> > tracepoints and use them.
>
> I agree with Greg about adding a "why" you need this. But, in case
> there's a good reason to have this, I have comments about the code
> below.
Thanks Greg and Steven for your comments.
How about this instead:
Add tracepoints for genpd_power_on, genpd_power_off and
genpd_set_performance_state. The tracepoints can help with
understanding power domain behavior of a given device, which
may be particularly interesting for battery powered devices
and suspend/resume.
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> >
> > drivers/base/power/domain.c | 27 +++++++++++++++++---
> > include/trace/events/power.h | 49 ++++++++++++++++++++++++++++++++++++
> > 2 files changed, 72 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> > index cc85e87eaf05..aee988c112e5 100644
> > --- a/drivers/base/power/domain.c
> > +++ b/drivers/base/power/domain.c
> > @@ -21,6 +21,7 @@
> > #include <linux/suspend.h>
> > #include <linux/export.h>
> > #include <linux/cpu.h>
> > +#include <trace/events/power.h>
> >
> > #include "power.h"
> >
> > @@ -329,6 +330,9 @@ static int _genpd_set_performance_state(struct generic_pm_domain *genpd,
> > goto err;
> >
> > genpd->performance_state = state;
> > +
> > + trace_genpd_set_performance_state(genpd);
> > +
> > return 0;
> >
> > err:
> > @@ -418,14 +422,21 @@ static int _genpd_power_on(struct generic_pm_domain *genpd, bool timed)
> > if (!genpd->power_on)
> > return 0;
> >
> > - if (!timed)
> > - return genpd->power_on(genpd);
> > + if (!timed) {
> > + ret = genpd->power_on(genpd);
> > + if (!ret)
> > + trace_genpd_power_on(genpd);
> > +
> > + return ret;
> > + }
> >
> > time_start = ktime_get();
> > ret = genpd->power_on(genpd);
> > if (ret)
> > return ret;
> >
> > + trace_genpd_power_on(genpd);
> > +
> > elapsed_ns = ktime_to_ns(ktime_sub(ktime_get(), time_start));
> > if (elapsed_ns <= genpd->states[state_idx].power_on_latency_ns)
> > return ret;
> > @@ -448,14 +459,22 @@ static int _genpd_power_off(struct generic_pm_domain *genpd, bool timed)
> > if (!genpd->power_off)
> > return 0;
> >
> > - if (!timed)
> > - return genpd->power_off(genpd);
> > + if (!timed) {
> > + ret = genpd->power_off(genpd);
> > + if (!ret)
>
> Here
>
> > + trace_genpd_power_off(genpd);
> > +
> > + return ret;
> > + }
> >
> > time_start = ktime_get();
> > ret = genpd->power_off(genpd);
> > if (ret)
> > return ret;
> >
> > + if (!ret)
>
> And here add a conditional branch for only a tracepoint. To eliminate
> the branch when tracepoints are not enabled, please do it this way
> instead:
>
> if (trace_genpd_power_off_enabled() && !ret)
>
> The above is a static branch (nop when disabled, and jmp when enabled),
> and the above should move the conditional branch on !ret into the
> section that is only called when the tracepoint is enabled.
ok, will do in future versions.
next prev parent reply other threads:[~2019-10-01 16:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 22:04 [PATCH v1] PM / Domains: Add tracepoints Matthias Kaehlcke
2019-09-27 5:36 ` Greg Kroah-Hartman
2019-09-27 8:42 ` Steven Rostedt
2019-10-01 16:35 ` Matthias Kaehlcke [this message]
2019-10-01 17:03 ` Steven Rostedt
2019-10-01 17:42 ` Matthias Kaehlcke
2019-10-01 18:08 ` Steven Rostedt
2019-10-01 19:37 ` Matthias Kaehlcke
2019-10-02 7:55 ` Rafael J. Wysocki
2019-10-02 19:10 ` Pavel Machek
2019-10-15 12:37 ` Ulf Hansson
2019-10-15 17:19 ` Matthias Kaehlcke
2019-10-16 13:47 ` Ulf Hansson
2019-10-16 18:13 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001163542.GB87296@google.com \
--to=mka@chromium.org \
--cc=amit.kucheria@linaro.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).