From: Rob Herring <robh@kernel.org>
To: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Jamie Lentin <jm@lentin.co.uk>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Igor Opaniuk <igor.opaniuk@toradex.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Sebastian Reichel <sre@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2 2/2] dt-bindings: power: reset: gpio-poweroff: Add 'force-mode' property
Date: Fri, 11 Oct 2019 09:48:12 -0500 [thread overview]
Message-ID: <20191011144812.GA7239@bogus> (raw)
In-Reply-To: <20190930141244.12311-3-oleksandr.suvorov@toradex.com>
On Mon, Sep 30, 2019 at 02:12:53PM +0000, Oleksandr Suvorov wrote:
> Add 'force-mode' property to allow the driver to load even if
> someone has registered the pm_power_off hook earlier.
>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
>
> ---
>
> Changes in v2: None
>
> .../devicetree/bindings/power/reset/gpio-poweroff.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt b/Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt
> index 3e56c1b34a4c..2056e299a472 100644
> --- a/Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt
> +++ b/Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt
> @@ -31,6 +31,9 @@ Optional properties:
> - inactive-delay-ms: Delay (default 100) to wait after driving gpio inactive
> - timeout-ms: Time to wait before asserting a WARN_ON(1). If nothing is
> specified, 3000 ms is used.
> +- force-mode: Force replacing pm_power_off kernel hook.
> + If this optional property is not specified, the driver will fail to
> + load if someone has registered the pm_power_off hook earlier.
What if the init order changes?
This is too tied to a specific OS implementation to go in DT.
Rob
prev parent reply other threads:[~2019-10-11 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 14:12 [PATCH v2 0/2] 'force-mode' for gpio-poweroff driver Oleksandr Suvorov
2019-09-30 14:12 ` [PATCH v2 1/2] power: reset: gpio-poweroff: add force mode Oleksandr Suvorov
2019-09-30 14:12 ` [PATCH v2 2/2] dt-bindings: power: reset: gpio-poweroff: Add 'force-mode' property Oleksandr Suvorov
2019-10-11 14:48 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011144812.GA7239@bogus \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=igor.opaniuk@toradex.com \
--cc=jm@lentin.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=mark.rutland@arm.com \
--cc=oleksandr.suvorov@toradex.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).