From: Rob Herring <robh@kernel.org>
To: Brian Masney <masneyb@onstation.org>
Cc: bjorn.andersson@linaro.org, georgi.djakov@linaro.org,
agross@kernel.org, mark.rutland@arm.com,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
jonathan@marek.ca
Subject: Re: [PATCH v2 1/2] dt-bindings: interconnect: qcom: add msm8974 bindings
Date: Fri, 11 Oct 2019 10:29:17 -0500 [thread overview]
Message-ID: <20191011152917.GA28441@bogus> (raw)
In-Reply-To: <20191005114605.5279-2-masneyb@onstation.org>
On Sat, Oct 05, 2019 at 07:46:04AM -0400, Brian Masney wrote:
> Add device tree bindings for the Qualcomm MSM8974 interconnect providers
> that support setting system bandwidth requirements between various
> network-on-chip fabrics.
>
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> ---
> Rob: I included in the next patch at the top a rough diagram showing the
> relationship between different buses. I wanted to include that diagram
> here, however I didn't since I assume that this document will be
> transformed into HTML. I've seen some of the text bindings in the IIO
> subsystem have nice ASCII-art diagrams, such as
> Documentation/devicetree/bindings/iio/dac/dpot-dac.txt. Do you have any
> suggestions for how this can go in the YAML bindings? Prefix the line
> with four spaces, similiar to what is done in markdown?
The long term plan (dream?) is to extract schema into rST and there's
been some experimenting with embedded rST into description which seems
to work. But I don't see that happening anytime soon really. We've got
3500 bindings to convert...
So put whatever you like in the description as long as it's parseable
yaml.
>
> Changes since v1:
> - Don't include all compatibles in the examples. Removed interconnect
> GPU client from example as well.
> - Dual license header file: BSD or GPL 2.0
>
> .../bindings/interconnect/qcom,msm8974.yaml | 62 ++++++++
> .../dt-bindings/interconnect/qcom,msm8974.h | 146 ++++++++++++++++++
> 2 files changed, 208 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,msm8974.yaml
> create mode 100644 include/dt-bindings/interconnect/qcom,msm8974.h
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2019-10-11 15:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-05 11:46 [PATCH v2 0/2] interconnect: qcom: add msm8974 support Brian Masney
2019-10-05 11:46 ` [PATCH v2 1/2] dt-bindings: interconnect: qcom: add msm8974 bindings Brian Masney
2019-10-11 15:29 ` Rob Herring [this message]
2019-10-11 17:06 ` Bjorn Andersson
2019-10-05 11:46 ` [PATCH v2 2/2] interconnect: qcom: add msm8974 driver Brian Masney
2019-10-11 17:05 ` Bjorn Andersson
2019-10-12 11:00 ` Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011152917.GA28441@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=georgi.djakov@linaro.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masneyb@onstation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).