Linux-PM Archive on lore.kernel.org
 help / color / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	rjw@rjwysocki.net, daniel.lezcano@linaro.org,
	linux-pm@vger.kernel.org, mtosatti@redhat.com,
	Zhenzhong Duan <zhenzhong.duan@oracle.com>
Subject: Re: [PATCH] cpuidle: cpu hotplug support
Date: Mon, 14 Oct 2019 01:48:39 +0800
Message-ID: <201910140136.3iXhg6rD%lkp@intel.com> (raw)
In-Reply-To: <1570782899-31455-1-git-send-email-zhenzhong.duan@oracle.com>

[-- Attachment #1: Type: text/plain, Size: 2551 bytes --]

Hi Zhenzhong,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pm/linux-next]
[cannot apply to v5.4-rc2 next-20191011]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Zhenzhong-Duan/cpuidle-cpu-hotplug-support/20191014-000932
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/cpuidle/cpuidle.c: In function 'cpuidle_cpu_online':
>> drivers/cpuidle/cpuidle.c:580:6: error: 'coupled_cpus' undeclared (first use in this function); did you mean 'total_cpus'?
     if (coupled_cpus)
         ^~~~~~~~~~~~
         total_cpus
   drivers/cpuidle/cpuidle.c:580:6: note: each undeclared identifier is reported only once for each function it appears in

vim +580 drivers/cpuidle/cpuidle.c

   560	
   561	static int cpuidle_cpu_online(unsigned int cpu)
   562	{
   563		int ret;
   564		struct cpuidle_device *device;
   565		struct cpuidle_driver *drv;
   566	
   567		device = &per_cpu(cpuidle_dev, cpu);
   568		device->cpu = cpu;
   569	
   570		drv = cpuidle_get_cpu_driver(device);
   571		if (!drv || !cpumask_test_cpu(cpu, drv->cpumask))
   572			return 0;
   573	
   574	#ifdef CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED
   575		/*
   576		 * On multiplatform for ARM, the coupled idle states could be
   577		 * enabled in the kernel even if the cpuidle driver does not
   578		 * use it. Note, coupled_cpus is a struct copy.
   579		 */
 > 580		if (coupled_cpus)
   581			device->coupled_cpus = *coupled_cpus;
   582	#endif
   583		ret = cpuidle_register_device(device);
   584		if (ret)
   585			pr_err("Failed to register cpuidle device for cpu%d\n", cpu);
   586	
   587		return ret;
   588	}
   589	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 62105 bytes --]

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11  8:34 Zhenzhong Duan
2019-10-13 17:48 ` kbuild test robot [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201910140136.3iXhg6rD%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=zhenzhong.duan@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-PM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pm/0 linux-pm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pm linux-pm/ https://lore.kernel.org/linux-pm \
		linux-pm@vger.kernel.org
	public-inbox-index linux-pm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git