From: Sebastian Reichel <sre@kernel.org>
To: lecopzer@gmail.com
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
yj.chiang@mediatek.com, lecopzer.chen@mediatek.com
Subject: Re: [PATCH v2 2/2] test_power: Add CURRENT properties
Date: Mon, 14 Oct 2019 07:46:35 +0200 [thread overview]
Message-ID: <20191014054635.a5h5jyuefxqpderp@earth.universe> (raw)
In-Reply-To: <20190912182600.24211-3-lecopzer.chen@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 3941 bytes --]
Hi,
On Fri, Sep 13, 2019 at 02:26:00AM +0800, lecopzer@gmail.com wrote:
> CURRENT is really general in other battery drivers,
> Android also has an interface to monitor CURRENT, so let's
> add it into test framework.
>
> The default value (1.6A) is just a random but reasonable value.
>
> Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
> ---
Thanks, queued.
-- Sebastian
> drivers/power/supply/test_power.c | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/drivers/power/supply/test_power.c b/drivers/power/supply/test_power.c
> index 70db8d20e138..65c23ef6408d 100644
> --- a/drivers/power/supply/test_power.c
> +++ b/drivers/power/supply/test_power.c
> @@ -34,6 +34,7 @@ static int battery_technology = POWER_SUPPLY_TECHNOLOGY_LION;
> static int battery_capacity = 50;
> static int battery_voltage = 3300;
> static int battery_charge_counter = -1000;
> +static int battery_current = 1600;
>
> static bool module_initialized;
>
> @@ -118,6 +119,10 @@ static int test_power_get_battery_property(struct power_supply *psy,
> case POWER_SUPPLY_PROP_VOLTAGE_NOW:
> val->intval = battery_voltage;
> break;
> + case POWER_SUPPLY_PROP_CURRENT_AVG:
> + case POWER_SUPPLY_PROP_CURRENT_NOW:
> + val->intval = battery_current;
> + break;
> default:
> pr_info("%s: some properties deliberately report errors.\n",
> __func__);
> @@ -149,6 +154,8 @@ static enum power_supply_property test_power_battery_props[] = {
> POWER_SUPPLY_PROP_SERIAL_NUMBER,
> POWER_SUPPLY_PROP_TEMP,
> POWER_SUPPLY_PROP_VOLTAGE_NOW,
> + POWER_SUPPLY_PROP_CURRENT_AVG,
> + POWER_SUPPLY_PROP_CURRENT_NOW,
> };
>
> static char *test_power_ac_supplied_to[] = {
> @@ -467,6 +474,21 @@ static int param_set_battery_charge_counter(const char *key,
>
> #define param_get_battery_charge_counter param_get_int
>
> +static int param_set_battery_current(const char *key,
> + const struct kernel_param *kp)
> +{
> + int tmp;
> +
> + if (1 != sscanf(key, "%d", &tmp))
> + return -EINVAL;
> +
> + battery_current = tmp;
> + signal_power_supply_changed(test_power_supplies[TEST_BATTERY]);
> + return 0;
> +}
> +
> +#define param_get_battery_current param_get_int
> +
> static const struct kernel_param_ops param_ops_ac_online = {
> .set = param_set_ac_online,
> .get = param_get_ac_online,
> @@ -512,6 +534,11 @@ static const struct kernel_param_ops param_ops_battery_charge_counter = {
> .get = param_get_battery_charge_counter,
> };
>
> +static const struct kernel_param_ops param_ops_battery_current = {
> + .set = param_set_battery_current,
> + .get = param_get_battery_current,
> +};
> +
> #define param_check_ac_online(name, p) __param_check(name, p, void);
> #define param_check_usb_online(name, p) __param_check(name, p, void);
> #define param_check_battery_status(name, p) __param_check(name, p, void);
> @@ -521,6 +548,7 @@ static const struct kernel_param_ops param_ops_battery_charge_counter = {
> #define param_check_battery_capacity(name, p) __param_check(name, p, void);
> #define param_check_battery_voltage(name, p) __param_check(name, p, void);
> #define param_check_battery_charge_counter(name, p) __param_check(name, p, void);
> +#define param_check_battery_current(name, p) __param_check(name, p, void);
>
>
> module_param(ac_online, ac_online, 0644);
> @@ -555,6 +583,9 @@ module_param(battery_charge_counter, battery_charge_counter, 0644);
> MODULE_PARM_DESC(battery_charge_counter,
> "battery charge counter (microampere-hours)");
>
> +module_param(battery_current, battery_current, 0644);
> +MODULE_PARM_DESC(battery_current, "battery current (milliampere)");
> +
> MODULE_DESCRIPTION("Power supply driver for testing");
> MODULE_AUTHOR("Anton Vorontsov <cbouatmailru@gmail.com>");
> MODULE_LICENSE("GPL");
> --
> 2.17.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-10-14 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 18:25 [PATCH v2 0/2] test_power: Add CHARGE_COUNTER and CURRENT properties lecopzer
2019-09-12 18:25 ` [PATCH v2 1/2] test_power: Add CHARGE_COUNTER properties lecopzer
2019-10-14 5:46 ` Sebastian Reichel
2019-09-12 18:26 ` [PATCH v2 2/2] test_power: Add CURRENT properties lecopzer
2019-10-14 5:46 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014054635.a5h5jyuefxqpderp@earth.universe \
--to=sre@kernel.org \
--cc=lecopzer.chen@mediatek.com \
--cc=lecopzer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=yj.chiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).