From: Herbert Xu <herbert@gondor.apana.org.au>
To: Borislav Petkov <bp@alien8.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Jiri Slaby <jslaby@suse.cz>,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Matt Fleming <matt@codeblueprint.co.uk>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Juergen Gross <jgross@suse.com>,
linux-crypto@vger.kernel.org, linux-pm@vger.kernel.org,
linux-efi@vger.kernel.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v9 24/28] x86_64/asm: Change all ENTRY+ENDPROC to SYM_FUNC_*
Date: Fri, 18 Oct 2019 17:56:23 +1100 [thread overview]
Message-ID: <20191018065623.GA15199@gondor.apana.org.au> (raw)
In-Reply-To: <20191016071230.GD1138@zn.tnic>
On Wed, Oct 16, 2019 at 09:12:30AM +0200, Borislav Petkov wrote:
> Hi,
>
> On Fri, Oct 11, 2019 at 01:51:04PM +0200, Jiri Slaby wrote:
> > These are all functions which are invoked from elsewhere, so annotate
> > them as global using the new SYM_FUNC_START. And their ENDPROC's by
> > SYM_FUNC_END.
> >
> > And make sure ENTRY/ENDPROC is not defined on X86_64, given these were
> > the last users.
> >
> > Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> > Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> [hibernate]
> > Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> [xen bits]
> > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: x86@kernel.org
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> > Cc: Len Brown <len.brown@intel.com>
> > Cc: Pavel Machek <pavel@ucw.cz>
> > Cc: Matt Fleming <matt@codeblueprint.co.uk>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> > Cc: Juergen Gross <jgross@suse.com>
> > Cc: linux-crypto@vger.kernel.org
> > Cc: linux-pm@vger.kernel.org
> > Cc: linux-efi@vger.kernel.org
> > Cc: xen-devel@lists.xenproject.org
> > ---
> > arch/x86/boot/compressed/efi_thunk_64.S | 4 +-
> > arch/x86/boot/compressed/head_64.S | 16 +++---
> > arch/x86/boot/compressed/mem_encrypt.S | 8 +--
> > arch/x86/crypto/aegis128-aesni-asm.S | 28 ++++-----
> > arch/x86/crypto/aes_ctrby8_avx-x86_64.S | 12 ++--
> > arch/x86/crypto/aesni-intel_asm.S | 60 ++++++++++----------
> > arch/x86/crypto/aesni-intel_avx-x86_64.S | 32 +++++------
> > arch/x86/crypto/blowfish-x86_64-asm_64.S | 16 +++---
> > arch/x86/crypto/camellia-aesni-avx-asm_64.S | 24 ++++----
> > arch/x86/crypto/camellia-aesni-avx2-asm_64.S | 24 ++++----
> > arch/x86/crypto/camellia-x86_64-asm_64.S | 16 +++---
> > arch/x86/crypto/cast5-avx-x86_64-asm_64.S | 16 +++---
> > arch/x86/crypto/cast6-avx-x86_64-asm_64.S | 24 ++++----
> > arch/x86/crypto/chacha-avx2-x86_64.S | 12 ++--
> > arch/x86/crypto/chacha-avx512vl-x86_64.S | 12 ++--
> > arch/x86/crypto/chacha-ssse3-x86_64.S | 12 ++--
> > arch/x86/crypto/crc32-pclmul_asm.S | 4 +-
> > arch/x86/crypto/crc32c-pcl-intel-asm_64.S | 4 +-
> > arch/x86/crypto/crct10dif-pcl-asm_64.S | 4 +-
> > arch/x86/crypto/des3_ede-asm_64.S | 8 +--
> > arch/x86/crypto/ghash-clmulni-intel_asm.S | 8 +--
> > arch/x86/crypto/nh-avx2-x86_64.S | 4 +-
> > arch/x86/crypto/nh-sse2-x86_64.S | 4 +-
> > arch/x86/crypto/poly1305-avx2-x86_64.S | 4 +-
> > arch/x86/crypto/poly1305-sse2-x86_64.S | 8 +--
> > arch/x86/crypto/serpent-avx-x86_64-asm_64.S | 24 ++++----
> > arch/x86/crypto/serpent-avx2-asm_64.S | 24 ++++----
> > arch/x86/crypto/serpent-sse2-x86_64-asm_64.S | 8 +--
> > arch/x86/crypto/sha1_avx2_x86_64_asm.S | 4 +-
> > arch/x86/crypto/sha1_ni_asm.S | 4 +-
> > arch/x86/crypto/sha1_ssse3_asm.S | 4 +-
> > arch/x86/crypto/sha256-avx-asm.S | 4 +-
> > arch/x86/crypto/sha256-avx2-asm.S | 4 +-
> > arch/x86/crypto/sha256-ssse3-asm.S | 4 +-
> > arch/x86/crypto/sha256_ni_asm.S | 4 +-
> > arch/x86/crypto/sha512-avx-asm.S | 4 +-
> > arch/x86/crypto/sha512-avx2-asm.S | 4 +-
> > arch/x86/crypto/sha512-ssse3-asm.S | 4 +-
> > arch/x86/crypto/twofish-avx-x86_64-asm_64.S | 24 ++++----
> > arch/x86/crypto/twofish-x86_64-asm_64-3way.S | 8 +--
> > arch/x86/crypto/twofish-x86_64-asm_64.S | 8 +--
>
> I could use an ACK for the crypto bits...
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2019-10-18 7:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191011115108.12392-1-jslaby@suse.cz>
2019-10-11 11:50 ` [PATCH v9 01/28] linkage: Introduce new macros for assembler symbols Jiri Slaby
2019-10-14 9:31 ` Rafael J. Wysocki
2019-10-18 16:30 ` [tip: x86/asm] " tip-bot2 for Jiri Slaby
2019-10-11 11:50 ` [PATCH v9 02/28] x86/asm/suspend: Use SYM_DATA for data Jiri Slaby
2019-10-18 16:30 ` [tip: x86/asm] " tip-bot2 for Jiri Slaby
2019-10-11 11:51 ` [PATCH v9 24/28] x86_64/asm: Change all ENTRY+ENDPROC to SYM_FUNC_* Jiri Slaby
2019-10-16 7:12 ` Borislav Petkov
2019-10-18 6:56 ` Herbert Xu [this message]
2019-10-11 11:51 ` [PATCH v9 25/28] x86_32/asm: Add ENDs to some functions and relabel with SYM_CODE_* Jiri Slaby
2019-10-18 16:30 ` [tip: x86/asm] x86/asm/32: " tip-bot2 for Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018065623.GA15199@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ard.biesheuvel@linaro.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jslaby@suse.cz \
--cc=len.brown@intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).