From: Pavel Machek <pavel@ucw.cz>
To: Jonas Meurer <jonas@freesources.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, Len Brown <len.brown@intel.com>,
Tim Dittler <tim.dittler@systemli.org>
Subject: Re: [RFC PATCH] PM: Add a switch for disabling/enabling sync() before suspend
Date: Tue, 22 Oct 2019 12:39:09 +0200 [thread overview]
Message-ID: <20191022103909.GA10573@amd> (raw)
In-Reply-To: <3858a5b3-7e62-977e-0292-964c4dcfef5a@freesources.org>
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
Hi!
> Hi Rafael and linux-pm maintainers,
>
> sorry for the noise, but again: is there a chance to get a brief review
> of my patchset?
>
> Probably it was a bad idea to rename the build-time flag, right? Should
> I revert that part of the patch?
I don't like adding more and more knobs.
We should not have added that compile-time option, either.
Perhaps it is time to declare that if the user wants the data to be
synced, he just does sys_sync() himself?
(Yes, that will mean tiny ammount of dirty data created between
sys_sync() and suspend to be unwritten, but...)
(Besides, if you add a runtime option to avoid deadlocks, you still
have not fixed the deadlocks...)
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-10-22 10:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 10:50 [RFC PATCH] PM: Add a switch for disabling/enabling sync() before suspend Jonas Meurer
2019-10-10 15:00 ` Jonas Meurer
2019-10-11 10:22 ` Rafael J. Wysocki
2019-10-14 17:46 ` Jonas Meurer
2019-10-14 17:48 ` [PATCH v2 1/2] " Jonas Meurer
2019-10-14 17:49 ` [PATCH v2 2/2] PM: Change CONFIG_SUSPEND_SKIP_SYNC to CONFIG_SKIP_SYNC_ON_SUSPEND Jonas Meurer
2019-11-04 10:51 ` [PATCH v3 2/2] PM: CONFIG_SUSPEND_SKIP_SYNC sets default for '/sys/power/sync_on_suspend' Jonas Meurer
2019-10-21 10:47 ` [RFC PATCH] PM: Add a switch for disabling/enabling sync() before suspend Jonas Meurer
2019-10-21 21:47 ` Rafael J. Wysocki
2019-10-22 8:54 ` Jonas Meurer
2019-11-04 10:57 ` Jonas Meurer
2019-11-12 11:00 ` Jonas Meurer
2019-12-02 14:12 ` Yannik Sembritzki
2019-12-02 17:05 ` Jonas Meurer
2019-10-22 10:39 ` Pavel Machek [this message]
2019-10-31 15:56 ` Jonas Meurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022103909.GA10573@amd \
--to=pavel@ucw.cz \
--cc=jonas@freesources.org \
--cc=len.brown@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tim.dittler@systemli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).