From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57B16C43141 for ; Thu, 14 Nov 2019 01:44:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6CDCD206F2 for ; Thu, 14 Nov 2019 01:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573695869; bh=WGU731xfZRP03cEmP8Yow3oDKX/5EXmsf3eK4IVtbbE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KscoV4ds4Q2i9gITZrSuAcIlWDpQmlCRTsTPKYSvegNpeFRxD46N1Vf6y0w09l5RQ WsTxqmqP0WGuUFxkFG2AiwJb3SrjqvvFBYNKVotSOqihSq0mdaLEgIcWtWXRZBVEt0 hDoNsXg3qHYjj2UDrfGCJqRg34YuFQ3GBuRQLLwo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726409AbfKNBo2 (ORCPT ); Wed, 13 Nov 2019 20:44:28 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:38797 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726098AbfKNBo2 (ORCPT ); Wed, 13 Nov 2019 20:44:28 -0500 Received: by mail-oi1-f193.google.com with SMTP id a14so3783594oid.5; Wed, 13 Nov 2019 17:44:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XksZDpsl+U9eidQT9vUr4VQK7VIl76Oi7Z4m7FmcSig=; b=eiGEAnKohzglrL+17a7LCbDm1IcEOgMAYqAgltZwgEb0N/JojEnxfjl4dyChthdIhM K1lpRMX5/UFYq0IhTSFpZ1qoM/C9NfqJcWFwOMDml2aNIpfInylEl9Tb3UaTv93iedQ1 hOI3/AbE3xchVBao9hKQpo5u27iKne/oElr555fFG7WHi1N/9pZ2AfNZBFJDBoT/ic+e n5iF9E11hqcLvlFSztXaZBA++9FgZkXI++T8SAmLpJ845S69Ccdt3j/sbmSB8SwjRqN0 OxKnXF1c6mKbUKQ/tJhssr2Pc1M+vWLwjUv43O2P9NVGuQBybuHg7BJ+01XkwaPovCdF AqYw== X-Gm-Message-State: APjAAAULh32ryAhTitGP+KVmz4zg9YbBepVlOIzBiEigWEA1TEOb+QgL DjDaShGk1yATyZpdsr9hC4SJLdA= X-Google-Smtp-Source: APXvYqx2Eeg+6EnhJgfdAOYmTb/PvPNHZCErIRw9s8XIEA97Diy6JQJHOsXE/C4FqFN6moMduEPhwQ== X-Received: by 2002:aca:845:: with SMTP id 66mr1397732oii.137.1573695867242; Wed, 13 Nov 2019 17:44:27 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id h79sm1303959oib.3.2019.11.13.17.44.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2019 17:44:26 -0800 (PST) Date: Wed, 13 Nov 2019 19:44:25 -0600 From: Rob Herring To: Paul Walmsley , Christoph Hellwig Cc: Sebastian Reichel , Mark Rutland , Palmer Dabbelt , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, peter.maydell@linaro.org Subject: Re: [PATCH 1/2] dt-bindings: power: reset: document the QEMU RISC-V virt machine poweroff device Message-ID: <20191114014425.GA1748@bogus> References: <20191107212408.11857-1-hch@lst.de> <20191107212408.11857-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Nov 07, 2019 at 02:32:01PM -0800, Paul Walmsley wrote: > On Thu, 7 Nov 2019, Christoph Hellwig wrote: > > > Add the binding for the trivial Qemu RISC-V poweroff mechanism, which is > > There's nothing RISC-V specific here. This IP isn't defined in the RISC-V > specifications, or anything like that. Does the VM have a spec or anything? Would be nice if it did. Would be nicer still to just copy Arm's virt machine. > Apparently it's a SiFive IP block which now has a virtual IP > implementation in QEMU in hw/riscv/sifive_test.c. But since there's > nothing RISC-V specific about this IP block, any QEMU system, with any CPU > implementation, should be able to use this virtual IP, and this Linux > driver. > > For these reasons, it's better if "RISC-V" is just removed from everywhere > in this driver. If something needs to go in its place, "SiFive" may be > better. IIRC, there's already syscon poweroff binding. You could probably use that. > > > - Paul > > > > just a single MMIO register exposed through the DT. > > > > Signed-off-by: Christoph Hellwig > > --- > > .../power/reset/qemu-riscv-virt-poweroff.txt | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/power/reset/qemu-riscv-virt-poweroff.txt > > > > diff --git a/Documentation/devicetree/bindings/power/reset/qemu-riscv-virt-poweroff.txt b/Documentation/devicetree/bindings/power/reset/qemu-riscv-virt-poweroff.txt > > new file mode 100644 > > index 000000000000..80ff6fd4e3b7 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/power/reset/qemu-riscv-virt-poweroff.txt > > @@ -0,0 +1,16 @@ > > +QEMU RISC-V virt machine poweroff device > > + > > +This is a device in Qemu that can signal successful or error exit > > +by writing two magic numbers to a trivial mmio register. > > +A Linux poweroff is implemented as successful exit. > > + > > +Required Properties: > > +-compatible: "sifive,test0" > > +-reg: Specifies the physical address of the register > > + > > +Example: > > + > > + test@100000 { > > + compatible = "sifive,test0"; > > + reg = <0x100000 0x1000>; > > + }; > > -- > > 2.20.1 > > > > > > > - Paul