From: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
To: <x86@kernel.org>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <rjw@rjwysocki.net>, <len.brown@intel.com>, <pavel@ucw.cz>,
<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<hpa@zytor.com>, Cao jin <caoj.fnst@cn.fujitsu.com>,
<linux-acpi@vger.kernel.org>
Subject: [RFC PATCH] x86/acpi: Drop duplicate BOOT table initialization
Date: Fri, 15 Nov 2019 17:24:24 +0800 [thread overview]
Message-ID: <20191115092424.17356-1-ruansy.fnst@cn.fujitsu.com> (raw)
From: Cao jin <caoj.fnst@cn.fujitsu.com>
ACPI BOOT table is initialized in both acpi_boot_table_init &
acpi_boot_init of setup_arch, but its usage is quite late at the end of
start_kernel. It should be safe to drop one of them. Since it is less
related with table init, drop it from there.
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: <linux-acpi@vger.kernel.org>
Signed-off-by: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
---
arch/x86/kernel/acpi/boot.c | 2 --
1 file changed, 2 deletions(-)
It existed since git repo is built, so it might has its reason? The
patch is not tested since I don't have BOOT table in my firmware.
diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index 04205ce127a1..ca1c15bb0b48 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -1558,8 +1558,6 @@ void __init acpi_boot_table_init(void)
return;
}
- acpi_table_parse(ACPI_SIG_BOOT, acpi_parse_sbf);
-
/*
* blacklist may disable ACPI entirely
*/
--
2.21.0
next reply other threads:[~2019-11-15 9:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 9:24 Shiyang Ruan [this message]
2019-11-29 11:11 ` [RFC PATCH] x86/acpi: Drop duplicate BOOT table initialization Cao jin
2019-12-12 22:03 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2019-11-15 5:06 Shiyang Ruan
2019-11-15 9:09 ` Rafael J. Wysocki
2019-11-15 9:18 ` Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115092424.17356-1-ruansy.fnst@cn.fujitsu.com \
--to=ruansy.fnst@cn.fujitsu.com \
--cc=bp@alien8.de \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).