From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9212EC432C0 for ; Wed, 27 Nov 2019 11:00:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5FF392070B for ; Wed, 27 Nov 2019 11:00:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726240AbfK0LAV convert rfc822-to-8bit (ORCPT ); Wed, 27 Nov 2019 06:00:21 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:46787 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726149AbfK0LAV (ORCPT ); Wed, 27 Nov 2019 06:00:21 -0500 X-Originating-IP: 90.76.211.102 Received: from xps13 (lfbn-1-2154-102.w90-76.abo.wanadoo.fr [90.76.211.102]) (Authenticated sender: miquel.raynal@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id ED4AB1C001A; Wed, 27 Nov 2019 11:00:18 +0000 (UTC) Date: Wed, 27 Nov 2019 12:00:18 +0100 From: Miquel Raynal To: Zak Hays Cc: Zhang Rui , Eduardo Valentin , Daniel Lezcano , Amit Kucheria , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2] thermal: armada-thermal: clear reset in armadaxp_init Message-ID: <20191127120018.679bf947@xps13> In-Reply-To: References: <1574721077-29892-1-git-send-email-zhays@lexmark.com> <1574721077-29892-2-git-send-email-zhays@lexmark.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Zak, Zak Hays wrote on Tue, 26 Nov 2019 14:54:11 +0000: > The reset bit needs to be cleared in the init sequence otherwise it > > holds the block in reset. "thermal: armada: " is the right prefix for your title Your Signed-off-by should be here (git commit --amend -s) The format of your patch is strange, there are additional empty lines which are problematic. > > --- > >  drivers/thermal/armada_thermal.c | 3 +++ > >  1 file changed, 3 insertions(+) > > > > diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c > > index 88363812033c..8c4d1244ee7a 100644 > > --- a/drivers/thermal/armada_thermal.c > > +++ b/drivers/thermal/armada_thermal.c > > @@ -155,6 +155,9 @@ static void armadaxp_init(struct platform_device *pdev, > >   > >          regmap_write(priv->syscon, data->syscon_control1_off, reg); > >   > > +       reg &= ~PMU_TDC0_SW_RST_MASK; > > +       regmap_write(priv->syscon, data->syscon_control1_off, reg); > > + Do you really want to write this register twice? Shouldn't you get rid of the first regmap_write() above? > >          /* Enable the sensor */ > >          regmap_read(priv->syscon, data->syscon_status_off, ®); > >          reg &= ~PMU_TM_DISABLE_MASK; > In your next iteration, please use the '-v2' option with git-format-patch to get titles starting with "[PATCH v2 x/2] ..." automatically. Also write a changelog below the three dots '---'. Thanks, Miquèl