From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53F76C432C0 for ; Wed, 27 Nov 2019 14:47:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 349682073F for ; Wed, 27 Nov 2019 14:47:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727073AbfK0OrG (ORCPT ); Wed, 27 Nov 2019 09:47:06 -0500 Received: from mga14.intel.com ([192.55.52.115]:18703 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726537AbfK0OrF (ORCPT ); Wed, 27 Nov 2019 09:47:05 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Nov 2019 06:47:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,249,1571727600"; d="scan'208";a="203094641" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by orsmga008.jf.intel.com with ESMTP; 27 Nov 2019 06:47:03 -0800 Date: Wed, 27 Nov 2019 06:47:03 -0800 From: Sean Christopherson To: Ingo Molnar Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "Rafael J. Wysocki" , Len Brown , Pavel Machek , Tony Luck , Fenghua Yu , Peter Zijlstra , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , "H. Peter Anvin" , Steven Rostedt , Ard Biesheuvel , Darren Hart , Andy Shevchenko , Nadav Amit , "VMware, Inc." , Arnd Bergmann , Greg Kroah-Hartman , Hans de Goede , Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v2 00/12] treewide: break dependencies on x86's RM header Message-ID: <20191127144703.GA18530@linux.intel.com> References: <20191126165417.22423-1-sean.j.christopherson@intel.com> <20191127072057.GB94748@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191127072057.GB94748@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, Nov 27, 2019 at 08:20:57AM +0100, Ingo Molnar wrote: > > * Sean Christopherson wrote: > > > x86's asm/realmode.h, which defines low level structures, variables and > > helpers used to bring up APs during SMP boot, ends up getting included in > > practically every nook and cranny of the kernel because the address used > > by ACPI for resuming from S3 also happens to be stored in the real mode > > header, and ACPI bleeds the dependency into its widely included headers. > > > > As a result, modifying realmode.h for even the most trivial change to the > > boot code triggers a full kernel rebuild, which is frustrating to say the > > least as it some of the most difficult code to get exactly right *and* is > > also some of the most functionally isolated code in the kernel. > > > > To break the kernel's widespread dependency on realmode.h, add a wrapper > > in the aforementioned ACPI S3 code to access the real mode header instead > > of derefencing the header directly in asm/acpi.h and thereby exposing it > > to the world via linux/acpi.h. > > > > v2: > > - Rebased on tip/x86/cleanups, commit b74374fef924 ("x86/setup: Enhance > > the comments"). > > - Use acpi_get_wakeup_address() as new function name. [Boris and Pavel] > > - Capture acpi_get_wakeup_address() in a local address. [Pavel] > > - Collect acks. I didn't add Rafael's acks on patches 11 and 12 due to > > the above changes. > > - Explicitly call out the removal of from > > in patch 12. [Ingo] > > - Remove superfluous Fixes: tags. [Ard] > > You didn't include every patch from v1 though, such us my fix to Quark: > > [PATCH] x86/platform/intel/quark: Explicitly include linux/io.h for virt_to_phys() > > I've applied that one too and your updated patches, and it's now all > pushed out into tip:WIP.core/headers. Sorry, it wasn't clear to me whether or not to include that one. Next time I'll ask.