From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 214BCC432C0 for ; Fri, 29 Nov 2019 00:54:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB45221775 for ; Fri, 29 Nov 2019 00:54:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=megous.com header.i=@megous.com header.b="GnnztAQF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726698AbfK2AyC (ORCPT ); Thu, 28 Nov 2019 19:54:02 -0500 Received: from vps.xff.cz ([195.181.215.36]:50656 "EHLO vps.xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726663AbfK2AyC (ORCPT ); Thu, 28 Nov 2019 19:54:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1574988839; bh=yNdzTaqRi2OqvGvJl0eaByi87kOwOz2kFUkxJaYh3zI=; h=Date:From:To:Cc:Subject:References:X-My-GPG-KeyId:From; b=GnnztAQFZHPDLDA0YI0aNQoV/T50Pn6KqSqEspvntuA7lZlVSrZwHhX1+yProIQOu 1u+OSyaV1z7WcoZ3SzNAeKb2XxNoXIqqNdM9tjGN1cJVFnwEYlL/f1OLhuq6NMnlY5 RQjI3YZhr2sf1mNClJilCxgaIQr0BvATHw6dWddk= Date: Fri, 29 Nov 2019 01:53:59 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Frank Lee Cc: Vasily Khoruzhick , Mark Rutland , devicetree , Amit Kucheria , Linux PM , Greg Kroah-Hartman , Daniel Lezcano , Linux Kernel Mailing List , Maxime Ripard , Eduardo Valentin , Chen-Yu Tsai , Rob Herring , Mauro Carvalho Chehab , Zhang Rui , "David S. Miller" , Linux ARM Subject: Re: [PATCH v6 1/7] thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40 Message-ID: <20191129005359.lyxtk5p7ebcon5uq@core.my.home> Mail-Followup-To: Frank Lee , Vasily Khoruzhick , Mark Rutland , devicetree , Amit Kucheria , Linux PM , Greg Kroah-Hartman , Daniel Lezcano , Linux Kernel Mailing List , Maxime Ripard , Eduardo Valentin , Chen-Yu Tsai , Rob Herring , Mauro Carvalho Chehab , Zhang Rui , "David S. Miller" , Linux ARM References: <20191127052935.1719897-1-anarsoul@gmail.com> <20191127052935.1719897-2-anarsoul@gmail.com> <20191127111419.z5hfu5soxceiivg6@core.my.home> <20191127173547.ch3pcv3lxgdcrfnu@gilmour.lan> <20191127222427.coyeggbxs5miioxn@core.my.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Nov 28, 2019 at 11:16:05PM +0800, Frank Lee wrote: > On Thu, Nov 28, 2019 at 6:24 AM Ondřej Jirman wrote: > > > > On Wed, Nov 27, 2019 at 11:48:32AM -0800, Vasily Khoruzhick wrote: > > > On Wed, Nov 27, 2019 at 11:44 AM Frank Lee wrote: > > > > > > > > Hello Vasily, > > > > > > > > Thank you very much for your work on this. > > > > This looks good to me. > > > > > > Thanks! > > > > > > > By the way, I would like to ask comments about adding the following code. > > > > > > Can we add it as follow up patch? I don't think that I have a device > > > with working suspend to test it and I'm hesitant to add any code that > > > I can't test. > > > > I have, but it doesn't use any of the clocks and resets, so it wouldn't > > test this fully, and basicaly doesn't need re-calibration at all, probably. > > > > So that may be one feedback. On a83t, I'd made these callbacks a no-op. > > This is just that the mainline code does not yet have the S2RAM code > implementation of these SOCs. > Each module has its own suspend function and resume function as part > of the system suspend function. > When the system is in S2RAM, the entire SOC will be completely powered > off, and each module > needs to save and restore its own state. I know, but on A83T THS (named R_TH in the datasheet) is in the RTC power domain, so it will not be powered down, even if you power down rest of the SoC. I guess you can make it not run by other means, but it will not need restoring any state, since it will not lose any during suspend. regards, o. > Yangtao > > > > > regards, > > o. > > > > > > > > > > diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c > > > > index c0ed60782b11..579dde5e0701 100644 > > > > --- a/drivers/thermal/sun8i_thermal.c > > > > +++ b/drivers/thermal/sun8i_thermal.c > > > > @@ -629,11 +629,63 @@ static const struct of_device_id of_ths_match[] = { > > > > }; > > > > MODULE_DEVICE_TABLE(of, of_ths_match); > > > > > > > > +static int __maybe_unused sun8i_thermal_suspend(struct device *dev) > > > > +{ > > > > + struct ths_device *tmdev; = dev_get_drvdata(dev); > > > > + > > > > + clk_disable(tmdev->mod_clk); > > > > + clk_disable(tmdev->bus_clk); > > > > + > > > > + reset_control_assert(tmdev->reset); > > > > + > > > > + return 0; > > > > +} > > > > + > > > > +static int __maybe_unused sun8i_thermal_resume(struct device *dev) > > > > +{ > > > > + struct ths_device *tmdev; = dev_get_drvdata(dev); > > > > + int error; > > > > + > > > > + error = reset_control_deassert(tmdev->reset); > > > > + if (error) > > > > + return error; > > > > + > > > > + error = clk_enable(tmdev->bus_clk); > > > > + if (error) > > > > + goto assert_reset; > > > > + > > > > + clk_set_rate(tmdev->mod_clk, 24000000); > > > > + error = clk_enable(tmdev->mod_clk); > > > > + if (error) > > > > + goto bus_disable; > > > > + > > > > + sun8i_ths_calibrate(tmdev); > > > > + > > > > + ret = tmdev->chip->init(tmdev); > > > > + if (ret) > > > > + goto mod_disable; > > > > + > > > > + return 0; > > > > + > > > > +mod_disable: > > > > + clk_disable(tmdev->mod_clk); > > > > +bus_disable: > > > > + clk_disable(tmdev->bus_clk); > > > > +assert_reset: > > > > + reset_control_assert(tmdev->reset); > > > > + > > > > + return 0; > > > > +} > > > > + > > > > +static SIMPLE_DEV_PM_OPS(sun8i_thermal_pm_ops, > > > > + sun8i_thermal_suspend, sun8i_thermal_resume); > > > > + > > > > static struct platform_driver ths_driver = { > > > > .probe = sun8i_ths_probe, > > > > .remove = sun8i_ths_remove, > > > > .driver = { > > > > .name = "sun8i-thermal", > > > > + .pm = &sun8i_thermal_pm_ops, > > > > .of_match_table = of_ths_match, > > > > }, > > > > }; > > > > > > > > Yangtao > > > > > > _______________________________________________ > > > linux-arm-kernel mailing list > > > linux-arm-kernel@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel