linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Peter De Schrijver <pdeschrijver@nvidia.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v8 12/19] cpuidle: Avoid NULL dereference in cpuidle_driver_state_disabled()
Date: Tue,  3 Dec 2019 03:41:09 +0300	[thread overview]
Message-ID: <20191203004116.11771-13-digetx@gmail.com> (raw)
In-Reply-To: <20191203004116.11771-1-digetx@gmail.com>

The cpumask is NULL if cpuidle_driver_state_disabled() is called before
cpuidle driver is initialized. This shouldn't be a problem for now because
cpuidle drivers are registered quite early. The NVIDIA Tegra cpuidle
driver is going to be moved to a later init stage and thus it could become
a problem if PCIE driver is probed earlier than cpuidle.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/cpuidle/driver.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/cpuidle/driver.c b/drivers/cpuidle/driver.c
index c76423aaef4d..f8164f56c420 100644
--- a/drivers/cpuidle/driver.c
+++ b/drivers/cpuidle/driver.c
@@ -403,6 +403,9 @@ void cpuidle_driver_state_disabled(struct cpuidle_driver *drv, int idx,
 
 	mutex_lock(&cpuidle_lock);
 
+	if (!drv->cpumask)
+		goto unlock;
+
 	for_each_cpu(cpu, drv->cpumask) {
 		struct cpuidle_device *dev = per_cpu(cpuidle_devices, cpu);
 
@@ -415,5 +418,6 @@ void cpuidle_driver_state_disabled(struct cpuidle_driver *drv, int idx,
 			dev->states_usage[idx].disable &= ~CPUIDLE_STATE_DISABLED_BY_DRIVER;
 	}
 
+unlock:
 	mutex_unlock(&cpuidle_lock);
 }
-- 
2.24.0


  parent reply	other threads:[~2019-12-03  0:42 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03  0:40 [PATCH v8 00/19] Consolidate and improve NVIDIA Tegra CPUIDLE driver(s) Dmitry Osipenko
2019-12-03  0:40 ` [PATCH v8 01/19] ARM: tegra: Compile sleep-tegra20/30.S unconditionally Dmitry Osipenko
2019-12-03  0:40 ` [PATCH v8 02/19] ARM: tegra: Add tegra_pm_park_secondary_cpu() Dmitry Osipenko
2019-12-03  0:41 ` [PATCH v8 03/19] ARM: tegra: Remove pen-locking from cpuidle-tegra20 Dmitry Osipenko
2019-12-03  0:41 ` [PATCH v8 04/19] ARM: tegra: Change tegra_set_cpu_in_lp2() type to void Dmitry Osipenko
2019-12-03  0:41 ` [PATCH v8 05/19] ARM: tegra: Propagate error from tegra_idle_lp2_last() Dmitry Osipenko
2019-12-03  0:41 ` [PATCH v8 06/19] ARM: tegra: Expose PM functions required for new cpuidle driver Dmitry Osipenko
2019-12-03  0:41 ` [PATCH v8 07/19] ARM: tegra: Rename some of the newly exposed PM functions Dmitry Osipenko
2019-12-03  0:41 ` [PATCH v8 08/19] ARM: tegra: Make outer_disable() open-coded Dmitry Osipenko
2019-12-03  0:41 ` [PATCH v8 09/19] arm: tegra20: cpuidle: Handle case where secondary CPU hangs on entering LP2 Dmitry Osipenko
2019-12-03  0:41 ` [PATCH v8 10/19] arm: tegra20: cpuidle: Make abort_flag atomic Dmitry Osipenko
2019-12-03  0:41 ` [PATCH v8 11/19] arm: tegra20/30: cpuidle: Remove unnecessary memory barrier Dmitry Osipenko
2019-12-03  0:41 ` Dmitry Osipenko [this message]
2019-12-03  0:41 ` [PATCH v8 13/19] cpuidle: Refactor and move out NVIDIA Tegra20 driver into drivers/cpuidle Dmitry Osipenko
2019-12-03  0:41 ` [PATCH v8 14/19] cpuidle: tegra: Squash Tegra30 driver into the common driver Dmitry Osipenko
2019-12-03  0:41 ` [PATCH v8 15/19] cpuidle: tegra: Support CPU cluster power-down state on Tegra30 Dmitry Osipenko
2019-12-03  0:41 ` [PATCH v8 16/19] cpuidle: tegra: Squash Tegra114 driver into the common driver Dmitry Osipenko
2019-12-03  0:41 ` [PATCH v8 17/19] cpuidle: tegra: Disable CC6 state if LP2 unavailable Dmitry Osipenko
2019-12-03  0:41 ` [PATCH v8 18/19] ARM: multi_v7_defconfig: Enable Tegra cpuidle driver Dmitry Osipenko
2019-12-03  0:41 ` [PATCH v8 19/19] ARM: tegra: Enable Tegra cpuidle driver in tegra_defconfig Dmitry Osipenko
2019-12-07 19:31 ` [PATCH v8 00/19] Consolidate and improve NVIDIA Tegra CPUIDLE driver(s) Michał Mirosław
2019-12-07 22:56   ` Dmitry Osipenko
2019-12-07 21:52 ` Michał Mirosław
2019-12-07 22:56   ` Dmitry Osipenko
2019-12-09 16:04     ` Michał Mirosław
2019-12-09 21:22       ` Dmitry Osipenko
2019-12-10  2:35         ` Michał Mirosław
2019-12-10 16:02           ` Dmitry Osipenko
2019-12-10 16:21             ` Dmitry Osipenko
2019-12-18  7:10               ` Dmitry Osipenko
2019-12-11  8:51 ` Peter De Schrijver
2019-12-12  1:58   ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191203004116.11771-13-digetx@gmail.com \
    --to=digetx@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=pdeschrijver@nvidia.com \
    --cc=rjw@rjwysocki.net \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).