From: Viresh Kumar <viresh.kumar@linaro.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mikko Perttunen <cyndis@kapsi.fi>,
Sumit Gupta <sumitg@nvidia.com>,
rjw@rjwysocki.net, catalin.marinas@arm.com, will@kernel.org,
jonathanh@nvidia.com, talho@nvidia.com, linux-pm@vger.kernel.org,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, bbasu@nvidia.com,
mperttunen@nvidia.com, devicetree@vger.kernel.org
Subject: Re: [TEGRA194_CPUFREQ Patch 1/3] firmware: tegra: adding function to get BPMP data
Date: Wed, 4 Dec 2019 15:21:38 +0530 [thread overview]
Message-ID: <20191204095138.rrul5vxnkprfwmku@vireshk-i7> (raw)
In-Reply-To: <20191204093339.GA2784830@ulmo>
On 04-12-19, 10:33, Thierry Reding wrote:
> Yeah, the code that registers this device is in drivers/base/cpu.c in
> register_cpu(). It even retrieves the device tree node for the CPU from
> device tree and stores it in cpu->dev.of_node, so we should be able to
> just pass &cpu->dev to tegra_bpmp_get() in order to retrieve a reference
> to the BPMP.
>
> That said, I'm wondering if perhaps we could just add a compatible
> string to the /cpus node for cases like this where we don't have an
> actual device representing the CPU complex. There are a number of CPU
> frequency drivers that register dummy devices just so that they have
> something to bind a driver to.
>
> If we allow the /cpus node to represent the CPU complex (if no other
> "device" does that yet), we can add a compatible string and have the
> cpufreq driver match on that.
>
> Of course this would be slightly difficult to retrofit into existing
> drivers because they'd need to remain backwards compatible with existing
> device trees. But it would allow future drivers to do this a little more
> elegantly. For some SoCs this may not matter, but especially once you
> start depending on additional resources this would come in handy.
>
> Adding Rob and the device tree mailing list for feedback on this idea.
Took some time to find this thread, but something around this was
suggested by Rafael earlier.
https://lore.kernel.org/lkml/8139001.Q4eV8YG1Il@vostro.rjw.lan/
--
viresh
next prev parent reply other threads:[~2019-12-04 9:51 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 17:32 [TEGRA194_CPUFREQ Patch 1/3] firmware: tegra: adding function to get BPMP data Sumit Gupta
2019-12-03 17:32 ` [TEGRA194_CPUFREQ Patch 2/3] cpufreq: Add Tegra194 cpufreq driver Sumit Gupta
2019-12-04 5:40 ` Viresh Kumar
2019-12-04 10:55 ` sumitg
2019-12-04 11:27 ` Viresh Kumar
2019-12-04 13:57 ` Dmitry Osipenko
2019-12-05 2:51 ` Viresh Kumar
2019-12-05 12:55 ` Dmitry Osipenko
2020-03-25 23:59 ` sumitg
2019-12-04 13:59 ` Dmitry Osipenko
2019-12-05 14:15 ` Dmitry Osipenko
2020-03-26 11:50 ` Viresh Kumar
2020-04-04 18:38 ` sumitg
2020-04-06 2:55 ` Viresh Kumar
2020-04-07 18:18 ` sumitg
2020-04-08 5:53 ` Viresh Kumar
2020-04-08 11:24 ` sumitg
2020-04-09 7:44 ` Viresh Kumar
2020-04-09 11:21 ` Sumit Gupta
2020-04-13 6:21 ` Viresh Kumar
2020-04-13 12:20 ` Sumit Gupta
2020-04-14 5:45 ` Viresh Kumar
2020-04-15 11:25 ` Sumit Gupta
2020-04-16 3:37 ` Viresh Kumar
2020-04-16 7:06 ` Sumit Gupta
2019-12-03 17:32 ` [TEGRA194_CPUFREQ Patch 3/3] arm64: defconfig: Enable CONFIG_ARM_TEGRA194_CPUFREQ Sumit Gupta
2019-12-03 17:42 ` [TEGRA194_CPUFREQ Patch 1/3] firmware: tegra: adding function to get BPMP data Thierry Reding
2019-12-04 8:45 ` Mikko Perttunen
2019-12-04 9:17 ` Viresh Kumar
2019-12-04 9:33 ` Thierry Reding
2019-12-04 9:51 ` Viresh Kumar [this message]
2020-04-07 10:05 ` Thierry Reding
2020-04-27 7:18 ` Thierry Reding
2020-04-29 8:21 ` Sumit Gupta
2020-05-06 16:58 ` Thierry Reding
2020-05-20 14:43 ` Rob Herring
2020-05-20 15:38 ` Thierry Reding
2020-05-20 16:21 ` Rob Herring
2019-12-04 10:21 ` Mikko Perttunen
2019-12-04 10:26 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191204095138.rrul5vxnkprfwmku@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=bbasu@nvidia.com \
--cc=catalin.marinas@arm.com \
--cc=cyndis@kapsi.fi \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sumitg@nvidia.com \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).