From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F19A7C2D0D2 for ; Tue, 24 Dec 2019 13:12:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C4E4C2075E for ; Tue, 24 Dec 2019 13:12:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lEzXy/5f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726183AbfLXNMC (ORCPT ); Tue, 24 Dec 2019 08:12:02 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:35700 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726124AbfLXNMC (ORCPT ); Tue, 24 Dec 2019 08:12:02 -0500 Received: by mail-wm1-f65.google.com with SMTP id p17so2494953wmb.0; Tue, 24 Dec 2019 05:11:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xv6fj//PLhqbq16JTfxLOSmf7sN0fE/sKGiYmf3uDbg=; b=lEzXy/5fCv6xqhHgtLqYCRDpU59kJQsMB9S1Dx3oM9bFlHPVeS5ca4OfJTlyWxf0R1 qHO+4Bdmh3LXlSLS8AYFJucCKjK6aB4Xr5F9sNKT+crnsL5rCODfPefYP7gOlHARlQ5c jmpGjV9TiV2vSRXcp0E7YXYJLkHcNrWqpLMqmj6s2AsV5JEfWWqm7qQxsuqqkHjyNhJI Dy052j+I4s9f/5Lg1Gu8gjvDW1RDVabHP8Rfah8Lp4KJoRsiA9SsYHe0NyAiIsiGor6J /gUUuFULmKaO0Yh2M0+wyF5uqXhZ5F3/0PtNvic/kO2UO5gCLdz7tND8ZeVyhTy/WnsQ dE1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xv6fj//PLhqbq16JTfxLOSmf7sN0fE/sKGiYmf3uDbg=; b=jmADIH/Vsa+VjvlZMH5GEq1xSVlEGs1zv9AiEi2WOv3VdoY93sadPt/MW5jgjIPJ4r wFEb//PxwOLOm7Gxc7lNMfoSJPPzd3YxmRbZObFl2J3VSQKKyt9sQBfbffYB5p9XvJYD wcxjcpwOWzgB5PAK7f6lD/iZep2nOwsintPHWMVYFRtlsALzmGBFhO33xTD8sW4uqdmZ A9wrPzIRTCuN0ewjsEvFviDyCdbsiuPbfpNf4Nfa9rx4D93jXehep1SNuUZMi5zi0EzB 8pb92it920JlByzz1yzFrdxq4W/INrUKRdgdBlMoxqWK5AuP8RL3R80GnHb5SnMhK8Sf gOFw== X-Gm-Message-State: APjAAAUmUWC/UgAv1eaHoAfFfi30QvKRFi3X+U8S+c0vG9zDRfmbRQKO QcMpA6/3VCOKnrpJfDw+RjA= X-Google-Smtp-Source: APXvYqzRuYR6134pRDFq3Yf9xY6KpX3WI/tV3Jrpy6rro6JAMVg6375WF3SECTkCFDEBgqcM698j1A== X-Received: by 2002:a7b:c4cc:: with SMTP id g12mr4445625wmk.68.1577193118768; Tue, 24 Dec 2019 05:11:58 -0800 (PST) Received: from Red ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id g7sm24175656wrq.21.2019.12.24.05.11.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Dec 2019 05:11:57 -0800 (PST) Date: Tue, 24 Dec 2019 14:11:55 +0100 From: Corentin Labbe To: Vasily Khoruzhick Cc: Yangtao Li , Zhang Rui , Daniel Lezcano , Amit Kucheria , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?Q?Ond=C5=99ej?= Jirman , linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 0/7] add thermal sensor driver for A64, A83T, H3, H5, H6, R40 Message-ID: <20191224131155.GA17359@Red> References: <20191219172823.1652600-1-anarsoul@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191219172823.1652600-1-anarsoul@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Dec 19, 2019 at 09:28:16AM -0800, Vasily Khoruzhick wrote: > This patchset adds driver for thermal sensor in A64, A83T, H3, H5, > H6 and R40 SoCs. > > v8: > - [vasily] Address more Maxime's comments for dt-schema > - [vasily] Add myself to MAINTAINERS for the driver and schema > - [vasily] Round calibration data size to word boundary for H6 and A64 > - [vasily] Change offset for A64 since it reports too low temp otherwise. > Likely conversion formula in user manual is not correct. > > v7: > - [vasily] Address Maxime's comments for dt-schema > - [vasily] Move common part of H3 and H5 dts into sunxi-h3-h5.dtsi > - [vasily] Add Maxime's a-b to the driver patch > > v6: > - [ondrej, vasily] Squash all driver related changes into a > single patch > - [ondrej] Rename calib -> calibration > - [ondrej] Fix thermal zone registration check > - [ondrej] Lower rate of sensor data interrupts to 4/sec/sensor > - [ondrej] Rework scale/offset values, H6 calibration > - [ondrej] Explicitly set mod clock to 24 MHz > - [ondrej] Set undocumented bits in CTRL0 for H6 > - [ondrej] Add support for A83T > - [ondrej] Add dts changes for A83T, H3, H5, H6 > - [vasily] Add dts changes for A64 > - [vasily] Address Maxime's comments for YAML scheme > - [vasily] Make .calc_temp callback mandatory > - [vasily] Set .max_register in regmap config, so regs can be > inspected using debugfs > > Ondrej Jirman (4): > ARM: dts: sun8i-a83t: Add thermal sensor and thermal zones > ARM: dts: sun8i-h3: Add thermal sensor and thermal zones > arm64: dts: allwinner: h5: Add thermal sensor and thermal zones > arm64: dts: allwinner: h6: Add thermal sensor and thermal zones > > Vasily Khoruzhick (1): > arm64: dts: allwinner: a64: Add thermal sensors and thermal zones > > Yangtao Li (2): > thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40 > dt-bindings: thermal: add YAML schema for sun8i-thermal driver > bindings > > .../thermal/allwinner,sun8i-a83t-ths.yaml | 160 +++++ > MAINTAINERS | 8 + > arch/arm/boot/dts/sun8i-a83t.dtsi | 36 + > arch/arm/boot/dts/sun8i-h3.dtsi | 20 + > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 6 + > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 42 ++ > arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 26 + > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 + > drivers/thermal/Kconfig | 14 + > drivers/thermal/Makefile | 1 + > drivers/thermal/sun8i_thermal.c | 639 ++++++++++++++++++ > 11 files changed, 985 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml > create mode 100644 drivers/thermal/sun8i_thermal.c > > -- > 2.24.1 > Hello Thanks for your work. Tested-by: Corentin Labbe Tested-on: sun50i-h6-pine-h64-model-b Tested-on: sun50i-h6-pine-h64 Tested-on: sun8i-a83t-bananapi-m3 Tested-on: sun8i-h2-plus-orangepi-zero Tested-on: sun8i-h2-plus-orangepi-r1 Tested-on: sun8i-h2-plus-libretech-all-h3-cc Tested-on: sun8i-h3-libretech-all-h3-cc Tested-on: sun50i-h5-libretech-all-h3-cc Tested-on: sun50i-a64-pine64-plus Note that your patch serie support R40 but you do not have any R40 DT patch. If you need testing, do not hesitate to ask. Regards