From: Abel Vesa <abel.vesa@nxp.com>
To: Anson Huang <anson.huang@nxp.com>
Cc: "rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 2/2] cpufreq: imx-cpufreq-dt: Add i.MX8MP support
Date: Thu, 26 Dec 2019 14:04:28 +0000 [thread overview]
Message-ID: <20191226140426.ip2vb6dom5hckenc@fsr-ub1664-175> (raw)
In-Reply-To: <1577343167-16376-2-git-send-email-Anson.Huang@nxp.com>
On 19-12-26 14:52:47, Anson Huang wrote:
> Add i.MX8MP cpufreq DT support for speed grading and market
> segment check.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/cpufreq/imx-cpufreq-dt.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/imx-cpufreq-dt.c b/drivers/cpufreq/imx-cpufreq-dt.c
> index 85a6efd..912e93d 100644
> --- a/drivers/cpufreq/imx-cpufreq-dt.c
> +++ b/drivers/cpufreq/imx-cpufreq-dt.c
> @@ -35,7 +35,7 @@ static int imx_cpufreq_dt_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - if (of_machine_is_compatible("fsl,imx8mn"))
> + if (of_machine_is_compatible("fsl,imx8mn") || of_machine_is_compatible("fsl,imx8mp"))
Is there a way we could do this more generic so we won't have to add
another of_machine_is_compatible if a new imx8m comes around ?
If not, please drop the second one on a new line to follow the 80 chars rule.
Then you can add:
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
> speed_grade = (cell_value & IMX8MN_OCOTP_CFG3_SPEED_GRADE_MASK)
> >> OCOTP_CFG3_SPEED_GRADE_SHIFT;
> else
> @@ -54,7 +54,8 @@ static int imx_cpufreq_dt_probe(struct platform_device *pdev)
> if (of_machine_is_compatible("fsl,imx8mm") ||
> of_machine_is_compatible("fsl,imx8mq"))
> speed_grade = 1;
> - if (of_machine_is_compatible("fsl,imx8mn"))
> + if (of_machine_is_compatible("fsl,imx8mn") ||
> + of_machine_is_compatible("fsl,imx8mp"))
> speed_grade = 0xb;
> }
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-12-26 14:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 6:52 [PATCH 1/2] cpufreq: Use imx-cpufreq-dt for i.MX8MP's speed grading Anson Huang
2019-12-26 6:52 ` [PATCH 2/2] cpufreq: imx-cpufreq-dt: Add i.MX8MP support Anson Huang
2019-12-26 14:04 ` Abel Vesa [this message]
2020-01-06 6:44 ` [PATCH 1/2] cpufreq: Use imx-cpufreq-dt for i.MX8MP's speed grading Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191226140426.ip2vb6dom5hckenc@fsr-ub1664-175 \
--to=abel.vesa@nxp.com \
--cc=anson.huang@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).