From: Samuel Holland <samuel@sholland.org>
To: Chen-Yu Tsai <wens@csie.org>, Sebastian Reichel <sre@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Hans de Goede <hdegoede@redhat.com>,
Oskari Lemmela <oskari@lemmela.net>,
Quentin Schulz <quentin.schulz@bootlin.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@googlegroups.com,
Samuel Holland <samuel@sholland.org>
Subject: [PATCH v2 0/9] X-Powers Power Supply Improvements
Date: Sat, 4 Jan 2020 19:24:07 -0600 [thread overview]
Message-ID: <20200105012416.23296-1-samuel@sholland.org> (raw)
This series adds some improvements to the axp20x* power supply drivers
to better support suspend/resume and use on mobile devices.
The first two patches fix bugs I found while testing the ONLINE control
added in later patches.
Patches 3 and 7 allow userspace to take the power supplies offline.
Patches 4 and 8 allow userspace to control the wakeup behavior.
Patch 9 avoids polling USB VBUS presence when possible. While working on
the RSB driver, I was seeing ~50 transfers per second, while idle and
tracked it down to this VBUS polling (20 reads/second). The polling
often caused the CPU to clock up and back down, which triggered the
remaining transfers (changes to the CPU voltage).
Unfortunately, I don't see a way to avoid the polling when running on
battery (where it matters most), other than to move the polling back to
the USB PHY driver.
Changes since v1:
- Add patches 1-2
- Shift value properly in calls to regmap_update_bits (3, 7)
- Use #ifdef instead of #if to avoid -Wundef warnings (4, 8)
- Poll once after an IRQ, instead of setting power->online in the IRQ (9)
- Poll once on resume, in case the state changed during suspend (9)
Samuel Holland (9):
mfd: axp20x: Mark AXP20X_VBUS_IPSOUT_MGMT as volatile
power: supply: axp20x_ac_power: Fix reporting online status
power: supply: axp20x_ac_power: Allow offlining
power: supply: axp20x_ac_power: Add wakeup control
power: supply: axp20x_usb_power: Remove unused device_node
power: supply: axp20x_usb_power: Use a match structure
power: supply: axp20x_usb_power: Allow offlining
power: supply: axp20x_usb_power: Add wakeup control
power: supply: axp20x_usb_power: Only poll while offline
drivers/mfd/axp20x.c | 2 +-
drivers/power/supply/axp20x_ac_power.c | 131 +++++++++++---
drivers/power/supply/axp20x_usb_power.c | 220 ++++++++++++++++++------
3 files changed, 276 insertions(+), 77 deletions(-)
--
2.23.0
next reply other threads:[~2020-01-05 1:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-05 1:24 Samuel Holland [this message]
2020-01-05 1:24 ` [PATCH v2 1/9] mfd: axp20x: Mark AXP20X_VBUS_IPSOUT_MGMT as volatile Samuel Holland
2020-01-05 10:07 ` Chen-Yu Tsai
2020-01-06 8:36 ` Lee Jones
2020-01-05 1:24 ` [PATCH v2 2/9] power: supply: axp20x_ac_power: Fix reporting online status Samuel Holland
2020-01-05 10:09 ` [linux-sunxi] " Chen-Yu Tsai
2020-01-05 13:00 ` Julian Calaby
2020-01-05 15:27 ` Samuel Holland
2020-01-05 1:24 ` [PATCH v2 3/9] power: supply: axp20x_ac_power: Allow offlining Samuel Holland
2020-01-05 10:11 ` [linux-sunxi] " Chen-Yu Tsai
2020-01-05 1:24 ` [PATCH v2 4/9] power: supply: axp20x_ac_power: Add wakeup control Samuel Holland
2020-01-05 10:24 ` [linux-sunxi] " Chen-Yu Tsai
2020-01-05 10:44 ` Chen-Yu Tsai
2020-01-05 1:24 ` [PATCH v2 5/9] power: supply: axp20x_usb_power: Remove unused device_node Samuel Holland
2020-01-05 10:25 ` Chen-Yu Tsai
2020-01-05 1:24 ` [PATCH v2 6/9] power: supply: axp20x_usb_power: Use a match structure Samuel Holland
2020-01-05 10:34 ` [linux-sunxi] " Chen-Yu Tsai
2020-01-05 17:58 ` Samuel Holland
2020-01-06 2:24 ` Chen-Yu Tsai
2020-01-05 1:24 ` [PATCH v2 7/9] power: supply: axp20x_usb_power: Allow offlining Samuel Holland
2020-01-05 10:40 ` [linux-sunxi] " Chen-Yu Tsai
2020-01-05 17:47 ` Samuel Holland
2020-01-06 2:22 ` Chen-Yu Tsai
2020-01-05 1:24 ` [PATCH v2 8/9] power: supply: axp20x_usb_power: Add wakeup control Samuel Holland
2020-01-05 10:47 ` [linux-sunxi] " Chen-Yu Tsai
2020-01-05 1:24 ` [PATCH v2 9/9] power: supply: axp20x_usb_power: Only poll while offline Samuel Holland
2020-01-06 4:27 ` [linux-sunxi] " Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200105012416.23296-1-samuel@sholland.org \
--to=samuel@sholland.org \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=oskari@lemmela.net \
--cc=quentin.schulz@bootlin.com \
--cc=sre@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).