From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: linux-pm@vger.kernel.org, evgreen@chromium.org,
daidavid1@codeaurora.org, okukatla@codeaurora.org,
jcrouse@codeaurora.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] interconnect: Check for valid path in icc_set_bw()
Date: Mon, 6 Jan 2020 22:15:48 -0800 [thread overview]
Message-ID: <20200107061548.GC716784@yoga> (raw)
In-Reply-To: <20200106172746.19803-1-georgi.djakov@linaro.org>
On Mon 06 Jan 09:27 PST 2020, Georgi Djakov wrote:
> Use IS_ERR() to ensure that the path passed to icc_set_bw() is valid.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
> v2:
> - Use WARN_ON() instead of pr_err() (Bjorn)
>
> drivers/interconnect/core.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
> index 63c164264b73..d2ba5ae7d25b 100644
> --- a/drivers/interconnect/core.c
> +++ b/drivers/interconnect/core.c
> @@ -495,9 +495,12 @@ int icc_set_bw(struct icc_path *path, u32 avg_bw, u32 peak_bw)
> size_t i;
> int ret;
>
> - if (!path || !path->num_nodes)
> + if (!path)
> return 0;
>
> + if (WARN_ON(IS_ERR(path) || !path->num_nodes))
> + return -EINVAL;
> +
> mutex_lock(&icc_lock);
>
> old_avg = path->reqs[0].avg_bw;
prev parent reply other threads:[~2020-01-07 6:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 17:27 [PATCH v2] interconnect: Check for valid path in icc_set_bw() Georgi Djakov
2020-01-06 21:44 ` Evan Green
2020-01-07 6:15 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107061548.GC716784@yoga \
--to=bjorn.andersson@linaro.org \
--cc=daidavid1@codeaurora.org \
--cc=evgreen@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=jcrouse@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=okukatla@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).