From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Colin King <colin.king@canonical.com>
Cc: Yauhen Kharuzhy <jekhor@gmail.com>,
linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] power: supply: bq25890_charger: fix incorrect error return when bq25890_field_read fails
Date: Thu, 16 Jan 2020 20:38:21 +0100 [thread overview]
Message-ID: <20200116193821.eahey33llmtmahhj@earth.universe> (raw)
In-Reply-To: <20200116170900.86548-1-colin.king@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]
Hi Colin,
Thanks, queued.
-- Sebastian
On Thu, Jan 16, 2020 at 05:09:00PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently a read failure by bq25890_field_read on F_DEV_REV is returning
> an error in id instead of rev. Fix this by returning the value in rev.
>
> Addresses-Coverity: ("Copy-paste error")
> Fixes: d20267c9a98e ("power: supply: bq25890_charger: Add support of BQ25892 and BQ25896 chips")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/power/supply/bq25890_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c
> index 785dbc6307b0..aebd1253dbc9 100644
> --- a/drivers/power/supply/bq25890_charger.c
> +++ b/drivers/power/supply/bq25890_charger.c
> @@ -765,7 +765,7 @@ static int bq25890_get_chip_version(struct bq25890_device *bq)
> rev = bq25890_field_read(bq, F_DEV_REV);
> if (rev < 0) {
> dev_err(bq->dev, "Cannot read chip revision.\n");
> - return id;
> + return rev;
> }
>
> switch (id) {
> --
> 2.24.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-01-16 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 17:09 [PATCH][next] power: supply: bq25890_charger: fix incorrect error return when bq25890_field_read fails Colin King
2020-01-16 19:38 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116193821.eahey33llmtmahhj@earth.universe \
--to=sebastian.reichel@collabora.com \
--cc=colin.king@canonical.com \
--cc=jekhor@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).