From: Sebastian Reichel <sre@kernel.org>
To: Baolin Wang <baolin.wang7@gmail.com>
Cc: orsonzhai@gmail.com, zhang.lyra@gmail.com, saravanak@google.com,
kernel-team@android.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] power: supply: Allow charger manager can be built as a module
Date: Fri, 6 Mar 2020 21:47:12 +0100 [thread overview]
Message-ID: <20200306204712.dgomi52jzyakylky@earth.universe> (raw)
In-Reply-To: <5e098be25c70e07c37e743f84a901f6f756090e0.1583461755.git.baolin.wang7@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1518 bytes --]
Hi,
On Fri, Mar 06, 2020 at 10:34:10AM +0800, Baolin Wang wrote:
> Allow charger manager can be built as a module like other charger
> drivers.
>
> Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
> ---
Thanks, queued. I do not like this driver, but its the best we have
at the moment.
-- Sebastian
> Changes from v1:
> - Use IS_ENABLED() instead.
> ---
> drivers/power/supply/Kconfig | 2 +-
> include/linux/power/charger-manager.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index 9a5591a..195bc04 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -480,7 +480,7 @@ config CHARGER_GPIO
> called gpio-charger.
>
> config CHARGER_MANAGER
> - bool "Battery charger manager for multiple chargers"
> + tristate "Battery charger manager for multiple chargers"
> depends on REGULATOR
> select EXTCON
> help
> diff --git a/include/linux/power/charger-manager.h b/include/linux/power/charger-manager.h
> index ad19e68..ae94dce 100644
> --- a/include/linux/power/charger-manager.h
> +++ b/include/linux/power/charger-manager.h
> @@ -248,7 +248,7 @@ struct charger_manager {
> u64 charging_end_time;
> };
>
> -#ifdef CONFIG_CHARGER_MANAGER
> +#if IS_ENABLED(CONFIG_CHARGER_MANAGER)
> extern void cm_notify_event(struct power_supply *psy,
> enum cm_event_types type, char *msg);
> #else
> --
> 1.9.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-03-06 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 2:34 [PATCH v2] power: supply: Allow charger manager can be built as a module Baolin Wang
2020-03-06 20:47 ` Sebastian Reichel [this message]
2020-03-09 3:20 ` Baolin Wang
2020-03-11 22:18 ` Sebastian Reichel
2020-03-12 2:35 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306204712.dgomi52jzyakylky@earth.universe \
--to=sre@kernel.org \
--cc=baolin.wang7@gmail.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=saravanak@google.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).