From: Rob Herring <robh@kernel.org>
To: Sergey.Semin@baikalelectronics.ru
Cc: Sebastian Reichel <sre@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Serge Semin <fancer.lancer@gmail.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Paul Burton <paulburton@kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] dt-bindings: power: reset: Add regmap support to the SYSCON reboot-mode bindings
Date: Thu, 12 Mar 2020 16:14:38 -0500 [thread overview]
Message-ID: <20200312211438.GA21883@bogus> (raw)
In-Reply-To: <20200306130402.1F4F0803079F@mail.baikalelectronics.ru>
On Fri, Mar 06, 2020 at 04:03:40PM +0300, Sergey.Semin@baikalelectronics.ru wrote:
> From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> Optional regmap property will be used to refer to a syscon-controller
> having a reboot tolerant register mapped.
NAK. It should simply be a child node of the 'syscon-controller'.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Paul Burton <paulburton@kernel.org>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> ---
> .../bindings/power/reset/syscon-reboot-mode.yaml | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml
> index e09bb07b1abb..f47bf52ad983 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml
> @@ -13,9 +13,8 @@ description: |
> This driver gets reboot mode magic value from reboot-mode driver
> and stores it in a SYSCON mapped register. Then the bootloader
> can read it and take different action according to the magic
> - value stored. The SYSCON mapped register is retrieved from the
> - parental dt-node plus the offset. So the SYSCON reboot-mode node
> - should be represented as a sub-node of a "syscon", "simple-mfd" node.
> + value stored. The SYSCON mapped register is retrieved either from
> + the parental dt-node or from a regmap phandle plus the offset.
>
> properties:
> compatible:
> @@ -29,6 +28,10 @@ properties:
> $ref: /schemas/types.yaml#/definitions/uint32
> description: Offset in the register map for the mode register (in bytes).
>
> + regmap:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Phandle to the register map node.
> +
> patternProperties:
> "^mode-.+":
> $ref: /schemas/types.yaml#/definitions/uint32
> --
> 2.25.1
>
next prev parent reply other threads:[~2020-03-12 21:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200306130341.9585-1-Sergey.Semin@baikalelectronics.ru>
2020-03-06 13:03 ` [PATCH 2/4] dt-bindings: power: reset: Replace SYSCON reboot-mode legacy bindings with YAML-based one Sergey.Semin
2020-03-06 19:56 ` Sebastian Reichel
[not found] ` <20200306200551.49C47803087C@mail.baikalelectronics.ru>
2020-03-11 20:47 ` Sergey Semin
2020-03-12 21:12 ` Rob Herring
2020-03-06 13:03 ` [PATCH 3/4] dt-bindings: power: reset: Add regmap support to the SYSCON reboot-mode bindings Sergey.Semin
2020-03-06 19:57 ` Sebastian Reichel
2020-03-12 21:14 ` Rob Herring [this message]
2020-03-13 13:02 ` Sergey Semin
2020-03-14 18:04 ` Sebastian Reichel
2020-03-18 23:14 ` Rob Herring
2020-03-31 19:50 ` Sergey Semin
2020-04-16 19:56 ` Sergey Semin
2020-04-16 21:28 ` Rob Herring
2020-04-17 7:45 ` Sergey Semin
2020-03-06 13:03 ` [PATCH 4/4] power: reset: syscon-reboot-mode: Add regmap dts-property support Sergey.Semin
2020-03-06 19:57 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312211438.GA21883@bogus \
--to=robh@kernel.org \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=sre@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).