From: Lee Jones <lee.jones@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Brian Masney <masneyb@onstation.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Guillaume La Roque <glaroque@baylibre.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Jonathan Cameron <jic23@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Michael Hennerich <michael.hennerich@analog.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Stephen Boyd <sboyd@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Zhang Rui <rui.zhang@intel.com>,
dri-devel@lists.freedesktop.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org,
linux-media@vger.kernel.org, linux-pm@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 4/4] dt-bindings: Add missing 'additionalProperties: false'
Date: Fri, 27 Mar 2020 08:31:57 +0000 [thread overview]
Message-ID: <20200327083157.GI603801@dell> (raw)
In-Reply-To: <20200325220542.19189-5-robh@kernel.org>
On Wed, 25 Mar 2020, Rob Herring wrote:
> Setting 'additionalProperties: false' is frequently omitted, but is
> important in order to check that there aren't extra undocumented
> properties in a binding.
>
> Ideally, we'd just add this automatically and make this the default, but
> there's some cases where it doesn't work. For example, if a common
> schema is referenced, then properties in the common schema aren't part
> of what's considered for 'additionalProperties'. Also, sometimes there
> are bus specific properties such as 'spi-max-frequency' that go into
> bus child nodes, but aren't defined in the child node's schema.
>
> So let's stick with the json-schema defined default and add
> 'additionalProperties: false' where needed. This will be a continual
> review comment and game of wack-a-mole.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/arm/altera/socfpga-clk-manager.yaml | 2 ++
> .../bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml | 2 ++
> Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml | 2 ++
> Documentation/devicetree/bindings/arm/renesas,prr.yaml | 2 ++
> .../devicetree/bindings/arm/samsung/exynos-chipid.yaml | 2 ++
> Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 2 ++
> .../bindings/arm/samsung/samsung-secure-firmware.yaml | 2 ++
> .../devicetree/bindings/arm/stm32/st,stm32-syscon.yaml | 2 ++
> Documentation/devicetree/bindings/clock/fsl,plldig.yaml | 2 ++
> Documentation/devicetree/bindings/clock/imx8mn-clock.yaml | 2 ++
> Documentation/devicetree/bindings/clock/imx8mp-clock.yaml | 2 ++
> Documentation/devicetree/bindings/clock/milbeaut-clock.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,gcc-ipq8074.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,gcc-msm8996.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,gcc-msm8998.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,gcc-qcs404.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,gcc-sc7180.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,gcc-sm8150.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,gcc.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,mmcc.yaml | 2 ++
> .../devicetree/bindings/clock/qcom,msm8998-gpucc.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml | 2 ++
> .../devicetree/bindings/clock/qcom,sc7180-dispcc.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,sc7180-gpucc.yaml | 2 ++
> .../devicetree/bindings/clock/qcom,sc7180-videocc.yaml | 2 ++
> .../devicetree/bindings/clock/qcom,sdm845-dispcc.yaml | 2 ++
> Documentation/devicetree/bindings/clock/qcom,sdm845-gpucc.yaml | 2 ++
> .../devicetree/bindings/clock/qcom,sdm845-videocc.yaml | 2 ++
> .../devicetree/bindings/display/amlogic,meson-vpu.yaml | 2 ++
> .../devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml | 2 ++
> Documentation/devicetree/bindings/dsp/fsl,dsp.yaml | 2 ++
> Documentation/devicetree/bindings/eeprom/at24.yaml | 2 ++
> .../firmware/intel,ixp4xx-network-processing-engine.yaml | 3 +++
> .../devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml | 2 ++
> .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml | 2 ++
> Documentation/devicetree/bindings/gpio/xylon,logicvc-gpio.yaml | 2 ++
> Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 2 ++
> Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 2 ++
> Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml | 2 ++
> Documentation/devicetree/bindings/gpu/samsung-rotator.yaml | 2 ++
> Documentation/devicetree/bindings/hwmon/adi,adm1177.yaml | 2 ++
> Documentation/devicetree/bindings/hwmon/adi,ltc2947.yaml | 2 ++
> Documentation/devicetree/bindings/hwmon/pmbus/ti,ucd90320.yaml | 2 ++
> Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml | 2 ++
> Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml | 2 ++
> Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml | 2 ++
> Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml | 2 ++
> Documentation/devicetree/bindings/iio/adc/lltc,ltc2496.yaml | 2 ++
> .../devicetree/bindings/iio/adc/microchip,mcp3911.yaml | 2 ++
> .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 2 ++
> .../devicetree/bindings/iio/chemical/plantower,pms7003.yaml | 2 ++
> .../devicetree/bindings/iio/chemical/sensirion,sps30.yaml | 2 ++
> Documentation/devicetree/bindings/iio/dac/lltc,ltc1660.yaml | 2 ++
> Documentation/devicetree/bindings/iio/light/adux1020.yaml | 2 ++
> Documentation/devicetree/bindings/iio/light/bh1750.yaml | 2 ++
> Documentation/devicetree/bindings/iio/light/isl29018.yaml | 2 ++
> Documentation/devicetree/bindings/iio/light/noa1305.yaml | 2 ++
> Documentation/devicetree/bindings/iio/light/stk33xx.yaml | 2 ++
> Documentation/devicetree/bindings/iio/light/tsl2583.yaml | 2 ++
> Documentation/devicetree/bindings/iio/light/tsl2772.yaml | 2 ++
> Documentation/devicetree/bindings/iio/light/veml6030.yaml | 2 ++
> .../devicetree/bindings/iio/pressure/asc,dlhl60d.yaml | 2 ++
> Documentation/devicetree/bindings/iio/pressure/bmp085.yaml | 2 ++
> .../devicetree/bindings/iio/proximity/devantech-srf04.yaml | 2 ++
> .../devicetree/bindings/iio/proximity/parallax-ping.yaml | 2 ++
> .../devicetree/bindings/iio/temperature/adi,ltc2983.yaml | 2 ++
> Documentation/devicetree/bindings/input/gpio-vibrator.yaml | 2 ++
> Documentation/devicetree/bindings/input/max77650-onkey.yaml | 3 +++
> .../bindings/interrupt-controller/intel,ixp4xx-interrupt.yaml | 2 ++
> Documentation/devicetree/bindings/iommu/samsung,sysmmu.yaml | 2 ++
> Documentation/devicetree/bindings/leds/leds-max77650.yaml | 3 +++
> Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml | 3 +++
> .../devicetree/bindings/mailbox/amlogic,meson-gxbb-mhu.yaml | 2 ++
> Documentation/devicetree/bindings/media/amlogic,gx-vdec.yaml | 2 ++
> .../devicetree/bindings/media/amlogic,meson-gx-ao-cec.yaml | 2 ++
> Documentation/devicetree/bindings/media/renesas,ceu.yaml | 2 ++
> Documentation/devicetree/bindings/mfd/max77650.yaml | 2 ++
> Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml | 2 ++
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-03-27 8:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 22:05 [PATCH 0/4] dt-bindings: additionalProperties clean-up Rob Herring
2020-03-25 22:05 ` [PATCH 1/4] dt-bindings: iio/accel: Drop duplicate adi,adxl345/6 from trivial-devices.yaml Rob Herring
2020-03-26 7:57 ` Ardelean, Alexandru
2020-03-27 20:21 ` [PATCH 1/4] dt-bindings: iio/accel: Drop duplicate adi, adxl345/6 " Sam Ravnborg
2020-03-31 14:48 ` Rob Herring
2020-03-25 22:05 ` [PATCH 2/4] dt-bindings: sram: qcom: Clean-up 'ranges' and child node names Rob Herring
2020-03-25 23:34 ` Brian Masney
2020-03-25 22:05 ` [PATCH 3/4] dt-bindings: Clean-up schema errors due to missing 'addtionalProperties: false' Rob Herring
2020-03-26 7:58 ` Ardelean, Alexandru
2020-03-26 8:39 ` Neil Armstrong
2020-03-26 12:45 ` Jonathan Cameron
2020-03-27 8:32 ` Lee Jones
2020-03-27 9:59 ` Linus Walleij
2020-03-30 7:10 ` Masahiro Yamada
2020-03-25 22:05 ` [PATCH 4/4] dt-bindings: Add missing 'additionalProperties: false' Rob Herring
2020-03-25 22:07 ` Mark Brown
2020-03-26 8:07 ` Ardelean, Alexandru
2020-03-26 8:37 ` Neil Armstrong
2020-03-26 12:47 ` Jonathan Cameron
2020-03-26 13:27 ` Benjamin Gaignard
2020-03-27 8:31 ` Lee Jones [this message]
2020-03-30 7:09 ` Masahiro Yamada
2020-03-30 8:37 ` Masahiro Yamada
2020-03-31 14:39 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327083157.GI603801@dell \
--to=lee.jones@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=glaroque@baylibre.com \
--cc=jic23@kernel.org \
--cc=khilman@baylibre.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=mchehab@kernel.org \
--cc=michael.hennerich@analog.com \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).