From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Saravanan Sekar <sravanhome@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Sebastian Reichel <sre@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v4 3/5] iio: adc: mp2629: Add support for mp2629 ADC driver
Date: Sat, 28 Mar 2020 14:42:34 +0000 [thread overview]
Message-ID: <20200328144234.081b964f@archlinux> (raw)
In-Reply-To: <CAHp75VfauHuAv1Wr=7ga=G+6JOYXuop_oyXiwmQgKeB2e_z=tQ@mail.gmail.com>
On Mon, 23 Mar 2020 01:32:34 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Mon, Mar 23, 2020 at 12:47 AM Saravanan Sekar <sravanhome@gmail.com> wrote:
> >
> > Add support for 8-bit resolution ADC readings for input power
> > supply and battery charging measurement. Provides voltage, current
> > readings to mp2629 power supply driver.
>
> ...
>
> > +#include <linux/platform_device.h>
>
> > +#include <linux/of_device.h>
>
> Don't see users of it.
>
> > +#include <linux/module.h>
> > +#include <linux/mutex.h>
> > +#include <linux/regulator/consumer.h>
>
> > +#include <linux/sysfs.h>
>
> Any users?
>
> > +#include <linux/regmap.h>
>
> Perhaps ordered?
>
> > +#include <linux/iio/iio.h>
> > +#include <linux/iio/machine.h>
> > +#include <linux/iio/driver.h>
>
> + blank line?
>
> > +#include <linux/mfd/mp2629.h>
>
> ...
>
> > +static int mp2629_read_raw(struct iio_dev *indio_dev,
> > + struct iio_chan_spec const *chan,
> > + int *val, int *val2, long mask)
> > +{
> > + struct mp2629_adc *info = iio_priv(indio_dev);
> > + unsigned int rval;
> > + int ret;
> > +
> > + switch (mask) {
> > + case IIO_CHAN_INFO_RAW:
> > + ret = regmap_read(info->regmap, chan->address, &rval);
> > + if (ret < 0)
> > + return ret;
> > +
> > + if (chan->address == MP2629_INPUT_VOLT)
>
> > + rval &= 0x7f;
>
> GENMASK() ?
>
> > + *val = rval;
> > + return IIO_VAL_INT;
>
> > + return 0;
> > +}
>
> ...
>
> > + void **pdata = pdev->dev.platform_data;
>
> Same Qs as per other patch.
>
> ...
>
> > + indio_dev->dev.of_node = pdev->dev.of_node;
>
> Jonathan, doesn't IIO core do this for all?
>
Nope. I'm not totally sure it's always safe to do so
as we have some weird parent structures in some cases.
A quick grep suggests that we may be fine though, or
alternatively be able to get away with a set it if not
already set approach.
I'll take a look when I get some time. It would be nice
to clean this up.
Jonathan
next prev parent reply other threads:[~2020-03-28 14:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 22:46 [PATCH v4 0/5] Add battery charger driver support for MP2629 Saravanan Sekar
2020-03-22 22:46 ` [PATCH v4 1/5] dt-bindings: mfd: add document bindings for mp2629 Saravanan Sekar
2020-03-27 8:00 ` Lee Jones
2020-03-27 21:50 ` saravanan sekar
2020-03-30 6:46 ` Lee Jones
2020-04-07 16:29 ` saravanan sekar
2020-04-08 10:15 ` Lee Jones
2020-03-22 22:46 ` [PATCH v4 2/5] mfd: mp2629: Add support for mps battery charger Saravanan Sekar
2020-03-27 7:55 ` Lee Jones
2020-03-27 8:32 ` saravanan sekar
2020-03-27 10:22 ` Lee Jones
2020-03-27 10:56 ` saravanan sekar
2020-03-27 11:25 ` Lee Jones
2020-03-27 12:40 ` saravanan sekar
2020-03-27 12:56 ` Andy Shevchenko
2020-03-27 13:03 ` saravanan sekar
2020-03-27 13:17 ` Andy Shevchenko
2020-03-28 14:36 ` Jonathan Cameron
2020-03-22 22:46 ` [PATCH v4 3/5] iio: adc: mp2629: Add support for mp2629 ADC driver Saravanan Sekar
2020-03-22 23:32 ` Andy Shevchenko
2020-03-28 14:42 ` Jonathan Cameron [this message]
2020-03-28 18:50 ` Andy Shevchenko
2020-03-29 10:37 ` saravanan sekar
2020-03-29 11:09 ` Andy Shevchenko
2020-03-22 22:46 ` [PATCH v4 4/5] power: supply: Add support for mps mp2629 battery charger Saravanan Sekar
2020-03-22 23:26 ` Andy Shevchenko
2020-03-23 12:29 ` saravanan sekar
2020-03-22 22:46 ` [PATCH v4 5/5] MAINTAINERS: Add entry for mp2629 Battery Charger driver Saravanan Sekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200328144234.081b964f@archlinux \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=sravanhome@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).