From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96978C2BABC for ; Tue, 7 Apr 2020 08:29:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B29120748 for ; Tue, 7 Apr 2020 08:29:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YF7pfVtn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725817AbgDGI3e (ORCPT ); Tue, 7 Apr 2020 04:29:34 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:34352 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726725AbgDGI3d (ORCPT ); Tue, 7 Apr 2020 04:29:33 -0400 Received: by mail-pl1-f196.google.com with SMTP id a23so972410plm.1 for ; Tue, 07 Apr 2020 01:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4R/FPBL4dOo4mvZ9ReJ8CLxavGglB5XXnfcP3bpIQMU=; b=YF7pfVtnVNormD+6w1FhUmCCmIPX8WylGW+gMb6fcDVCwxbjNpGspR80BZhFu81/wC 9mGnJKwUU3jjI6aV9mcWfz9QHoD3N9j+t3t7uW1fJfq3k9+V6vPBnljs+ugaNxvH2oM3 4fBcqqWsKDX8Vg/5/IVAXwf+8dlGNtHJhTMLogSVr30vlUXOSwvnl5PxBYoUdlZqZHZz 8hYl4Zqcu6CNjvxU0x9amIs54FLIYOip55tk5JBJ+2Pi1ijg3lhIm+XWqxUIXtIsl/Gu 3Y8xRbNRGLHZTKZBmWLyUyWGcwSuRyW6xDHlEgTIVdhWpg0gMdR1bVdSlt0FgGwI1rX+ myNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4R/FPBL4dOo4mvZ9ReJ8CLxavGglB5XXnfcP3bpIQMU=; b=UNzorxsF9UpSUsmnfgqBBJvgfGuehWo2pAlcD12RpqiG82HQ3evlGBDCFCSNuukkxI VTyCmM2ENM9SeNtmG4QSiaHzE7g/jcGqRzpLU+B3LFleyJBBTcjoHwhknP5vigIiMCO6 R8fHOb02+f+5cKuMg0YQQDRecWlhtKc6EBOBFjM7vqvGcMts8+HBCAiH2YDBYeU0dcle Jg1PYvYXx+dYQaAl51BM2EUp+V1EADHs7bHWCukA3Zr4QcZutb04xxvBdfK+E6TFW1S4 ov98/BwbQNercARZZ3DmNzUYp1AYQNi8uzGY+bq8gzG4XiuWyWYDqf82BK2MLG1e1yzl aeXQ== X-Gm-Message-State: AGi0PuawgEb7UTnTUTe6MrS/on9EUGOIZAGm38a7ghHmTmvThUMSt9P9 tnaBewnxj10Fh2U8MHzmr4OAgQ== X-Google-Smtp-Source: APiQypIcnVfCrjU/SQx6rFcAG9MOEb1k60YQzwaCjM39FmAU4PrzS6vHLapoN/BLX9AQQ8GBXTqLpw== X-Received: by 2002:a17:902:b489:: with SMTP id y9mr1436701plr.144.1586248171653; Tue, 07 Apr 2020 01:29:31 -0700 (PDT) Received: from localhost ([122.171.118.46]) by smtp.gmail.com with ESMTPSA id np4sm989176pjb.48.2020.04.07.01.29.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Apr 2020 01:29:30 -0700 (PDT) Date: Tue, 7 Apr 2020 13:59:28 +0530 From: Viresh Kumar To: "andrew-sh.cheng" Cc: Mark Rutland , Nishanth Menon , srv_heupstream , "linux-pm@vger.kernel.org" , Stephen Boyd , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Rob Herring , Chanwoo Choi , Kyungmin Park , MyungJoo Ham , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , Matthias Brugger , Fan Chen =?utf-8?B?KOmZs+WHoSk=?= , "devicetree@vger.kernel.org" Subject: Re: [v5, PATCH 4/5] cpufreq: mediatek: add opp notification for SVS support Message-ID: <20200407082928.lancywbqts5yg4ks@vireshk-i7> References: <20191127083619.etocnhpyyut3hzwq@vireshk-i7> <1575874588.13494.4.camel@mtksdaap41> <20191210064319.f4ksrxozp3gv4xry@vireshk-i7> <1583827865.4840.1.camel@mtksdaap41> <20200311060616.62nh7sfwtjwvrjfr@vireshk-i7> <1584084154.7753.3.camel@mtksdaap41> <20200313091038.q7q7exiowoah4nk4@vireshk-i7> <1586164366.5015.6.camel@mtksdaap41> <20200406092945.d5thcd2h3bo7mn45@vireshk-i7> <1586242489.10019.1.camel@mtksdaap41> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1586242489.10019.1.camel@mtksdaap41> User-Agent: NeoMutt/20180716-391-311a52 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 07-04-20, 14:54, andrew-sh.cheng wrote: > On Mon, 2020-04-06 at 14:59 +0530, Viresh Kumar wrote: > > On 06-04-20, 17:12, andrew-sh.cheng wrote: > > > I will use regulator in the locked region. > > > And regulator will use mutex_lock. > > > > Yeah, you can't use spinlock here, use a mutex. > > > Hi Viresh, > > I am not familiar with read/write lock. > Do you mean there is another read/write function, which is not > read_lock()/write_lock(), using mutex but not spinlock? Heh, I am asking you to use simple mutex here, leave the read/write lock thing completely as it won't work here. -- viresh