From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8AB3C2BA19 for ; Tue, 14 Apr 2020 16:27:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90E372075E for ; Tue, 14 Apr 2020 16:27:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="so3gP1Rl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391534AbgDNQ1A (ORCPT ); Tue, 14 Apr 2020 12:27:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2391532AbgDNQ0z (ORCPT ); Tue, 14 Apr 2020 12:26:55 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26392C061A0E for ; Tue, 14 Apr 2020 09:26:55 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id r26so14766514wmh.0 for ; Tue, 14 Apr 2020 09:26:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=/VXMLsnEdFtu7k13O3hijxHV9EAnp9rCBMScPJUvt8E=; b=so3gP1RlA1DMJNkabV9BVJKpPKhVefRrd749cpbQsMSUw9vEy2MT2snTkC0Iccc76H AzVizRJ5FKnqt7TeKCsOnDj9RS9cHfRtLwvxTLsJ3j7Lh16aDRNKcmt0mNc1DzdBZSqy Zktggq0zEqSoHYB4NUkTRUEMUGhz1MrfEX5ZBpfK9llw0545J4uoaF9JNWsCZkWYs9D1 Ak+pbPikFBBvTaMdnLuT1RXbOmREnoEcyCY2TcbfIqoTetk1iedUrw6ag9Tc0Pm9rQY1 Zcns8E/zxoM/7klSmWX6+o9Pj7vsFb+xz4RXO26dYkdeObLmqvSaXGn4z45wigjJgU0j d/uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=/VXMLsnEdFtu7k13O3hijxHV9EAnp9rCBMScPJUvt8E=; b=r6GW66uIhb7Y0dJ4lWKKdRlwbRYEBccDXnHRXsaEkTrTNHVXk7K/+sIktLhFRl92Le oQA1z6Pv9BRlylZwKjYM0uyOKCq5hk0iImojQsPazEtxSNiGIPQ9lWwuORaxCZ+MdJ1g 0SYxhPEyGvwAll5auglAPmUNVW2ITDUU6o8tGucF7y5hVFUHUosmJHh1B80gSYnKxlBL A2xhJMyboJAYEYxX4yvFVSUB1sohkOVjVcZeNdndwgjMPq+SaOqN+LfdTHglGLvVd/Io CBgYoMl8H32lIqJlNXf8HOnTSFgyUxxeEaspWC7QYRa+XMzK1d79VLokrl6ukgchqC9Y mjng== X-Gm-Message-State: AGi0Puakha4dLJq5L/t9tc0rwLMKnHEJNmaNcXTR6mDaMxBrrGngQBRK L/6tlsR89pB+xdtR2RXYHtiIAQ== X-Google-Smtp-Source: APiQypLZSqAKnKa8/7bmUDaBawS19DxuB4c+NUiF7UJsB8UNeKpicbm4VpGHB77i6kzhldKm0rxM1Q== X-Received: by 2002:a05:600c:414b:: with SMTP id h11mr639225wmm.9.1586881613656; Tue, 14 Apr 2020 09:26:53 -0700 (PDT) Received: from localhost.localdomain (lns-bzn-59-82-252-135-148.adsl.proxad.net. [82.252.135.148]) by smtp.gmail.com with ESMTPSA id s14sm20199388wme.33.2020.04.14.09.26.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 09:26:53 -0700 (PDT) From: Daniel Lezcano To: daniel.lezcano@linaro.org, rui.zhang@intel.com Cc: amit.kucheria@verdurent.com, "Rafael J. Wysocki" , "Rafael J. Wysocki" , linux-pm@vger.kernel.org (open list:POWER MANAGEMENT CORE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 1/4] powercap/drivers/idle_inject: Specify idle state max latency Date: Tue, 14 Apr 2020 18:26:26 +0200 Message-Id: <20200414162634.1867-1-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Currently the idle injection framework uses the play_idle() function which puts the current CPU in an idle state. The idle state is the deepest one, as specified by the latency constraint when calling the subsequent play_idle_precise() function with the INT_MAX. The idle_injection is used by the cpuidle_cooling device which computes the idle / run duration to mitigate the temperature by injecting idle cycles. The cooling device has no control on the depth of the idle state. Allow finer control of the idle injection mechanism by allowing to specify the latency for the idle state. Thus the cooling device has the ability to have a guarantee on the exit latency of the idle states it is injecting. Acked-by: Rafael J. Wysocki Signed-off-by: Daniel Lezcano --- drivers/powercap/idle_inject.c | 16 +++++++++++++++- include/linux/idle_inject.h | 4 ++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/powercap/idle_inject.c b/drivers/powercap/idle_inject.c index cd1270614cc6..49f42c475620 100644 --- a/drivers/powercap/idle_inject.c +++ b/drivers/powercap/idle_inject.c @@ -61,12 +61,14 @@ struct idle_inject_thread { * @timer: idle injection period timer * @idle_duration_us: duration of CPU idle time to inject * @run_duration_us: duration of CPU run time to allow + * @latency_us: max allowed latency * @cpumask: mask of CPUs affected by idle injection */ struct idle_inject_device { struct hrtimer timer; unsigned int idle_duration_us; unsigned int run_duration_us; + unsigned int latency_us; unsigned long int cpumask[0]; }; @@ -138,7 +140,8 @@ static void idle_inject_fn(unsigned int cpu) */ iit->should_run = 0; - play_idle(READ_ONCE(ii_dev->idle_duration_us)); + play_idle_precise(READ_ONCE(ii_dev->idle_duration_us) * NSEC_PER_USEC, + READ_ONCE(ii_dev->latency_us) * NSEC_PER_USEC); } /** @@ -169,6 +172,16 @@ void idle_inject_get_duration(struct idle_inject_device *ii_dev, *idle_duration_us = READ_ONCE(ii_dev->idle_duration_us); } +/** + * idle_inject_set_latency - set the maximum latency allowed + * @latency_us: set the latency requirement for the idle state + */ +void idle_inject_set_latency(struct idle_inject_device *ii_dev, + unsigned int latency_us) +{ + WRITE_ONCE(ii_dev->latency_us, latency_us); +} + /** * idle_inject_start - start idle injections * @ii_dev: idle injection control device structure @@ -297,6 +310,7 @@ struct idle_inject_device *idle_inject_register(struct cpumask *cpumask) cpumask_copy(to_cpumask(ii_dev->cpumask), cpumask); hrtimer_init(&ii_dev->timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL); ii_dev->timer.function = idle_inject_timer_fn; + ii_dev->latency_us = UINT_MAX; for_each_cpu(cpu, to_cpumask(ii_dev->cpumask)) { diff --git a/include/linux/idle_inject.h b/include/linux/idle_inject.h index a445cd1a36c5..91a8612b8bf9 100644 --- a/include/linux/idle_inject.h +++ b/include/linux/idle_inject.h @@ -26,4 +26,8 @@ void idle_inject_set_duration(struct idle_inject_device *ii_dev, void idle_inject_get_duration(struct idle_inject_device *ii_dev, unsigned int *run_duration_us, unsigned int *idle_duration_us); + +void idle_inject_set_latency(struct idle_inject_device *ii_dev, + unsigned int latency_ns); + #endif /* __IDLE_INJECT_H__ */ -- 2.17.1