From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 879B1C2BA19 for ; Tue, 14 Apr 2020 16:27:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 578B62076D for ; Tue, 14 Apr 2020 16:27:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bDBtwzIu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391547AbgDNQ1G (ORCPT ); Tue, 14 Apr 2020 12:27:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2391539AbgDNQ1B (ORCPT ); Tue, 14 Apr 2020 12:27:01 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1F1DC061A0E for ; Tue, 14 Apr 2020 09:27:00 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id b11so3685174wrs.6 for ; Tue, 14 Apr 2020 09:27:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0wQPQbGJht3YZ6tPmD0dkDDmaWW0wAJqmi6Tnr9hkAw=; b=bDBtwzIuoe6MdAuz3KzfVxZnPwT5XFqFzDm/WBlEgZqbtIz/0eMWVl1IEtvF+SX4u7 bOUd32MFJoiaeHeJMjvfkizW5cbY9ttlTlfLEstOq5lIbnlvjl6PUZRObebP6jq1huzF EIFbmLR2B07haz5Iy2HvGAEhbtoEqenH0oiSxyswANNx+JxZi4n19d5jZh5Td5szib2v KzOMsw21/8ZAwLVQYZLw1sBI5Be7gXSZXup7OzRc+OMJnW/vM/rDekONXaxfNaR0q+1A rO73rjBbEQ1wmaBZEYcIpwBBIfo1L/ntx5BOJbAU/bJLzB1s8YWZ1Z/RbIg7540DQbgv WgOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=0wQPQbGJht3YZ6tPmD0dkDDmaWW0wAJqmi6Tnr9hkAw=; b=IZyYh3Mcr0SIbaqFpKf6ctocUIiPRwM3pRsCnNGd61S9Ze0JrkKeiohDNXhtVdG9q1 VzYX29NcpwO3kmGf/CyoG+7A6RuFwTh/M5Tvo+CX+qIBPvSD3Z4qgyRJ09JMYYFZHGUL CDc5jytmzCjxF9MMCyYTr97EI0DI3+OfcqwkIH88wbVn11fPTslUsHQQ3P2ceRdKiSui HgwoaW6KAN+oI5VXkrGQlJZ2loJsuduRYOc63ENsBfdWhXJsNyxEeDwGdWiJ/Rb5AUeA RqVfWvkqlMBWi6o6HpjxHZmOZAcN+vJwrdMo6k2jt8JX2gbJTcdUHTp0HeppR0yMV1i7 3U3Q== X-Gm-Message-State: AGi0Pub6ATLjbInFazhC058akQlghpCtjyt9cqRLVvDcr61eIrNSV8hG +V1nz+dZQhgn3DjVN+C7vjCubw== X-Google-Smtp-Source: APiQypKzi3XRg0iM08BIyraPnmuefAZkEulO/7MjOJSM29InbTaH2umsng4ZbJ1T7p44f9s3PqL58A== X-Received: by 2002:a5d:634d:: with SMTP id b13mr14371200wrw.353.1586881619204; Tue, 14 Apr 2020 09:26:59 -0700 (PDT) Received: from localhost.localdomain (lns-bzn-59-82-252-135-148.adsl.proxad.net. [82.252.135.148]) by smtp.gmail.com with ESMTPSA id s14sm20199388wme.33.2020.04.14.09.26.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 09:26:58 -0700 (PDT) From: Daniel Lezcano To: daniel.lezcano@linaro.org, rui.zhang@intel.com Cc: amit.kucheria@verdurent.com, Rob Herring , Mark Rutland , linux-pm@vger.kernel.org (open list:THERMAL), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 2/4] dt-bindings: thermal: Add the idle cooling device Date: Tue, 14 Apr 2020 18:26:27 +0200 Message-Id: <20200414162634.1867-2-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200414162634.1867-1-daniel.lezcano@linaro.org> References: <20200414162634.1867-1-daniel.lezcano@linaro.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Some devices are not able to cool down by reducing their voltage / frequency because it could be not available or the system does not allow voltage scaling. In this configuration, it is not possible to use this strategy and the idle injection cooling device can be used instead. One idle cooling device is now present for the CPU as implemented by the combination of the idle injection framework belonging to the power capping framework and the thermal cooling device. The missing part is the DT binding providing a way to describe how the cooling device will work on the system. A first iteration was done by making the cooling device to point to the idle state. Unfortunately it does not make sense because it would need to duplicate the idle state description for each CPU in order to have a different phandle and make the thermal internal framework happy. It was proposed to add an cooling-cells to <3>, unfortunately the thermal framework is expecting a value of <2> as stated by the documentation and it is not possible from the cooling device generic code to loop this third value to the back end cooling device. Another proposal was to add a child 'thermal-idle' node as the SCMI does. This approach allows to have a self-contained configuration for the idle cooling device without colliding with the cpufreq cooling device which is based on the CPU node. In addition, it allows to have the cpufreq cooling device and the idle cooling device to co-exist together as shown in the example. Signed-off-by: Daniel Lezcano --- - V2: - Fixed comment type - Added dual license - Fixed description s/begins to/should/ - Changed name s/duration/duration-us/ - Changed name s/latency/exit-latency-us/ - Removed types for latency / duration - Fixed s/idle-thermal/thermal-idle/ --- .../bindings/thermal/thermal-idle.yaml | 146 ++++++++++++++++++ 1 file changed, 146 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/thermal-idle.yaml diff --git a/Documentation/devicetree/bindings/thermal/thermal-idle.yaml b/Documentation/devicetree/bindings/thermal/thermal-idle.yaml new file mode 100644 index 000000000000..760308fcd2fb --- /dev/null +++ b/Documentation/devicetree/bindings/thermal/thermal-idle.yaml @@ -0,0 +1,146 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright 2020 Linaro Ltd. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/thermal/thermal-idle.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Thermal idle cooling device binding + +maintainers: + - Daniel Lezcano + +description: | + The thermal idle cooling device allows the system to passively + mitigate the temperature on the device by injecting idle cycles, + forcing it to cool down. + + This binding describes the thermal idle node. + +properties: + $nodename: + const: thermal-idle + description: | + A thermal-idle node describes the idle cooling device properties to + cool down efficiently the attached thermal zone. + + '#cooling-cells': + const: 2 + description: | + Must be 2, in order to specify minimum and maximum cooling state used in + the cooling-maps reference. The first cell is the minimum cooling state + and the second cell is the maximum cooling state requested. + + duration-us: + description: | + The idle duration in microsecond the device should cool down. + + exit-latency-us: + description: | + The exit latency constraint in microsecond for the injected + idle state for the device. It is the latency constraint to + apply when selecting an idle state from among all the present + ones. + + +required: + - '#cooling-cells' + +examples: + - | + #include + + // Example: Combining idle cooling device on big CPUs with cpufreq cooling device + cpus { + #address-cells = <2>; + #size-cells = <0>; + + /* ... */ + + cpu_b0: cpu@100 { + device_type = "cpu"; + compatible = "arm,cortex-a72"; + reg = <0x0 0x100>; + enable-method = "psci"; + capacity-dmips-mhz = <1024>; + dynamic-power-coefficient = <436>; + #cooling-cells = <2>; /* min followed by max */ + cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; + thermal-idle { + #cooling-cells = <2>; + duration-us = <10000>; + exit-latency-us = <500>; + }; + }; + + cpu_b1: cpu@101 { + device_type = "cpu"; + compatible = "arm,cortex-a72"; + reg = <0x0 0x101>; + enable-method = "psci"; + capacity-dmips-mhz = <1024>; + dynamic-power-coefficient = <436>; + #cooling-cells = <2>; /* min followed by max */ + cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; + thermal-idle { + #cooling-cells = <2>; + duration-us = <10000>; + exit-latency-us = <500>; + }; + }; + + /* ... */ + + }; + + /* ... */ + + thermal_zones { + cpu_thermal: cpu { + polling-delay-passive = <100>; + polling-delay = <1000>; + + /* ... */ + + trips { + cpu_alert0: cpu_alert0 { + temperature = <65000>; + hysteresis = <2000>; + type = "passive"; + }; + + cpu_alert1: cpu_alert1 { + temperature = <70000>; + hysteresis = <2000>; + type = "passive"; + }; + + cpu_alert2: cpu_alert2 { + temperature = <75000>; + hysteresis = <2000>; + type = "passive"; + }; + + cpu_crit: cpu_crit { + temperature = <95000>; + hysteresis = <2000>; + type = "critical"; + }; + }; + + cooling-maps { + map0 { + trip = <&cpu_alert1>; + cooling-device = <&{/cpus/cpu@100/thermal-idle} 0 15 >, + <&{/cpus/cpu@101/thermal-idle} 0 15>; + }; + + map1 { + trip = <&cpu_alert2>; + cooling-device = + <&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu_b1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + }; + }; + }; + }; -- 2.17.1