From: kbuild test robot <lkp@intel.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>, rui.zhang@intel.com
Cc: kbuild-all@lists.01.org, amit.kucheria@verdurent.com,
srinivas.pandruvada@linux.intel.com, arnd@arndb.de,
rkumbako@codeaurora.org, ilina@codeaurora.org,
linux-pm@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] thermal: core: genetlink support for events/cmd/sampling
Date: Wed, 20 May 2020 02:11:10 +0800 [thread overview]
Message-ID: <202005200203.hKWj9pf4%lkp@intel.com> (raw)
In-Reply-To: <20200515141034.19154-4-daniel.lezcano@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 2666 bytes --]
Hi Daniel,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20200514]
[cannot apply to linus/master v5.7-rc5 v5.7-rc4 v5.7-rc3 v5.7-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Daniel-Lezcano/thermal-core-Add-helpers-to-browse-the-cdev-tz-and-governor-list/20200515-221257
base: c9529331c7a22b8eb7eb03e1e0e221d0f58b43de
config: x86_64-rhel-7.6-kselftests (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/thermal/thermal_netlink.c:69:5: warning: no previous prototype for 'thermal_genl_sampling_temp' [-Wmissing-prototypes]
int thermal_genl_sampling_temp(int id, int temp)
^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/thermal/thermal_netlink.c:509:5: warning: no previous prototype for 'thermal_genl_cmd_dumpit' [-Wmissing-prototypes]
int thermal_genl_cmd_dumpit(struct sk_buff *skb, struct netlink_callback *cb)
^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/thermal/thermal_netlink.c:535:5: warning: no previous prototype for 'thermal_genl_cmd_doit' [-Wmissing-prototypes]
int thermal_genl_cmd_doit(struct sk_buff *skb, struct genl_info *info)
^~~~~~~~~~~~~~~~~~~~~
vim +/thermal_genl_sampling_temp +69 drivers/thermal/thermal_netlink.c
68
> 69 int thermal_genl_sampling_temp(int id, int temp)
70 {
71 struct sk_buff *skb;
72 void *hdr;
73
74 skb = genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
75 if (!skb)
76 return -ENOMEM;
77
78 hdr = genlmsg_put(skb, 0, 0, &thermal_gnl_family, 0,
79 THERMAL_GENL_SAMPLING_TEMP);
80 if (!hdr)
81 return -EMSGSIZE;
82
83 if (nla_put_u32(skb, THERMAL_GENL_ATTR_TZ_ID, id))
84 goto out_cancel;
85
86 if (nla_put_u32(skb, THERMAL_GENL_ATTR_TZ_TEMP, temp))
87 goto out_cancel;
88
89 genlmsg_end(skb, hdr);
90
91 genlmsg_multicast(&thermal_gnl_family, skb, 0, 0, GFP_KERNEL);
92
93 return 0;
94 out_cancel:
95 genlmsg_cancel(skb, hdr);
96 nlmsg_free(skb);
97
98 return -EMSGSIZE;
99 }
100
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49901 bytes --]
next prev parent reply other threads:[~2020-05-19 18:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 14:10 [PATCH 1/4] thermal: core: Add helpers to browse the cdev, tz and governor list Daniel Lezcano
2020-05-15 14:10 ` [PATCH 2/4] thermal: core: Get thermal zone by id Daniel Lezcano
2020-05-15 14:10 ` [PATCH 3/4] thermal: core: Remove old uapi generic netlink Daniel Lezcano
2020-05-15 14:10 ` [PATCH 4/4] thermal: core: genetlink support for events/cmd/sampling Daniel Lezcano
2020-05-15 14:42 ` Srinivas Pandruvada
2020-05-15 14:43 ` Srinivas Pandruvada
2020-05-15 15:09 ` Daniel Lezcano
2020-05-16 12:55 ` [RFC PATCH] thermal: core: thermal_genl_sampling_temp() can be static kbuild test robot
2020-05-19 18:11 ` kbuild test robot [this message]
2020-05-27 22:04 ` [PATCH 4/4] thermal: core: genetlink support for events/cmd/sampling Ram Chandrasekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202005200203.hKWj9pf4%lkp@intel.com \
--to=lkp@intel.com \
--cc=amit.kucheria@verdurent.com \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=ilina@codeaurora.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rkumbako@codeaurora.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).