From: Bjorn Helgaas <helgaas@kernel.org>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc: kjlu@umn.edu, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Vidya Sagar <vidyas@nvidia.com>,
Andrew Murray <amurray@thegoodpenguin.co.uk>,
linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] [v2] PCI: tegra194: Fix runtime PM imbalance on error
Date: Thu, 21 May 2020 10:16:20 -0500 [thread overview]
Message-ID: <20200521151620.GA1135365@bjorn-Precision-5520> (raw)
In-Reply-To: <20200521031355.7022-1-dinghao.liu@zju.edu.cn>
[+cc Rafael, linux-pm]
On Thu, May 21, 2020 at 11:13:49AM +0800, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code. Thus a pairing decrement is needed on
> the error handling path to keep the counter balanced.
I didn't realize there were so many drivers with the exact same issue.
Can we just squash these all into a single patch so we can see them
all together?
Hmm. There are over 1300 callers of pm_runtime_get_sync(), and it
looks like many of them have similar issues, i.e., they have a pattern
like this
ret = pm_runtime_get_sync(dev);
if (ret < 0)
return;
pm_runtime_put(dev);
where there is not a pm_runtime_put() to match every
pm_runtime_get_sync(). Random sample:
nds32_pmu_reserve_hardware
sata_rcar_probe
exynos_trng_probe
ks_sa_rng_probe
omap_aes_probe
sun8i_ss_probe
omap_aes_probe
zynq_gpio_probe
amdgpu_hwmon_show_power_avg
mtk_crtc_ddp_hw_init
...
Surely I'm missing something and these aren't all broken, right?
Maybe we could put together a coccinelle script to scan the tree for
this issue?
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
> drivers/pci/controller/dwc/pcie-tegra194.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index ae30a2fd3716..2c0d2ce16b47 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -1623,7 +1623,7 @@ static int tegra_pcie_config_rp(struct tegra_pcie_dw *pcie)
> ret = pinctrl_pm_select_default_state(dev);
> if (ret < 0) {
> dev_err(dev, "Failed to configure sideband pins: %d\n", ret);
> - goto fail_pinctrl;
> + goto fail_pm_get_sync;
> }
>
> tegra_pcie_init_controller(pcie);
> @@ -1650,9 +1650,8 @@ static int tegra_pcie_config_rp(struct tegra_pcie_dw *pcie)
>
> fail_host_init:
> tegra_pcie_deinit_controller(pcie);
> -fail_pinctrl:
> - pm_runtime_put_sync(dev);
> fail_pm_get_sync:
> + pm_runtime_put_sync(dev);
> pm_runtime_disable(dev);
> return ret;
> }
> --
> 2.17.1
>
next parent reply other threads:[~2020-05-21 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200521031355.7022-1-dinghao.liu@zju.edu.cn>
2020-05-21 15:16 ` Bjorn Helgaas [this message]
2020-05-21 15:25 ` [PATCH] [v2] PCI: tegra194: Fix runtime PM imbalance on error Rafael J. Wysocki
2020-05-22 6:06 ` dinghao.liu
2020-05-22 4:36 ` dinghao.liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521151620.GA1135365@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=amurray@thegoodpenguin.co.uk \
--cc=bhelgaas@google.com \
--cc=dinghao.liu@zju.edu.cn \
--cc=jonathanh@nvidia.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).