From: Mark Brown <broonie@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Dmitry Osipenko <digetx@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Lucas Stach <l.stach@pengutronix.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
peron.clem@gmail.com, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
linux-samsung-soc@vger.kernel.org,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH] regulator: do not balance regulators without constraints
Date: Thu, 28 May 2020 14:43:38 +0100 [thread overview]
Message-ID: <20200528134338.GD3606@sirena.org.uk> (raw)
In-Reply-To: <20200528131130.17984-1-m.szyprowski@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 919 bytes --]
On Thu, May 28, 2020 at 03:11:30PM +0200, Marek Szyprowski wrote:
> Balancing coupled regulators must wait until the clients for all of the
> coupled regualtors set their constraints, otherwise the balancing code
> might change the voltage of the not-yet-constrained regulator to the
> value below the bootloader-configured operation point, what might cause a
> system crash.
This forces every supply to have something which explicitly manages
voltages which means that if one of the coupled supplies doesn't really
care about the voltage (perhaps doesn't even have any explicit
consumers) and just needs to be within a certain range of another supply
then it'll end up restricting things needlessly.
Saravana was trying to do some stuff with sync_state() which might be
interesting here although I have concerns with that approach too:
https://lore.kernel.org/lkml/20200527074057.246606-1-saravanak@google.com/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-05-28 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200528131144eucas1p121b9151996fa3f780a5028f68c69d5ba@eucas1p1.samsung.com>
2020-05-28 13:11 ` [PATCH] regulator: do not balance regulators without constraints Marek Szyprowski
2020-05-28 13:43 ` Mark Brown [this message]
2020-05-29 5:45 ` Marek Szyprowski
2020-05-29 11:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528134338.GD3606@sirena.org.uk \
--to=broonie@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=digetx@gmail.com \
--cc=krzk@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=nm@ti.com \
--cc=peron.clem@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).