From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCEDCC433E0 for ; Mon, 29 Jun 2020 19:13:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CCAF20776 for ; Mon, 29 Jun 2020 19:13:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VgKSnKwU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731581AbgF2TN6 (ORCPT ); Mon, 29 Jun 2020 15:13:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731546AbgF2TNx (ORCPT ); Mon, 29 Jun 2020 15:13:53 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69B2CC0086EA for ; Mon, 29 Jun 2020 02:44:58 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id h5so15835318wrc.7 for ; Mon, 29 Jun 2020 02:44:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ige0bLI228QBtpujPXwJLumrVk0AINfrstrNdcA8YTE=; b=VgKSnKwUGko3Ufn+PVIGXdWOFYC3GeRMX1JUUPmyLweEIpus3fNNVqIF8myZY7hlPE mr8DasZ/JN8K9fhWSlAQYeKQ/YmQ8PYVPaXy/H07HwRtbS2dhvX5wXjvO4nc/yDELJwe 2TbfTcbgSB8q4MeYSkW0iafbaWGyYraCjuEn6v+4xx7kVYviV1W41/a8FGa6sOqE1S1y hH+nJ4gOdQXKp2UOwJD4PSyfxRiI7mNwIJEmAaFSwv5lky0FrvZF/mpAT/cbLZA49uD8 SvtlG08UiwKF3810F0flrzRismFPAR2pXcJ41rA8pIxJwuidFTD83kZ9UeuHX5H/QFm2 haew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ige0bLI228QBtpujPXwJLumrVk0AINfrstrNdcA8YTE=; b=QsW2ULrjkQz/6R/wN0A/A7ThN6cgNvnP5MQP34vnVTNX5ttACK0L3zPCUn+hbnn8Ax SbGS/LssyV4M4b8ceDYGVzONHF7Kwp7SmXXgoPS8ox+KMI/LjCwHmy0GV1Rt4+6dKUap h4Zr+xH7rlnlWBtbOGZUdg6YqqBlB1B3jj4caNWEe3C2wfZ4mJFY5nGS4+mIbiESVWs/ wqLghaeZp7/XD1l18s9GU+2TUX2t5IrGQ3UuqaEBvm9lobeg/74/oEFxAY6IGTyKDoSv /uP3IFFbP2H5Ih6k+e/p8Qy+c5AaxkklO+yGhFAwMofLeFliIIHJR0TBzY9xKJXHeXyI dXMQ== X-Gm-Message-State: AOAM532Q+AF384IwPrHfGPbJTq6dPteFV9At0544h2/tPdzIKeKRtx15 mp7Rae2ZhpdQnySK+jsNm620Aw== X-Google-Smtp-Source: ABdhPJwHWrygg6BiK5fEk9EEnZAfF+5PYEBh9CUJkPtjUQ71I4bDVU2Q2M33ksNBJ9Sr+c3MY7lBAw== X-Received: by 2002:adf:f38f:: with SMTP id m15mr14681272wro.173.1593423896894; Mon, 29 Jun 2020 02:44:56 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:d6cc:2030:37c1:9964]) by smtp.gmail.com with ESMTPSA id 138sm29810979wma.23.2020.06.29.02.44.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 02:44:55 -0700 (PDT) Date: Mon, 29 Jun 2020 10:44:52 +0100 From: Quentin Perret To: Viresh Kumar Cc: Rafael Wysocki , Jonathan Corbet , linux-pm@vger.kernel.org, Vincent Guittot , kernel-team@android.com, tkjos@google.com, adharmap@codeaurora.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4 3/3] cpufreq: Specify default governor on command line Message-ID: <20200629094452.GB1228312@google.com> References: <96b6e6ca02b664194ff3e57e1ec768fbc597bf38.1593418662.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <96b6e6ca02b664194ff3e57e1ec768fbc597bf38.1593418662.git.viresh.kumar@linaro.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Monday 29 Jun 2020 at 13:55:00 (+0530), Viresh Kumar wrote: > static int __init cpufreq_core_init(void) > { > + struct cpufreq_governor *gov = cpufreq_default_governor(); > + > if (cpufreq_disabled()) > return -ENODEV; > > cpufreq_global_kobject = kobject_create_and_add("cpufreq", &cpu_subsys.dev_root->kobj); > BUG_ON(!cpufreq_global_kobject); > > + if (!strlen(default_governor)) Should we test '!strlen(default_governor) && gov' here actually? We check the return value of cpufreq_default_governor() in cpufreq_init_policy(), so I'm guessing we should do the same here to be on the safe side. > + strncpy(default_governor, gov->name, CPUFREQ_NAME_LEN); > + > return 0; > } > module_param(off, int, 0444); > +module_param_string(default_governor, default_governor, CPUFREQ_NAME_LEN, 0444); > core_initcall(cpufreq_core_init); > -- > 2.25.0.rc1.19.g042ed3e048af Other than that, the whole series looks good to me. Thanks, Quentin