From: Maxime Ripard <maxime@cerno.tech>
To: Frank Lee <frank@allwinnertech.com>
Cc: robh+dt@kernel.org, wens@csie.org, mturquette@baylibre.com,
sboyd@kernel.org, srinivas.kandagatla@linaro.org,
linus.walleij@linaro.org, anarsoul@gmail.com,
tiny.windzz@gmail.com, rui.zhang@intel.com,
daniel.lezcano@linaro.org, amit.kucheria@verdurent.com,
p.zabel@pengutronix.de, clabbe@baylibre.com, icenowy@aosc.io,
megous@megous.com, karlp@tweak.net.au, bage@linutronix.de,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org,
huangshuosheng@allwinnertech.com, liyong@allwinnertech.com
Subject: Re: [PATCH v2 03/11] dt-bindings: pinctrl: sunxi: Add A100 pinctrl bindings
Date: Mon, 29 Jun 2020 17:01:05 +0200 [thread overview]
Message-ID: <20200629150105.5yisonmm34qlk4jh@gilmour.lan> (raw)
In-Reply-To: <20200622025907.32574-4-frank@allwinnertech.com>
[-- Attachment #1: Type: text/plain, Size: 2293 bytes --]
Hi,
On Mon, Jun 22, 2020 at 10:58:59AM +0800, Frank Lee wrote:
> Add device tree binding Documentation details for A100 pinctrl driver,
> whic has an r pin controller and a pin controller with more irq lines.
>
> Signed-off-by: Frank Lee <frank@allwinnertech.com>
> ---
> .../pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 72 +++++++++++++---------
> 1 file changed, 43 insertions(+), 29 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> index bfefd09..2ac5eb5 100644
> --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml
> @@ -48,6 +48,8 @@ properties:
> - allwinner,sun9i-a80-r-pinctrl
> - allwinner,sun50i-a64-pinctrl
> - allwinner,sun50i-a64-r-pinctrl
> + - allwinner,sun50i-a100-pinctrl
> + - allwinner,sun50i-a100-r-pinctrl
> - allwinner,sun50i-h5-pinctrl
> - allwinner,sun50i-h6-pinctrl
> - allwinner,sun50i-h6-r-pinctrl
> @@ -144,75 +146,87 @@ allOf:
> # FIXME: We should have the pin bank supplies here, but not a lot of
> # boards are defining it at the moment so it would generate a lot of
> # warnings.
> -
> - if:
> properties:
> compatible:
> enum:
> - - allwinner,sun9i-a80-pinctrl
> + - allwinner,sun50i-a100-pinctrl
>
> then:
> properties:
> interrupts:
> - minItems: 5
> - maxItems: 5
> + minItems: 7
> + maxItems: 7
>
> else:
> if:
> properties:
> compatible:
> enum:
> - - allwinner,sun6i-a31-pinctrl
> - - allwinner,sun6i-a31s-pinctrl
> - - allwinner,sun50i-h6-pinctrl
> + - allwinner,sun9i-a80-pinctrl
The diff is a bit of a mess here. I guess you just added a new if with
the A100 pinctrl compatible?
Also, since it's a new SoC and we don't really have to care about the
existing DT for boards, it would be great if you could make the gpio
banks supplies required.
Thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-06-29 18:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 2:58 [PATCH v2 00/11] Allwinner A100 Initial support Frank Lee
2020-06-22 2:58 ` [PATCH v2 01/11] dt-bindings: clk: sunxi-ccu: add compatible string for A100 CCU and R-CCU Frank Lee
2020-06-22 2:58 ` [PATCH v2 02/11] clk: sunxi-ng: add support for the Allwinner A100 CCU Frank Lee
2020-06-29 14:58 ` Maxime Ripard
2020-06-22 2:58 ` [PATCH v2 03/11] dt-bindings: pinctrl: sunxi: Add A100 pinctrl bindings Frank Lee
2020-06-29 15:01 ` Maxime Ripard [this message]
2020-06-22 2:59 ` [PATCH v2 04/11] pinctrl: sunxi: add support for the Allwinner A100 pin controller Frank Lee
2020-06-22 2:59 ` [PATCH v2 05/11] dt-bindings: nvmem: SID: add binding for A100's SID controller Frank Lee
2020-06-22 2:59 ` [PATCH v2 06/11] nvmem: sunxi-sid: add support " Frank Lee
2020-06-29 15:07 ` Maxime Ripard
2020-06-22 2:59 ` [PATCH v2 07/11] dt-bindings: thermal: sun8i: Add binding for A100's THS controller Frank Lee
2020-06-22 2:59 ` [PATCH v2 08/11] thermal: sun8i: Add A100's THS controller support Frank Lee
2020-06-29 15:10 ` Maxime Ripard
2020-06-22 2:59 ` [PATCH v2 09/11] arm64: allwinner: A100: add the basical Allwinner A100 DTSI file Frank Lee
2020-06-29 15:21 ` Maxime Ripard
2020-06-22 2:59 ` [PATCH v2 10/11] dt-bindings: arm: sunxi: Add Allwinner A100 Perf1 Board bindings Frank Lee
2020-06-22 2:59 ` [PATCH v2 11/11] arm64: allwinner: A100: add support for Allwinner Perf1 board Frank Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629150105.5yisonmm34qlk4jh@gilmour.lan \
--to=maxime@cerno.tech \
--cc=amit.kucheria@verdurent.com \
--cc=anarsoul@gmail.com \
--cc=bage@linutronix.de \
--cc=clabbe@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=frank@allwinnertech.com \
--cc=huangshuosheng@allwinnertech.com \
--cc=icenowy@aosc.io \
--cc=karlp@tweak.net.au \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=liyong@allwinnertech.com \
--cc=megous@megous.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sboyd@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiny.windzz@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).